feat(dashboard): add scheduled task actions (#31)

This commit is contained in:
Eyejoker
2026-04-27 01:36:40 +09:00
committed by GitHub
parent 6abbfdd6af
commit 22bd24ec88
6 changed files with 376 additions and 3 deletions

View File

@@ -233,6 +233,117 @@ describe('web dashboard server handler', () => {
expect(ciFailure?.summary).not.toContain('plain-secret-value');
});
it('mutates scheduled tasks through explicit action endpoints', async () => {
let task: ScheduledTask | undefined = makeTask({
id: 'ci-watch-1',
prompt: '[BACKGROUND CI WATCH]\nwatch',
});
const updates: Array<Partial<ScheduledTask>> = [];
const deleted: string[] = [];
const handler = createWebDashboardHandler({
readStatusSnapshots: () => [],
getTasks: () => (task ? [task] : []),
getTaskById: (id) => (task?.id === id ? task : undefined),
updateTask: (id, update) => {
expect(id).toBe('ci-watch-1');
updates.push(update);
task = task ? { ...task, ...update } : task;
},
deleteTask: (id) => {
deleted.push(id);
task = undefined;
},
getPairedTasks: () => [],
});
const pause = await handler(
new Request('http://localhost/api/tasks/ci-watch-1/actions', {
method: 'POST',
headers: { 'content-type': 'application/json' },
body: JSON.stringify({ action: 'pause' }),
}),
);
expect(pause.status).toBe(200);
await expect(pause.json()).resolves.toMatchObject({
ok: true,
task: { id: 'ci-watch-1', status: 'paused' },
});
expect(updates.at(-1)).toMatchObject({
status: 'paused',
suspended_until: null,
});
const resume = await handler(
new Request('http://localhost/api/tasks/ci-watch-1/actions', {
method: 'POST',
headers: { 'content-type': 'application/json' },
body: JSON.stringify({ action: 'resume' }),
}),
);
expect(resume.status).toBe(200);
await expect(resume.json()).resolves.toMatchObject({
ok: true,
task: { id: 'ci-watch-1', status: 'active' },
});
expect(updates.at(-1)).toMatchObject({
status: 'active',
suspended_until: null,
});
const cancel = await handler(
new Request('http://localhost/api/tasks/ci-watch-1/actions', {
method: 'POST',
headers: { 'content-type': 'application/json' },
body: JSON.stringify({ action: 'cancel' }),
}),
);
expect(cancel.status).toBe(200);
await expect(cancel.json()).resolves.toEqual({
ok: true,
id: 'ci-watch-1',
deleted: true,
});
expect(deleted).toEqual(['ci-watch-1']);
});
it('rejects invalid scheduled task actions', async () => {
const handler = createWebDashboardHandler({
readStatusSnapshots: () => [],
getTasks: () => [],
getTaskById: (id) =>
id === 'task-1' ? makeTask({ id: 'task-1' }) : undefined,
updateTask: () => {
throw new Error('updateTask should not be called');
},
getPairedTasks: () => [],
});
const invalid = await handler(
new Request('http://localhost/api/tasks/task-1/actions', {
method: 'POST',
headers: { 'content-type': 'application/json' },
body: JSON.stringify({ action: 'restart-everything' }),
}),
);
expect(invalid.status).toBe(400);
const missing = await handler(
new Request('http://localhost/api/tasks/missing/actions', {
method: 'POST',
headers: { 'content-type': 'application/json' },
body: JSON.stringify({ action: 'pause' }),
}),
);
expect(missing.status).toBe(404);
const wrongMethod = await handler(
new Request('http://localhost/api/tasks/task-1/actions', {
method: 'GET',
}),
);
expect(wrongMethod.status).toBe(405);
});
it('serves Vite static assets and falls back to index for SPA routes', async () => {
const staticDir = fs.mkdtempSync(
path.join(os.tmpdir(), 'ejclaw-dashboard-'),

View File

@@ -2,7 +2,13 @@ import fs from 'fs';
import path from 'path';
import { WEB_DASHBOARD } from './config.js';
import { getAllOpenPairedTasks, getAllTasks } from './db.js';
import {
deleteTask,
getAllOpenPairedTasks,
getAllTasks,
getTaskById,
updateTask,
} from './db.js';
import { logger } from './logger.js';
import {
readStatusSnapshots,
@@ -21,6 +27,12 @@ export interface WebDashboardHandlerOptions {
statusMaxAgeMs?: number;
readStatusSnapshots?: (maxAgeMs: number) => StatusSnapshot[];
getTasks?: () => ScheduledTask[];
getTaskById?: (id: string) => ScheduledTask | undefined;
updateTask?: (
id: string,
updates: Partial<Pick<ScheduledTask, 'status' | 'suspended_until'>>,
) => void;
deleteTask?: (id: string) => void;
getPairedTasks?: () => PairedTask[];
now?: () => string;
}
@@ -101,16 +113,84 @@ function serveStaticFile(staticDir: string, pathname: string): Response {
});
}
type TaskAction = 'pause' | 'resume' | 'cancel';
function parseTaskActionPath(pathname: string): string | null {
const match = pathname.match(/^\/api\/tasks\/([^/]+)\/actions$/);
if (!match) return null;
try {
return decodeURIComponent(match[1]);
} catch {
return null;
}
}
function isTaskAction(value: unknown): value is TaskAction {
return value === 'pause' || value === 'resume' || value === 'cancel';
}
async function readTaskAction(request: Request): Promise<TaskAction | null> {
try {
const body = (await request.json()) as { action?: unknown };
return isTaskAction(body.action) ? body.action : null;
} catch {
return null;
}
}
export function createWebDashboardHandler(
opts: WebDashboardHandlerOptions = {},
): (request: Request) => Response | Promise<Response> {
const readSnapshots = opts.readStatusSnapshots ?? readStatusSnapshots;
const loadTasks = opts.getTasks ?? getAllTasks;
const loadTaskById = opts.getTaskById ?? getTaskById;
const mutateTask = opts.updateTask ?? updateTask;
const removeTask = opts.deleteTask ?? deleteTask;
const loadPairedTasks = opts.getPairedTasks ?? getAllOpenPairedTasks;
const statusMaxAgeMs = opts.statusMaxAgeMs ?? DEFAULT_STATUS_MAX_AGE_MS;
return (request: Request): Response => {
return async (request: Request): Promise<Response> => {
const url = new URL(request.url);
const actionTaskId = parseTaskActionPath(url.pathname);
if (actionTaskId) {
if (request.method !== 'POST') {
return jsonResponse({ error: 'Method not allowed' }, { status: 405 });
}
const action = await readTaskAction(request);
if (!action) {
return jsonResponse({ error: 'Invalid task action' }, { status: 400 });
}
const task = loadTaskById(actionTaskId);
if (!task) {
return jsonResponse({ error: 'Task not found' }, { status: 404 });
}
if (task.status === 'completed' && action !== 'cancel') {
return jsonResponse(
{ error: 'Completed tasks cannot be changed' },
{ status: 409 },
);
}
if (action === 'cancel') {
removeTask(actionTaskId);
return jsonResponse({ ok: true, id: actionTaskId, deleted: true });
}
mutateTask(actionTaskId, {
status: action === 'pause' ? 'paused' : 'active',
suspended_until: null,
});
const updatedTask = loadTaskById(actionTaskId);
return jsonResponse({
ok: true,
task: updatedTask ? sanitizeScheduledTask(updatedTask) : null,
});
}
if (request.method !== 'GET' && request.method !== 'HEAD') {
return jsonResponse({ error: 'Method not allowed' }, { status: 405 });