From 8b458e9b0e4f65d76e77b3ca871363adfc53d105 Mon Sep 17 00:00:00 2001 From: ejclaw Date: Wed, 29 Apr 2026 13:02:51 +0900 Subject: [PATCH] test: remove duplicate handoff helper coverage --- src/message-runtime.test.ts | 55 +------------------------------------ src/message-runtime.ts | 4 --- 2 files changed, 1 insertion(+), 58 deletions(-) diff --git a/src/message-runtime.test.ts b/src/message-runtime.test.ts index 6bf1b59..cc5f0d7 100644 --- a/src/message-runtime.test.ts +++ b/src/message-runtime.test.ts @@ -284,11 +284,7 @@ vi.mock('./session-commands.js', () => ({ import * as agentRunner from './agent-runner.js'; import * as db from './db.js'; import { resolveGroupIpcPath } from './group-folder.js'; -import { - createMessageRuntime, - resolveHandoffCursorKey, - resolveHandoffRoleOverride, -} from './message-runtime.js'; +import { createMessageRuntime } from './message-runtime.js'; import { buildPendingPairedTurn, resolveBotOnlyPairedFollowUpAction, @@ -342,55 +338,6 @@ describe('createMessageRuntime', () => { vi.mocked(config.isReviewService).mockReturnValue(false); }); - it('prefers intended_role over reason prefixes for handoff role resolution', () => { - expect( - resolveHandoffRoleOverride({ - target_role: 'arbiter', - intended_role: 'reviewer', - reason: 'reviewer-claude-429', - }), - ).toBe('arbiter'); - expect( - resolveHandoffRoleOverride({ - target_role: null, - intended_role: 'reviewer', - reason: 'claude-429', - }), - ).toBe('reviewer'); - expect( - resolveHandoffRoleOverride({ - target_role: null, - intended_role: null, - reason: 'arbiter-claude-429', - }), - ).toBe('arbiter'); - expect( - resolveHandoffRoleOverride({ - target_role: null, - intended_role: null, - reason: 'reviewer-claude-usage-exhausted', - }), - ).toBe('reviewer'); - expect( - resolveHandoffRoleOverride({ - target_role: null, - intended_role: null, - reason: 'claude-usage-exhausted', - }), - ).toBeUndefined(); - }); - - it('uses role-scoped cursor keys for reviewer and arbiter handoffs', () => { - expect(resolveHandoffCursorKey('group@test')).toBe('group@test'); - expect(resolveHandoffCursorKey('group@test', 'owner')).toBe('group@test'); - expect(resolveHandoffCursorKey('group@test', 'reviewer')).toBe( - 'group@test:reviewer', - ); - expect(resolveHandoffCursorKey('group@test', 'arbiter')).toBe( - 'group@test:arbiter', - ); - }); - it('ignores generic failure bot messages in paired rooms', async () => { const chatJid = 'group@test'; const group = makeGroup('codex'); diff --git a/src/message-runtime.ts b/src/message-runtime.ts index a86fd70..4cdd8db 100644 --- a/src/message-runtime.ts +++ b/src/message-runtime.ts @@ -39,10 +39,6 @@ import { transitionPairedTaskStatus } from './paired-task-status.js'; import { Channel, NewMessage, RegisteredGroup } from './types.js'; import { createScopedLogger, logger } from './logger.js'; import { hasReviewerLease } from './service-routing.js'; -export { - resolveHandoffCursorKey, - resolveHandoffRoleOverride, -} from './message-runtime-shared.js'; import { getFixedRoleChannelName, getMissingRoleChannelMessage,