claude-bot/EJClaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: route scheduled watcher output by room role

Browse Source
This commit is contained in:
ejclaw
2026-05-26 04:17:59 +09:00
parent d770c40862
commit a6e1b8172c
15 changed files with 288 additions and 156 deletions
Download Patch File Download Diff File Expand all files Collapse all files

140
src/task-scheduler.test.ts
View File

@@ -448,146 +448,6 @@ describe('task scheduler', () => {
expect(task?.next_run).not.toBeNull();
});
it('uses the reviewer bot identity for paired-room scheduled output', async () => {
const dueAt = new Date(Date.now() - 60_000).toISOString();
createTask({
id: 'task-paired-reviewer-output',
group_folder: 'paired-group',
chat_jid: 'paired@g.us',
agent_type: 'codex',
prompt: 'paired task',
schedule_type: 'once',
schedule_value: dueAt,
context_mode: 'isolated',
next_run: dueAt,
status: 'active',
created_at: '2026-02-22T00:00:00.000Z',
});
vi.mocked(serviceRouting.hasReviewerLease).mockImplementation(
(jid) => jid === 'paired@g.us',
);
(runAgentProcessMock as any).mockImplementationOnce(
async (
_group: unknown,
_input: unknown,
_onProcess: unknown,
onOutput?: (output: Record<string, unknown>) => Promise<void>,
) => {
await onOutput?.({
status: 'success',
phase: 'final',
result: 'paired reviewer output',
});
return {
status: 'success',
result: 'paired reviewer output',
};
},
);
const enqueueTask = vi.fn(
async (_groupJid: string, _taskId: string, fn: () => Promise<void>) => {
await fn();
},
);
const sendMessage = vi.fn(async () => {});
const sendMessageViaReviewerBot = vi.fn(async () => {});
await runSchedulerTickOnce({
serviceAgentType: 'codex',
roomBindings: () => ({
'paired@g.us': {
name: 'Paired',
folder: 'paired-group',
trigger: '@Codex',
added_at: '2026-02-22T00:00:00.000Z',
agentType: 'codex',
},
}),
getSessions: () => ({}),
queue: { enqueueTask } as any,
onProcess: () => {},
sendMessage,
sendMessageViaReviewerBot,
});
expect(runAgentProcessMock).toHaveBeenCalledTimes(1);
expect(sendMessageViaReviewerBot).toHaveBeenCalledTimes(1);
expect(sendMessageViaReviewerBot).toHaveBeenCalledWith(
'paired@g.us',
'paired reviewer output',
);
expect(sendMessage).not.toHaveBeenCalled();
});
it('fails closed for paired-room scheduled output when the reviewer bot is missing', async () => {
const dueAt = new Date(Date.now() - 60_000).toISOString();
createTask({
id: 'task-paired-reviewer-missing',
group_folder: 'paired-group',
chat_jid: 'paired@g.us',
agent_type: 'codex',
prompt: 'paired task',
schedule_type: 'once',
schedule_value: dueAt,
context_mode: 'isolated',
next_run: dueAt,
status: 'active',
created_at: '2026-02-22T00:00:00.000Z',
});
vi.mocked(serviceRouting.hasReviewerLease).mockImplementation(
(jid) => jid === 'paired@g.us',
);
(runAgentProcessMock as any).mockImplementationOnce(
async (
_group: unknown,
_input: unknown,
_onProcess: unknown,
onOutput?: (output: Record<string, unknown>) => Promise<void>,
) => {
await onOutput?.({
status: 'success',
phase: 'final',
result: 'paired reviewer output',
});
return {
status: 'success',
result: 'paired reviewer output',
};
},
);
const enqueueTask = vi.fn(
async (_groupJid: string, _taskId: string, fn: () => Promise<void>) => {
await fn();
},
);
const sendMessage = vi.fn(async () => {});
await runSchedulerTickOnce({
serviceAgentType: 'codex',
roomBindings: () => ({
'paired@g.us': {
name: 'Paired',
folder: 'paired-group',
trigger: '@Codex',
added_at: '2026-02-22T00:00:00.000Z',
agentType: 'codex',
},
}),
getSessions: () => ({}),
queue: { enqueueTask } as any,
onProcess: () => {},
sendMessage,
});
expect(runAgentProcessMock).toHaveBeenCalledTimes(1);
expect(sendMessage).not.toHaveBeenCalled();
expect(getTaskById('task-paired-reviewer-missing')).toBeDefined();
});
it('keeps group-context tasks on the chat queue key', async () => {
const dueAt = new Date(Date.now() - 60_000).toISOString();
createTask({