feat: add high-risk paired plan gate

src/message-runtime.test.ts

@@ -38,6 +38,10 @@ vi.mock('./paired-execution-context.js', () => ({
   completePairedExecutionContext: vi.fn(),
   markRoomReviewReady: vi.fn(() => null),
   formatRoomReviewReadyMessage: vi.fn(() => null),
+  setRoomTaskRiskLevel: vi.fn(() => null),
+  recordRoomPlan: vi.fn(() => null),
+  approveRoomPlan: vi.fn(() => null),
+  requestRoomPlanChanges: vi.fn(() => null),
 }));
 
 vi.mock('./db.js', () => {
@@ -312,6 +316,249 @@ describe('createMessageRuntime', () => {
     expect(channel.sendMessage).toHaveBeenCalledWith(chatJid, pendingMessage);
   });
 
+  it('surfaces the high-risk plan gate message through the message-runtime /review path', async () => {
+    const chatJid = 'group@test';
+    const group = {
+      ...makeGroup('codex'),
+      workDir: '/repo/canonical',
+    };
+    const channel = makeChannel(chatJid);
+    const saveState = vi.fn();
+    const lastAgentTimestamps: Record<string, string> = {};
+    const blockedMessage = [
+      'Plan review is required before formal review for this high-risk task.',
+      '- Task: paired-task-1',
+      '- Plan status: pending',
+      'Ask the owner to record a plan and have the reviewer approve it before /review.',
+    ].join('\n');
+
+    vi.mocked(db.isPairedRoomJid).mockReturnValue(true);
+    vi.mocked(db.getMessagesSince).mockReturnValue([
+      {
+        id: 'msg-review',
+        chat_jid: chatJid,
+        sender: 'me@test',
+        sender_name: 'Me',
+        content: '/review',
+        timestamp: '2026-03-29T00:00:00.000Z',
+        is_from_me: true,
+      },
+    ]);
+    const actualSessionCommands =
+      await vi.importActual<typeof import('./session-commands.js')>(
+        './session-commands.js',
+      );
+    vi.mocked(sessionCommands.handleSessionCommand).mockImplementation((opts) =>
+      actualSessionCommands.handleSessionCommand(opts),
+    );
+    vi.mocked(pairedExecutionContext.markRoomReviewReady).mockReturnValue({
+      status: 'blocked',
+      task: {
+        id: 'paired-task-1',
+        chat_jid: chatJid,
+        group_folder: group.folder,
+        owner_service_id: 'claude',
+        reviewer_service_id: 'codex-main',
+        title: null,
+        source_ref: 'HEAD',
+        task_policy: 'autonomous',
+        risk_level: 'high',
+        plan_status: 'pending',
+        review_requested_at: null,
+        status: 'plan_review_pending',
+        created_at: '2026-03-29T00:00:00.000Z',
+        updated_at: '2026-03-29T00:00:00.000Z',
+      },
+      blockedReason: 'plan-review-required',
+    });
+    vi.mocked(
+      pairedExecutionContext.formatRoomReviewReadyMessage,
+    ).mockReturnValue(blockedMessage);
+
+    const runtime = createMessageRuntime({
+      assistantName: 'Andy',
+      idleTimeout: 1_000,
+      pollInterval: 1_000,
+      timezone: 'UTC',
+      triggerPattern: /^@Andy\b/i,
+      channels: [channel],
+      queue: {
+        registerProcess: vi.fn(),
+        closeStdin: vi.fn(),
+        notifyIdle: vi.fn(),
+      } as any,
+      getRegisteredGroups: () => ({ [chatJid]: group }),
+      getSessions: () => ({}),
+      getLastTimestamp: () => '',
+      setLastTimestamp: vi.fn(),
+      getLastAgentTimestamps: () => lastAgentTimestamps,
+      saveState,
+      persistSession: vi.fn(),
+      clearSession: vi.fn(),
+    });
+
+    const result = await runtime.processGroupMessages(chatJid, {
+      runId: 'run-review-blocked',
+      reason: 'messages',
+    });
+
+    expect(result).toBe(true);
+    expect(channel.sendMessage).toHaveBeenCalledWith(chatJid, blockedMessage);
+  });
+
+  it('routes /approve-plan through reviewer context in the message-runtime path', async () => {
+    const chatJid = 'group@test';
+    const group = {
+      ...makeGroup('codex'),
+      workDir: '/repo/canonical',
+    };
+    const channel = makeChannel(chatJid);
+    const saveState = vi.fn();
+    const lastAgentTimestamps: Record<string, string> = {};
+
+    vi.mocked(db.isPairedRoomJid).mockReturnValue(true);
+    vi.mocked(db.getMessagesSince).mockReturnValue([
+      {
+        id: 'msg-approve-plan',
+        chat_jid: chatJid,
+        sender: 'me@test',
+        sender_name: 'Me',
+        content: '/approve-plan',
+        timestamp: '2026-03-29T00:00:00.000Z',
+        is_from_me: true,
+      },
+    ]);
+    const actualSessionCommands =
+      await vi.importActual<typeof import('./session-commands.js')>(
+        './session-commands.js',
+      );
+    vi.mocked(sessionCommands.handleSessionCommand).mockImplementation((opts) =>
+      actualSessionCommands.handleSessionCommand(opts),
+    );
+    vi.mocked(pairedExecutionContext.approveRoomPlan).mockReturnValue(
+      'Plan approved.\n- Task: paired-task-1',
+    );
+
+    const runtime = createMessageRuntime({
+      assistantName: 'Andy',
+      idleTimeout: 1_000,
+      pollInterval: 1_000,
+      timezone: 'UTC',
+      triggerPattern: /^@Andy\b/i,
+      channels: [channel],
+      queue: {
+        registerProcess: vi.fn(),
+        closeStdin: vi.fn(),
+        notifyIdle: vi.fn(),
+      } as any,
+      getRegisteredGroups: () => ({ [chatJid]: group }),
+      getSessions: () => ({}),
+      getLastTimestamp: () => '',
+      setLastTimestamp: vi.fn(),
+      getLastAgentTimestamps: () => lastAgentTimestamps,
+      saveState,
+      persistSession: vi.fn(),
+      clearSession: vi.fn(),
+    });
+
+    const result = await runtime.processGroupMessages(chatJid, {
+      runId: 'run-approve-plan',
+      reason: 'messages',
+    });
+
+    expect(result).toBe(true);
+    expect(pairedExecutionContext.approveRoomPlan).toHaveBeenCalledWith(
+      expect.objectContaining({
+        chatJid,
+        roomRoleContext: expect.objectContaining({
+          role: 'reviewer',
+          serviceId: 'codex-main',
+        }),
+      }),
+    );
+    expect(channel.sendMessage).toHaveBeenCalledWith(
+      chatJid,
+      'Plan approved.\n- Task: paired-task-1',
+    );
+  });
+
+  it('routes /request-plan-changes through reviewer context in the message-runtime path', async () => {
+    const chatJid = 'group@test';
+    const group = {
+      ...makeGroup('codex'),
+      workDir: '/repo/canonical',
+    };
+    const channel = makeChannel(chatJid);
+    const saveState = vi.fn();
+    const lastAgentTimestamps: Record<string, string> = {};
+
+    vi.mocked(db.isPairedRoomJid).mockReturnValue(true);
+    vi.mocked(db.getMessagesSince).mockReturnValue([
+      {
+        id: 'msg-request-plan-changes',
+        chat_jid: chatJid,
+        sender: 'me@test',
+        sender_name: 'Me',
+        content: '/request-plan-changes tighten scope',
+        timestamp: '2026-03-29T00:00:00.000Z',
+        is_from_me: true,
+      },
+    ]);
+    const actualSessionCommands =
+      await vi.importActual<typeof import('./session-commands.js')>(
+        './session-commands.js',
+      );
+    vi.mocked(sessionCommands.handleSessionCommand).mockImplementation((opts) =>
+      actualSessionCommands.handleSessionCommand(opts),
+    );
+    vi.mocked(pairedExecutionContext.requestRoomPlanChanges).mockReturnValue(
+      'Plan changes requested.\n- Task: paired-task-1',
+    );
+
+    const runtime = createMessageRuntime({
+      assistantName: 'Andy',
+      idleTimeout: 1_000,
+      pollInterval: 1_000,
+      timezone: 'UTC',
+      triggerPattern: /^@Andy\b/i,
+      channels: [channel],
+      queue: {
+        registerProcess: vi.fn(),
+        closeStdin: vi.fn(),
+        notifyIdle: vi.fn(),
+      } as any,
+      getRegisteredGroups: () => ({ [chatJid]: group }),
+      getSessions: () => ({}),
+      getLastTimestamp: () => '',
+      setLastTimestamp: vi.fn(),
+      getLastAgentTimestamps: () => lastAgentTimestamps,
+      saveState,
+      persistSession: vi.fn(),
+      clearSession: vi.fn(),
+    });
+
+    const result = await runtime.processGroupMessages(chatJid, {
+      runId: 'run-request-plan-changes',
+      reason: 'messages',
+    });
+
+    expect(result).toBe(true);
+    expect(pairedExecutionContext.requestRoomPlanChanges).toHaveBeenCalledWith(
+      expect.objectContaining({
+        chatJid,
+        roomRoleContext: expect.objectContaining({
+          role: 'reviewer',
+          serviceId: 'codex-main',
+        }),
+        note: 'tighten scope',
+      }),
+    );
+    expect(channel.sendMessage).toHaveBeenCalledWith(
+      chatJid,
+      'Plan changes requested.\n- Task: paired-task-1',
+    );
+  });
+
   it('ignores generic failure bot messages in paired rooms', async () => {
     const chatJid = 'group@test';
     const group = makeGroup('codex');