fix(paired): cap consecutive reviewer silent-failure retries

src/db/base-schema.ts

@@ -142,6 +142,7 @@ export function applyBaseSchema(database: Database): void {
       review_requested_at TEXT,
       round_trip_count INTEGER NOT NULL DEFAULT 0,
       owner_failure_count INTEGER NOT NULL DEFAULT 0,
+      reviewer_failure_count INTEGER NOT NULL DEFAULT 0,
       owner_step_done_streak INTEGER NOT NULL DEFAULT 0,
       finalize_step_done_count INTEGER NOT NULL DEFAULT 0,
       task_done_then_user_reopen_count INTEGER NOT NULL DEFAULT 0,

src/db/bootstrap.test.ts

@@ -43,6 +43,7 @@ function getExpectedSchemaMigrations(): Array<{
     { version: 16, name: 'room_skill_overrides' },
     { version: 17, name: 'scheduled_task_room_role' },
     { version: 18, name: 'paired_turn_output_attachments' },
+    { version: 19, name: 'reviewer_failure_count' },
   ];
 }
 

src/db/migrations/019_reviewer-failure-count.ts

@@ -0,0 +1,23 @@
+import type { Database } from 'bun:sqlite';
+
+import { tableHasColumn } from './helpers.js';
+import type { SchemaMigrationDefinition } from './types.js';
+
+export const REVIEWER_FAILURE_COUNT_MIGRATION: SchemaMigrationDefinition = {
+  version: 19,
+  name: 'reviewer_failure_count',
+  apply(database: Database) {
+    if (!tableHasColumn(database, 'paired_tasks', 'reviewer_failure_count')) {
+      database.exec(`
+        ALTER TABLE paired_tasks
+        ADD COLUMN reviewer_failure_count INTEGER NOT NULL DEFAULT 0
+      `);
+    }
+
+    database.exec(`
+      UPDATE paired_tasks
+         SET reviewer_failure_count = 0
+       WHERE reviewer_failure_count IS NULL
+    `);
+  },
+};

src/db/migrations/index.ts

@@ -18,6 +18,7 @@ import { TURN_PROGRESS_TEXT_MIGRATION } from './015_turn-progress-text.js';
 import { ROOM_SKILL_OVERRIDES_MIGRATION } from './016_room-skill-overrides.js';
 import { SCHEDULED_TASK_ROOM_ROLE_MIGRATION } from './017_scheduled-task-room-role.js';
 import { PAIRED_TURN_OUTPUT_ATTACHMENTS_MIGRATION } from './018_paired-turn-output-attachments.js';
+import { REVIEWER_FAILURE_COUNT_MIGRATION } from './019_reviewer-failure-count.js';
 import type {
   SchemaMigrationArgs,
   SchemaMigrationDefinition,
@@ -44,6 +45,7 @@ const ORDERED_SCHEMA_MIGRATIONS: readonly SchemaMigrationDefinition[] = [
   ROOM_SKILL_OVERRIDES_MIGRATION,
   SCHEDULED_TASK_ROOM_ROLE_MIGRATION,
   PAIRED_TURN_OUTPUT_ATTACHMENTS_MIGRATION,
+  REVIEWER_FAILURE_COUNT_MIGRATION,
 ];
 
 function ensureSchemaMigrationsTable(database: Database): void {

src/db/paired-state.ts

@@ -50,6 +50,7 @@ export type PairedTaskUpdates = Partial<
     | 'review_requested_at'
     | 'round_trip_count'
     | 'owner_failure_count'
+    | 'reviewer_failure_count'
     | 'owner_step_done_streak'
     | 'finalize_step_done_count'
     | 'task_done_then_user_reopen_count'
@@ -176,6 +177,7 @@ export function createPairedTaskInDatabase(
           review_requested_at,
           round_trip_count,
           owner_failure_count,
+          reviewer_failure_count,
           owner_step_done_streak,
           finalize_step_done_count,
           task_done_then_user_reopen_count,
@@ -187,7 +189,7 @@ export function createPairedTaskInDatabase(
           created_at,
           updated_at
         )
-        VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
+        VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
       `,
     )
     .run(
@@ -205,6 +207,7 @@ export function createPairedTaskInDatabase(
       task.review_requested_at,
       task.round_trip_count,
       task.owner_failure_count ?? 0,
+      task.reviewer_failure_count ?? 0,
       task.owner_step_done_streak ?? 0,
       task.finalize_step_done_count ?? 0,
       task.task_done_then_user_reopen_count ?? 0,
@@ -339,6 +342,10 @@ export function updatePairedTaskInDatabase(
     fields.push('owner_failure_count = ?');
     values.push(updates.owner_failure_count);
   }
+  if (updates.reviewer_failure_count !== undefined) {
+    fields.push('reviewer_failure_count = ?');
+    values.push(updates.reviewer_failure_count);
+  }
   if (updates.owner_step_done_streak !== undefined) {
     fields.push('owner_step_done_streak = ?');
     values.push(updates.owner_step_done_streak);
@@ -418,6 +425,10 @@ export function updatePairedTaskIfUnchangedInDatabase(
     fields.push('owner_failure_count = ?');
     values.push(updates.owner_failure_count);
   }
+  if (updates.reviewer_failure_count !== undefined) {
+    fields.push('reviewer_failure_count = ?');
+    values.push(updates.reviewer_failure_count);
+  }
   if (updates.owner_step_done_streak !== undefined) {
     fields.push('owner_step_done_streak = ?');
     values.push(updates.owner_step_done_streak);