refactor: remove container references from setup, use host process runners
- setup/container.ts: replace container build with npm run build:runners - setup/index.ts: rename step container → runners - setup/environment.ts: remove Docker/Apple Container detection - setup/service.ts: remove Docker group stale check, add nodeBin and npm-global to service PATH for codex CLI - setup/verify.ts: remove container runtime check - SKILL.md: rewrite for container-free setup, add Codex auth step
This commit is contained in:
@@ -1,141 +1,55 @@
|
||||
/**
|
||||
* Step: container — Build container image and verify with test run.
|
||||
* Replaces 03-setup-container.sh
|
||||
* Step: runners — Build agent runners (no container needed).
|
||||
* Agents run as direct host processes.
|
||||
*/
|
||||
import { execSync } from 'child_process';
|
||||
import fs from 'fs';
|
||||
import path from 'path';
|
||||
|
||||
import { logger } from '../src/logger.js';
|
||||
import { commandExists } from './platform.js';
|
||||
import { emitStatus } from './status.js';
|
||||
|
||||
function parseArgs(args: string[]): { runtime: string } {
|
||||
let runtime = '';
|
||||
for (let i = 0; i < args.length; i++) {
|
||||
if (args[i] === '--runtime' && args[i + 1]) {
|
||||
runtime = args[i + 1];
|
||||
i++;
|
||||
}
|
||||
}
|
||||
return { runtime };
|
||||
}
|
||||
|
||||
export async function run(args: string[]): Promise<void> {
|
||||
export async function run(_args: string[]): Promise<void> {
|
||||
const projectRoot = process.cwd();
|
||||
const { runtime } = parseArgs(args);
|
||||
const image = 'nanoclaw-agent:latest';
|
||||
const logFile = path.join(projectRoot, 'logs', 'setup.log');
|
||||
|
||||
if (!runtime) {
|
||||
emitStatus('SETUP_CONTAINER', {
|
||||
RUNTIME: 'unknown',
|
||||
IMAGE: image,
|
||||
BUILD_OK: false,
|
||||
TEST_OK: false,
|
||||
STATUS: 'failed',
|
||||
ERROR: 'missing_runtime_flag',
|
||||
LOG: 'logs/setup.log',
|
||||
});
|
||||
process.exit(4);
|
||||
}
|
||||
|
||||
// Validate runtime availability
|
||||
if (runtime === 'apple-container' && !commandExists('container')) {
|
||||
emitStatus('SETUP_CONTAINER', {
|
||||
RUNTIME: runtime,
|
||||
IMAGE: image,
|
||||
BUILD_OK: false,
|
||||
TEST_OK: false,
|
||||
STATUS: 'failed',
|
||||
ERROR: 'runtime_not_available',
|
||||
LOG: 'logs/setup.log',
|
||||
});
|
||||
process.exit(2);
|
||||
}
|
||||
|
||||
if (runtime === 'docker') {
|
||||
if (!commandExists('docker')) {
|
||||
emitStatus('SETUP_CONTAINER', {
|
||||
RUNTIME: runtime,
|
||||
IMAGE: image,
|
||||
BUILD_OK: false,
|
||||
TEST_OK: false,
|
||||
STATUS: 'failed',
|
||||
ERROR: 'runtime_not_available',
|
||||
LOG: 'logs/setup.log',
|
||||
});
|
||||
process.exit(2);
|
||||
}
|
||||
try {
|
||||
execSync('docker info', { stdio: 'ignore' });
|
||||
} catch {
|
||||
emitStatus('SETUP_CONTAINER', {
|
||||
RUNTIME: runtime,
|
||||
IMAGE: image,
|
||||
BUILD_OK: false,
|
||||
TEST_OK: false,
|
||||
STATUS: 'failed',
|
||||
ERROR: 'runtime_not_available',
|
||||
LOG: 'logs/setup.log',
|
||||
});
|
||||
process.exit(2);
|
||||
}
|
||||
}
|
||||
|
||||
if (!['apple-container', 'docker'].includes(runtime)) {
|
||||
emitStatus('SETUP_CONTAINER', {
|
||||
RUNTIME: runtime,
|
||||
IMAGE: image,
|
||||
BUILD_OK: false,
|
||||
TEST_OK: false,
|
||||
STATUS: 'failed',
|
||||
ERROR: 'unknown_runtime',
|
||||
LOG: 'logs/setup.log',
|
||||
});
|
||||
process.exit(4);
|
||||
}
|
||||
|
||||
const buildCmd =
|
||||
runtime === 'apple-container' ? 'container build' : 'docker build';
|
||||
const runCmd = runtime === 'apple-container' ? 'container' : 'docker';
|
||||
|
||||
// Build
|
||||
// Build agent runners
|
||||
let buildOk = false;
|
||||
logger.info({ runtime }, 'Building container');
|
||||
logger.info('Building agent runners');
|
||||
try {
|
||||
execSync(`${buildCmd} -t ${image} .`, {
|
||||
cwd: path.join(projectRoot, 'container'),
|
||||
execSync('npm run build:runners', {
|
||||
cwd: projectRoot,
|
||||
stdio: ['ignore', 'pipe', 'pipe'],
|
||||
});
|
||||
buildOk = true;
|
||||
logger.info('Container build succeeded');
|
||||
logger.info('Agent runners build succeeded');
|
||||
} catch (err) {
|
||||
logger.error({ err }, 'Container build failed');
|
||||
logger.error({ err }, 'Agent runners build failed');
|
||||
}
|
||||
|
||||
// Test
|
||||
let testOk = false;
|
||||
if (buildOk) {
|
||||
logger.info('Testing container');
|
||||
try {
|
||||
const output = execSync(
|
||||
`echo '{}' | ${runCmd} run -i --rm --entrypoint /bin/echo ${image} "Container OK"`,
|
||||
{ encoding: 'utf-8', stdio: ['pipe', 'pipe', 'pipe'] },
|
||||
);
|
||||
testOk = output.includes('Container OK');
|
||||
logger.info({ testOk }, 'Container test result');
|
||||
} catch {
|
||||
logger.error('Container test failed');
|
||||
}
|
||||
}
|
||||
// Verify runner entry points exist
|
||||
const agentRunner = path.join(
|
||||
projectRoot,
|
||||
'container',
|
||||
'agent-runner',
|
||||
'dist',
|
||||
'index.js',
|
||||
);
|
||||
const codexRunner = path.join(
|
||||
projectRoot,
|
||||
'container',
|
||||
'codex-runner',
|
||||
'dist',
|
||||
'index.js',
|
||||
);
|
||||
const agentRunnerOk = fs.existsSync(agentRunner);
|
||||
const codexRunnerOk = fs.existsSync(codexRunner);
|
||||
|
||||
const status = buildOk && testOk ? 'success' : 'failed';
|
||||
const status = buildOk && agentRunnerOk ? 'success' : 'failed';
|
||||
|
||||
emitStatus('SETUP_CONTAINER', {
|
||||
RUNTIME: runtime,
|
||||
IMAGE: image,
|
||||
emitStatus('SETUP_RUNNERS', {
|
||||
BUILD_OK: buildOk,
|
||||
TEST_OK: testOk,
|
||||
AGENT_RUNNER: agentRunnerOk,
|
||||
CODEX_RUNNER: codexRunnerOk,
|
||||
STATUS: status,
|
||||
LOG: 'logs/setup.log',
|
||||
});
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
/**
|
||||
* Step: environment — Detect OS, Node, container runtimes, existing config.
|
||||
* Step: environment — Detect OS, Node, existing config.
|
||||
* Replaces 01-check-environment.sh
|
||||
*/
|
||||
import fs from 'fs';
|
||||
@@ -9,7 +9,7 @@ import Database from 'better-sqlite3';
|
||||
|
||||
import { STORE_DIR } from '../src/config.js';
|
||||
import { logger } from '../src/logger.js';
|
||||
import { commandExists, getPlatform, isHeadless, isWSL } from './platform.js';
|
||||
import { getPlatform, isHeadless, isWSL } from './platform.js';
|
||||
import { emitStatus } from './status.js';
|
||||
|
||||
export async function run(_args: string[]): Promise<void> {
|
||||
@@ -21,24 +21,6 @@ export async function run(_args: string[]): Promise<void> {
|
||||
const wsl = isWSL();
|
||||
const headless = isHeadless();
|
||||
|
||||
// Check Apple Container
|
||||
let appleContainer: 'installed' | 'not_found' = 'not_found';
|
||||
if (commandExists('container')) {
|
||||
appleContainer = 'installed';
|
||||
}
|
||||
|
||||
// Check Docker
|
||||
let docker: 'running' | 'installed_not_running' | 'not_found' = 'not_found';
|
||||
if (commandExists('docker')) {
|
||||
try {
|
||||
const { execSync } = await import('child_process');
|
||||
execSync('docker info', { stdio: 'ignore' });
|
||||
docker = 'running';
|
||||
} catch {
|
||||
docker = 'installed_not_running';
|
||||
}
|
||||
}
|
||||
|
||||
// Check existing config
|
||||
const hasEnv = fs.existsSync(path.join(projectRoot, '.env'));
|
||||
|
||||
@@ -70,8 +52,6 @@ export async function run(_args: string[]): Promise<void> {
|
||||
{
|
||||
platform,
|
||||
wsl,
|
||||
appleContainer,
|
||||
docker,
|
||||
hasEnv,
|
||||
hasAuth,
|
||||
hasRegisteredGroups,
|
||||
@@ -83,8 +63,6 @@ export async function run(_args: string[]): Promise<void> {
|
||||
PLATFORM: platform,
|
||||
IS_WSL: wsl,
|
||||
IS_HEADLESS: headless,
|
||||
APPLE_CONTAINER: appleContainer,
|
||||
DOCKER: docker,
|
||||
HAS_ENV: hasEnv,
|
||||
HAS_AUTH: hasAuth,
|
||||
HAS_REGISTERED_GROUPS: hasRegisteredGroups,
|
||||
|
||||
@@ -10,7 +10,7 @@ const STEPS: Record<
|
||||
() => Promise<{ run: (args: string[]) => Promise<void> }>
|
||||
> = {
|
||||
environment: () => import('./environment.js'),
|
||||
container: () => import('./container.js'),
|
||||
runners: () => import('./container.js'),
|
||||
groups: () => import('./groups.js'),
|
||||
register: () => import('./register.js'),
|
||||
mounts: () => import('./mounts.js'),
|
||||
|
||||
@@ -101,7 +101,7 @@ function setupLaunchd(
|
||||
<key>EnvironmentVariables</key>
|
||||
<dict>
|
||||
<key>PATH</key>
|
||||
<string>/usr/local/bin:/usr/bin:/bin:${homeDir}/.local/bin</string>
|
||||
<string>${path.dirname(nodePath)}:/usr/local/bin:/usr/bin:/bin:${homeDir}/.local/bin:${homeDir}/.npm-global/bin</string>
|
||||
<key>HOME</key>
|
||||
<string>${homeDir}</string>
|
||||
</dict>
|
||||
@@ -174,33 +174,6 @@ function killOrphanedProcesses(projectRoot: string): void {
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Detect stale docker group membership in the user systemd session.
|
||||
*
|
||||
* When a user is added to the docker group mid-session, the user systemd
|
||||
* daemon (user@UID.service) keeps the old group list from login time.
|
||||
* Docker works in the terminal but not in the service context.
|
||||
*
|
||||
* Only relevant on Linux with user-level systemd (not root, not macOS, not WSL nohup).
|
||||
*/
|
||||
function checkDockerGroupStale(): boolean {
|
||||
try {
|
||||
execSync('systemd-run --user --pipe --wait docker info', {
|
||||
stdio: 'pipe',
|
||||
timeout: 10000,
|
||||
});
|
||||
return false; // Docker works from systemd session
|
||||
} catch {
|
||||
// Check if docker works from the current shell (to distinguish stale group vs broken docker)
|
||||
try {
|
||||
execSync('docker info', { stdio: 'pipe', timeout: 5000 });
|
||||
return true; // Works in shell but not systemd session → stale group
|
||||
} catch {
|
||||
return false; // Docker itself is not working, different issue
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
function setupSystemd(
|
||||
projectRoot: string,
|
||||
nodePath: string,
|
||||
@@ -244,7 +217,7 @@ WorkingDirectory=${projectRoot}
|
||||
Restart=always
|
||||
RestartSec=5
|
||||
Environment=HOME=${homeDir}
|
||||
Environment=PATH=/usr/local/bin:/usr/bin:/bin:${homeDir}/.local/bin
|
||||
Environment=PATH=${path.dirname(nodePath)}:/usr/local/bin:/usr/bin:/bin:${homeDir}/.local/bin:${homeDir}/.npm-global/bin
|
||||
StandardOutput=append:${projectRoot}/logs/nanoclaw.log
|
||||
StandardError=append:${projectRoot}/logs/nanoclaw.error.log
|
||||
|
||||
@@ -254,14 +227,6 @@ WantedBy=${runningAsRoot ? 'multi-user.target' : 'default.target'}`;
|
||||
fs.writeFileSync(unitPath, unit);
|
||||
logger.info({ unitPath }, 'Wrote systemd unit');
|
||||
|
||||
// Detect stale docker group before starting (user systemd only)
|
||||
const dockerGroupStale = !runningAsRoot && checkDockerGroupStale();
|
||||
if (dockerGroupStale) {
|
||||
logger.warn(
|
||||
'Docker group not active in systemd session — user was likely added to docker group mid-session',
|
||||
);
|
||||
}
|
||||
|
||||
// Kill orphaned nanoclaw processes to avoid channel connection conflicts
|
||||
killOrphanedProcesses(projectRoot);
|
||||
|
||||
@@ -299,7 +264,6 @@ WantedBy=${runningAsRoot ? 'multi-user.target' : 'default.target'}`;
|
||||
PROJECT_PATH: projectRoot,
|
||||
UNIT_PATH: unitPath,
|
||||
SERVICE_LOADED: serviceLoaded,
|
||||
...(dockerGroupStale ? { DOCKER_GROUP_STALE: true } : {}),
|
||||
STATUS: 'success',
|
||||
LOG: 'logs/setup.log',
|
||||
});
|
||||
|
||||
@@ -82,21 +82,7 @@ export async function run(_args: string[]): Promise<void> {
|
||||
}
|
||||
logger.info({ service }, 'Service status');
|
||||
|
||||
// 2. Check container runtime
|
||||
let containerRuntime = 'none';
|
||||
try {
|
||||
execSync('command -v container', { stdio: 'ignore' });
|
||||
containerRuntime = 'apple-container';
|
||||
} catch {
|
||||
try {
|
||||
execSync('docker info', { stdio: 'ignore' });
|
||||
containerRuntime = 'docker';
|
||||
} catch {
|
||||
// No runtime
|
||||
}
|
||||
}
|
||||
|
||||
// 3. Check credentials
|
||||
// 2. Check credentials
|
||||
let credentials = 'missing';
|
||||
const envFile = path.join(projectRoot, '.env');
|
||||
if (fs.existsSync(envFile)) {
|
||||
@@ -106,7 +92,7 @@ export async function run(_args: string[]): Promise<void> {
|
||||
}
|
||||
}
|
||||
|
||||
// 4. Check channel auth (detect configured channels by credentials)
|
||||
// 3. Check channel auth (detect configured channels by credentials)
|
||||
const envVars = readEnvFile([
|
||||
'TELEGRAM_BOT_TOKEN',
|
||||
'SLACK_BOT_TOKEN',
|
||||
@@ -139,7 +125,7 @@ export async function run(_args: string[]): Promise<void> {
|
||||
const configuredChannels = Object.keys(channelAuth);
|
||||
const anyChannelConfigured = configuredChannels.length > 0;
|
||||
|
||||
// 5. Check registered groups (using better-sqlite3, not sqlite3 CLI)
|
||||
// 4. Check registered groups (using better-sqlite3, not sqlite3 CLI)
|
||||
let registeredGroups = 0;
|
||||
const dbPath = path.join(STORE_DIR, 'messages.db');
|
||||
if (fs.existsSync(dbPath)) {
|
||||
@@ -155,7 +141,7 @@ export async function run(_args: string[]): Promise<void> {
|
||||
}
|
||||
}
|
||||
|
||||
// 6. Check mount allowlist
|
||||
// 5. Check mount allowlist
|
||||
let mountAllowlist = 'missing';
|
||||
if (
|
||||
fs.existsSync(
|
||||
@@ -178,7 +164,6 @@ export async function run(_args: string[]): Promise<void> {
|
||||
|
||||
emitStatus('VERIFY', {
|
||||
SERVICE: service,
|
||||
CONTAINER_RUNTIME: containerRuntime,
|
||||
CREDENTIALS: credentials,
|
||||
CONFIGURED_CHANNELS: configuredChannels.join(','),
|
||||
CHANNEL_AUTH: JSON.stringify(channelAuth),
|
||||
|
||||
Reference in New Issue
Block a user