claude-bot/EJClaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(rooms): default new rooms to tribunal when room_mode is omitted

Browse Source 
assign_room (MCP tool + host-side assignRoomInDatabase) and setup
register previously fell back to 'single' when no room_mode was given,
so newly added rooms silently lost the reviewer. Default to 'tribunal'
across the MCP zod schema, the IPC arg fallback, and the DB helper, and
update the ipc-auth expectation accordingly.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Codex
2026-06-19 00:00:20 +09:00
parent 822ac34c0e
commit f9b1e74838
3 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
runners/agent-runner/src/ipc-mcp-stdio.ts
View File

@@ -765,8 +765,10 @@ If folder is omitted, the host generates one automatically.`,
name: z.string().describe('Display name for the room'),
room_mode: z
.enum(['single', 'tribunal'])
.default('single')
.describe('single=owner only, tribunal=owner/reviewer roles enabled'),
.default('tribunal')
.describe(
'single=owner only, tribunal=owner/reviewer roles enabled (default)',
),
owner_agent_type: z
.enum(['claude-code', 'codex'])
.optional()
@@ -831,7 +833,7 @@ If folder is omitted, the host generates one automatically.`,
type: 'assign_room',
jid: args.jid,
name: args.name,
room_mode: args.room_mode || 'single',
room_mode: args.room_mode || 'tribunal',
owner_agent_type: args.owner_agent_type,
reviewer_agent_type: args.reviewer_agent_type,
arbiter_agent_type: args.arbiter_agent_type,

2
src/db/rooms.ts
View File

@@ -194,7 +194,7 @@ export function assignRoomInDatabase(
input: AssignRoomInput,
): (RegisteredGroup & { jid: string }) | undefined {
const existing = getStoredRoomSettingsRowFromDatabase(database, chatJid);
const roomMode = input.roomMode || existing?.roomMode || 'single';
const roomMode = input.roomMode || existing?.roomMode || 'tribunal';
const ownerAgentType =
input.ownerAgentType || existing?.ownerAgentType || OWNER_AGENT_TYPE;
const folder = resolveAssignedRoomFolder(

4
src/ipc-auth.test.ts
View File

@@ -1131,7 +1131,7 @@ describe('assign_room success', () => {
});
});
it('assign_room auto-fills missing folder for single rooms without exposing trigger metadata', async () => {
it('assign_room auto-fills missing folder and defaults to tribunal without exposing trigger metadata', async () => {
await processTaskIpc(
{
type: 'assign_room',
@@ -1146,7 +1146,7 @@ describe('assign_room success', () => {
const group = getRegisteredGroup('partial@g.us');
expect(group).toBeDefined();
expect(group!.folder).toMatch(/^grp_whatsapp_/);
expect(getStoredRoomSettings('partial@g.us')?.roomMode).toBe('single');
expect(getStoredRoomSettings('partial@g.us')?.roomMode).toBe('tribunal');
});
it('assign_room preserves an existing tribunal room mode when room_mode is omitted', async () => {