114 lines
3.3 KiB
TypeScript
114 lines
3.3 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
|
|
import {
|
|
parseVisibleVerdict,
|
|
resolveOwnerCompletionSignal,
|
|
resolveReviewerCompletionSignal,
|
|
resolveReviewerFailureSignal,
|
|
} from './paired-execution-context-shared.js';
|
|
|
|
describe('paired execution context shared verdict helpers', () => {
|
|
it('parses visible verdicts from the first summary line only', () => {
|
|
expect(
|
|
parseVisibleVerdict(
|
|
'DONE_WITH_CONCERNS\n\nfollow-up detail that should not affect parsing',
|
|
),
|
|
).toBe('done_with_concerns');
|
|
expect(parseVisibleVerdict('BLOCKED\nextra detail')).toBe('blocked');
|
|
expect(parseVisibleVerdict('random prose')).toBe('continue');
|
|
});
|
|
|
|
it('maps normal owner completion verdicts to reviewer or arbiter signals', () => {
|
|
expect(
|
|
resolveOwnerCompletionSignal({
|
|
phase: 'normal',
|
|
visibleVerdict: 'done',
|
|
}),
|
|
).toEqual({
|
|
kind: 'request_reviewer',
|
|
resetStatusToActive: false,
|
|
});
|
|
expect(
|
|
resolveOwnerCompletionSignal({
|
|
phase: 'normal',
|
|
visibleVerdict: 'blocked',
|
|
}),
|
|
).toEqual({ kind: 'request_arbiter' });
|
|
});
|
|
|
|
it('maps finalize owner outcomes to complete, re-review, or arbiter', () => {
|
|
expect(
|
|
resolveOwnerCompletionSignal({
|
|
phase: 'finalize',
|
|
visibleVerdict: 'done',
|
|
hasChangesSinceApproval: false,
|
|
roundTripCount: 0,
|
|
deadlockThreshold: 2,
|
|
}),
|
|
).toEqual({ kind: 'complete', completionReason: 'done' });
|
|
expect(
|
|
resolveOwnerCompletionSignal({
|
|
phase: 'finalize',
|
|
visibleVerdict: 'done_with_concerns',
|
|
hasChangesSinceApproval: false,
|
|
roundTripCount: 1,
|
|
deadlockThreshold: 3,
|
|
}),
|
|
).toEqual({
|
|
kind: 'request_reviewer',
|
|
resetStatusToActive: true,
|
|
});
|
|
expect(
|
|
resolveOwnerCompletionSignal({
|
|
phase: 'finalize',
|
|
visibleVerdict: 'done',
|
|
hasChangesSinceApproval: true,
|
|
roundTripCount: 3,
|
|
deadlockThreshold: 3,
|
|
}),
|
|
).toEqual({ kind: 'request_arbiter' });
|
|
});
|
|
|
|
it('maps reviewer completion verdicts to finalize, owner changes, or arbiter', () => {
|
|
expect(
|
|
resolveReviewerCompletionSignal({
|
|
visibleVerdict: 'done',
|
|
roundTripCount: 0,
|
|
deadlockThreshold: 3,
|
|
}),
|
|
).toEqual({ kind: 'request_owner_finalize' });
|
|
expect(
|
|
resolveReviewerCompletionSignal({
|
|
visibleVerdict: 'continue',
|
|
roundTripCount: 1,
|
|
deadlockThreshold: 3,
|
|
}),
|
|
).toEqual({ kind: 'request_owner_changes' });
|
|
expect(
|
|
resolveReviewerCompletionSignal({
|
|
visibleVerdict: 'done_with_concerns',
|
|
roundTripCount: 3,
|
|
deadlockThreshold: 3,
|
|
}),
|
|
).toEqual({ kind: 'request_arbiter' });
|
|
});
|
|
|
|
it('maps reviewer failure verdicts to explicit failure signals', () => {
|
|
expect(
|
|
resolveReviewerFailureSignal({
|
|
visibleVerdict: 'done',
|
|
}),
|
|
).toEqual({ kind: 'request_owner_finalize' });
|
|
expect(
|
|
resolveReviewerFailureSignal({
|
|
visibleVerdict: 'needs_context',
|
|
}),
|
|
).toEqual({ kind: 'complete', completionReason: 'escalated' });
|
|
expect(
|
|
resolveReviewerFailureSignal({
|
|
visibleVerdict: 'continue',
|
|
}),
|
|
).toEqual({ kind: 'preserve_review_ready' });
|
|
});
|
|
});
|