Files
EJClaw/setup/register.test.ts
Codex 712664ca00 Fix owner context loss after finalize; green the test suite
Owner continuity:
- Seed a freshly created owner task with the previous task's latest owner
  final on a cold start after the previous task already closed, so a user
  reply to a finalized TASK_DONE no longer produces a "no context" answer.
  Activated for this deployment via PAIRED_CARRY_FORWARD_LATEST_OWNER_FINAL
  (.env); carried text is injected as clearly-marked background only.
- Skip intermediate STEP_DONE outputs when picking the carry-forward anchor.

Single-mode routing:
- enforceRoomModeOnLease strips a stale reviewer/arbiter lease from a room
  switched back to single, preventing single-mode messages from stalling in
  the paired path on a stuck execution lease.

Session auth / credentials:
- Pre-sync Claude credentials into each session dir before the agent spawns.
- Honor CLAUDE_CREDENTIALS_PATH in setup/login.ts (per-service isolation).
- Add a relogin-required gate so a permanently logged-out claude-code room
  asks the user to re-login instead of spawning a doomed agent.

Other:
- Arbiter verdicts written in the user's language (verdict keyword stays EN).
- status-dashboard chatName field; runtime-inventory credential path resolver.

Tests (make suite fully green: 1595 pass / 3 skip):
- service-routing: default owner is now the claude service and reviewer is
  codex-review; update the 7 failover/default expectations accordingly.
- migrate-room-registrations: owner inferred as claude-code (configured
  OWNER_AGENT_TYPE) for a dual legacy room; reviewer becomes codex.
- register: mock paired-workspace provisioning + reload signal (registration
  now provisions a workspace and hot-reloads); assert RELOADED status.
- paired-execution-context: force a claude-code reviewer to exercise the
  Claude read-only branch regardless of the deployment default.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-08-25 18:40:14 +09:00

165 lines
4.3 KiB
TypeScript

import fs from 'fs';
import { afterEach, describe, expect, it, vi } from 'vitest';
const {
assignRoomMock,
initDatabaseMock,
emitStatusMock,
loggerInfoMock,
isValidGroupFolderMock,
} = vi.hoisted(() => ({
assignRoomMock: vi.fn(),
initDatabaseMock: vi.fn(),
emitStatusMock: vi.fn(),
loggerInfoMock: vi.fn(),
isValidGroupFolderMock: vi.fn(() => true),
}));
vi.mock('../src/config.js', () => ({
GROUPS_DIR: '/tmp/ejclaw-groups',
}));
vi.mock('../src/db.js', () => ({
assignRoom: assignRoomMock,
initDatabase: initDatabaseMock,
}));
vi.mock('../src/group-folder.js', () => ({
isValidGroupFolder: isValidGroupFolderMock,
}));
// Registration now provisions the paired workspace (which shells out to git)
// and hot-reloads the running service. Stub both so the unit test stays hermetic
// and only verifies the registration delegation, not workspace/git side effects.
vi.mock('../src/paired-workspace-manager.js', () => ({
ensurePairedWorkspaceProvisioned: vi.fn(
() => '/tmp/ejclaw-groups/test-room/owner',
),
}));
vi.mock('../src/runtime-reload-signal.js', () => ({
signalEjclawReload: vi.fn(() => false),
}));
vi.mock('../src/logger.js', () => ({
logger: {
info: loggerInfoMock,
},
}));
vi.mock('./status.js', () => ({
emitStatus: emitStatusMock,
}));
import { run } from './register.js';
describe('register step', () => {
afterEach(() => {
assignRoomMock.mockReset();
initDatabaseMock.mockReset();
emitStatusMock.mockReset();
loggerInfoMock.mockReset();
isValidGroupFolderMock.mockReset();
isValidGroupFolderMock.mockReturnValue(true);
vi.restoreAllMocks();
});
it('delegates room assignment to the canonical service without editing env or prompts', async () => {
const mkdirSpy = vi
.spyOn(fs, 'mkdirSync')
.mockImplementation(() => undefined);
const readSpy = vi.spyOn(fs, 'readFileSync');
const writeSpy = vi.spyOn(fs, 'writeFileSync');
await run([
'--jid',
'dc:test-room',
'--name',
'Test Room',
'--folder',
'test-room',
]);
expect(initDatabaseMock).toHaveBeenCalledTimes(1);
expect(assignRoomMock).toHaveBeenCalledWith('dc:test-room', {
name: 'Test Room',
folder: 'test-room',
isMain: false,
});
expect(mkdirSpy).toHaveBeenCalledWith('/tmp/ejclaw-groups/test-room/logs', {
recursive: true,
});
expect(readSpy).not.toHaveBeenCalled();
expect(writeSpy).not.toHaveBeenCalled();
expect(emitStatusMock).toHaveBeenCalledWith('REGISTER_CHANNEL', {
JID: 'dc:test-room',
NAME: 'Test Room',
FOLDER: 'test-room',
CHANNEL: 'discord',
STATUS: 'success',
RELOADED: 'no',
LOG: 'logs/setup.log',
});
});
it('fails fast when deprecated assistant-name is passed', async () => {
const exitSpy = vi
.spyOn(process, 'exit')
.mockImplementation((code?: string | number | null | undefined) => {
throw new Error(`process.exit:${code}`);
});
await expect(
run([
'--jid',
'dc:test-room',
'--name',
'Test Room',
'--folder',
'test-room',
'--assistant-name',
'Nova',
]),
).rejects.toThrow('process.exit:4');
expect(initDatabaseMock).not.toHaveBeenCalled();
expect(assignRoomMock).not.toHaveBeenCalled();
expect(emitStatusMock).toHaveBeenCalledWith('REGISTER_CHANNEL', {
STATUS: 'failed',
ERROR: 'assistant_name_option_removed',
NEXT_STEP:
'Use a dedicated assistant identity configuration command instead',
LOG: 'logs/setup.log',
});
exitSpy.mockRestore();
});
it('never writes prompt or env files during registration', async () => {
const mkdirSpy = vi
.spyOn(fs, 'mkdirSync')
.mockImplementation(() => undefined);
const readSpy = vi.spyOn(fs, 'readFileSync');
const writeSpy = vi.spyOn(fs, 'writeFileSync');
await run([
'--jid',
'dc:main-room',
'--name',
'Main Room',
'--folder',
'main-room',
'--is-main',
]);
expect(assignRoomMock).toHaveBeenCalledWith('dc:main-room', {
name: 'Main Room',
folder: 'main-room',
isMain: true,
});
expect(mkdirSpy).toHaveBeenCalledTimes(1);
expect(readSpy).not.toHaveBeenCalled();
expect(writeSpy).not.toHaveBeenCalled();
});
});