From 59a92776136589836aa7d0ef0cdfd8e76f8971ef Mon Sep 17 00:00:00 2001 From: javis-bot Date: Wed, 18 Nov 2026 02:22:42 +0900 Subject: [PATCH] fix(weather): met.no sleet is sleet, not freezing rain MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit met.no's sleet symbols were mapped to WMO 66/67 (freezing rain), so the answer said 어는 비. They now map to the WMO 4677 rain-and-snow codes 68/69 and 83/84 (진눈깨비, 진눈깨비 소나기). Co-Authored-By: Claude Opus 5.5 --- src/jarvis/tools/builtin/weather.py | 12 +++++++++--- tests/tools/builtin/test_weather.py | 8 ++++++++ 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/src/jarvis/tools/builtin/weather.py b/src/jarvis/tools/builtin/weather.py index d488bec..555a052 100644 --- a/src/jarvis/tools/builtin/weather.py +++ b/src/jarvis/tools/builtin/weather.py @@ -161,6 +161,10 @@ WMO_CODES = { 65: "Heavy rain", 66: "Light freezing rain", 67: "Heavy freezing rain", + # 68/69 and 83/84 (rain and snow mixed, i.e. sleet) are WMO 4677 codes open-meteo does not + # send; met.no's sleet maps to them. + 68: "Slight sleet", + 69: "Sleet", 71: "Slight snow", 73: "Moderate snow", 75: "Heavy snow", @@ -168,6 +172,8 @@ WMO_CODES = { 80: "Slight rain showers", 81: "Moderate rain showers", 82: "Violent rain showers", + 83: "Slight sleet showers", + 84: "Sleet showers", 85: "Slight snow showers", 86: "Heavy snow showers", 95: "Thunderstorm", @@ -182,9 +188,9 @@ WMO_CODES_KO = { 51: "약한 이슬비", 53: "이슬비", 55: "강한 이슬비", 56: "약한 어는 이슬비", 57: "강한 어는 이슬비", 61: "약한 비", 63: "비", 65: "강한 비", - 66: "약한 어는 비", 67: "강한 어는 비", + 66: "약한 어는 비", 67: "강한 어는 비", 68: "약한 진눈깨비", 69: "진눈깨비", 71: "약한 눈", 73: "눈", 75: "강한 눈", 77: "싸락눈", - 80: "약한 소나기", 81: "소나기", 82: "강한 소나기", + 80: "약한 소나기", 81: "소나기", 82: "강한 소나기", 83: "약한 진눈깨비 소나기", 84: "진눈깨비 소나기", 85: "약한 눈소나기", 86: "강한 눈소나기", 95: "천둥번개", 96: "우박 동반 천둥번개", 99: "강한 우박 천둥번개", } @@ -209,7 +215,7 @@ def _met_no_wmo(symbol: str) -> Optional[int]: if "snow" in s: return (85, 85, 86)[level] if showers else (71, 73, 75)[level] if "sleet" in s: - return (66, 66, 67)[level] + return (83, 84, 84)[level] if showers else (68, 69, 69)[level] if "rain" in s: return (80, 81, 82)[level] if showers else (61, 63, 65)[level] return None diff --git a/tests/tools/builtin/test_weather.py b/tests/tools/builtin/test_weather.py index d563651..048d3f2 100644 --- a/tests/tools/builtin/test_weather.py +++ b/tests/tools/builtin/test_weather.py @@ -433,6 +433,14 @@ class TestWeatherTool: assert WMO_CODES_KO[80] in result.reply_text assert str(round(8.6)) in result.reply_text + @pytest.mark.parametrize("symbol", ["lightsleet", "sleet_day", "heavysleetshowers_night"]) + def test_met_no_sleet_stays_sleet_not_freezing_rain(self, symbol): + from src.jarvis.tools.builtin.weather import _met_no_wmo + code = _met_no_wmo(symbol) + assert "sleet" in WMO_CODES[code].lower() or "snow" in WMO_CODES[code].lower() + assert "freezing" not in WMO_CODES[code].lower() + assert "진눈깨비" in WMO_CODES_KO[code] + @patch('requests.get') def test_when_both_weather_services_fail_the_answer_says_so(self, mock_get): geo = Mock(status_code=200, raise_for_status=Mock())