tkrmagid/mc_chat_answer_mod
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 14 Wiki Activity

v1.3.7 — END_DATA_PACK_RELOAD 훅 추가로 /reload 직후 false negative 회피

Browse Source 
v1.3.6 에서 SERVER_STARTED + JOIN + ServerTick 셋에 presence pulse 를
달았지만 한 케이스가 남아 있었음:

데이터팩의 load.mcfunction 이 /reload 때마다 mq_chat_mod objective 를
remove/add 하고 #server 점수를 0 으로 재설정. 그런데 tick 이벤트가
죽은 호스트 + 이미 접속 중인 플레이어 조합이면 SERVER_STARTED 도
JOIN 도 발화 안 되어 reload 후 영영 다시 1 로 안 올라감 → 같은
false negative 가 reload 단위로 재발.

이번 변경:
- Fabric (1216, 2612): ServerLifecycleEvents.END_DATA_PACK_RELOAD
  등록. success=true 일 때만 markModPresence (실패한 reload 는 가드
  통과시키면 안 됨).
- NeoForge (1216): OnDatapackSyncEvent 등록. /reload 끝나면 player=null
  로 한 번 broadcast 되므로 reload 직후 presence 가 다시 찍힘.
- ChatAnswerCore.onDataPackReload 추가 (markModPresence + 진단 log).

v1.3.6 jar 는 retire — 사용자 환경이 /reload 기반 워크플로라 reload
케이스 fix 가 필수.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Claude (owner)
2026-05-19 00:22:06 +09:00
parent 48d73daaf7
commit 8540d693a0
5 changed files with 28 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
common/src/main/java/kr/tkrmagid/chatanswer/core/ChatAnswerCore.java
View File

@@ -80,6 +80,15 @@ public final class ChatAnswerCore {
markModPresence(server);
}
/** /reload 직후 호출. load.mcfunction 이 mq_chat_mod objective 를 remove/add
* 하고 `#server` 점수를 0 으로 재설정하므로, reload 끝난 직후 즉시
* 다시 1 로 찍어야 함. tick 이벤트가 죽은 호스트 + 이미 접속 중인
* 플레이어 조합에서 SERVER_STARTED/JOIN 둘 다 발화 안 되는 케이스 커버. */
public static void onDataPackReload(MinecraftServer server) {
LOG.info("[{}] onDataPackReload fired, re-marking presence", MOD_ID);
markModPresence(server);
}
/** 각 로더 entrypoint 가 매 server tick 마다 호출해야 한다. */
public static void onServerTick(MinecraftServer server) {
markModPresence(server);

5
fabric-1216/src/main/java/kr/tkrmagid/chatanswer/fabric/ChatAnswerFabric.java
View File

@@ -20,11 +20,14 @@ public final class ChatAnswerFabric implements ModInitializer {
ChatAnswerCore.handleChat(sender, message.signedContent())
);
ServerLifecycleEvents.SERVER_STARTED.register(ChatAnswerCore::onServerStarted);
ServerLifecycleEvents.END_DATA_PACK_RELOAD.register((server, resourceManager, success) -> {
if (success) ChatAnswerCore.onDataPackReload(server);
});
ServerPlayConnectionEvents.JOIN.register((handler, sender, server) ->
ChatAnswerCore.onPlayerJoin(handler.player)
);
ServerTickEvents.END_SERVER_TICK.register(ChatAnswerCore::onServerTick);
LOG.info("[{}] Fabric entrypoint registered: ALLOW_CHAT_MESSAGE + SERVER_STARTED + JOIN + TICK", ChatAnswerCore.MOD_ID);
LOG.info("[{}] Fabric entrypoint registered: ALLOW_CHAT_MESSAGE + SERVER_STARTED + END_DATA_PACK_RELOAD + JOIN + TICK", ChatAnswerCore.MOD_ID);
} catch (Throwable t) {
LOG.error("[{}] Fabric entrypoint event registration failed", ChatAnswerCore.MOD_ID, t);
throw t;

5
fabric-2612/src/main/java/kr/tkrmagid/chatanswer/fabric/ChatAnswerFabric.java
View File

@@ -20,11 +20,14 @@ public final class ChatAnswerFabric implements ModInitializer {
ChatAnswerCore.handleChat(sender, message.signedContent())
);
ServerLifecycleEvents.SERVER_STARTED.register(ChatAnswerCore::onServerStarted);
ServerLifecycleEvents.END_DATA_PACK_RELOAD.register((server, resourceManager, success) -> {
if (success) ChatAnswerCore.onDataPackReload(server);
});
ServerPlayConnectionEvents.JOIN.register((handler, sender, server) ->
ChatAnswerCore.onPlayerJoin(handler.player)
);
ServerTickEvents.END_SERVER_TICK.register(ChatAnswerCore::onServerTick);
LOG.info("[{}] Fabric entrypoint registered: ALLOW_CHAT_MESSAGE + SERVER_STARTED + JOIN + TICK", ChatAnswerCore.MOD_ID);
LOG.info("[{}] Fabric entrypoint registered: ALLOW_CHAT_MESSAGE + SERVER_STARTED + END_DATA_PACK_RELOAD + JOIN + TICK", ChatAnswerCore.MOD_ID);
} catch (Throwable t) {
LOG.error("[{}] Fabric entrypoint event registration failed", ChatAnswerCore.MOD_ID, t);
throw t;

2
gradle.properties
View File

@@ -3,7 +3,7 @@ org.gradle.parallel=true
# ───── mod metadata ─────────────────────────────────────────────────────────
mod_id=chat_answer
mod_version=1.3.6
mod_version=1.3.7
mod_group=kr.tkrmagid.chatanswer
mod_name=채팅정답

10
neoforge-1216/src/main/java/kr/tkrmagid/chatanswer/neoforge/ChatAnswerNeoForge.java
View File

@@ -6,6 +6,7 @@ import net.neoforged.bus.api.IEventBus;
import net.neoforged.bus.api.SubscribeEvent;
import net.neoforged.fml.common.Mod;
import net.neoforged.neoforge.common.NeoForge;
import net.neoforged.neoforge.event.OnDatapackSyncEvent;
import net.neoforged.neoforge.event.ServerChatEvent;
import net.neoforged.neoforge.event.entity.player.PlayerEvent;
import net.neoforged.neoforge.event.server.ServerStartedEvent;
@@ -16,6 +17,7 @@ public final class ChatAnswerNeoForge {
public ChatAnswerNeoForge(IEventBus modBus) {
NeoForge.EVENT_BUS.addListener(ChatAnswerNeoForge::onServerChat);
NeoForge.EVENT_BUS.addListener(ChatAnswerNeoForge::onServerStarted);
NeoForge.EVENT_BUS.addListener(ChatAnswerNeoForge::onDatapackSync);
NeoForge.EVENT_BUS.addListener(ChatAnswerNeoForge::onPlayerLogin);
NeoForge.EVENT_BUS.addListener(ChatAnswerNeoForge::onServerTick);
}
@@ -33,6 +35,14 @@ public final class ChatAnswerNeoForge {
ChatAnswerCore.onServerStarted(event.getServer());
}
/** OnDatapackSyncEvent: /reload 끝나면 player=null 로 한 번 broadcast,
* 로그인 때마다 해당 player 로 한 번 더 fire. 어느 쪽이든 reload 직후
* presence 가 다시 찍히는 것이 목적이라 둘 다 OK. */
@SubscribeEvent
public static void onDatapackSync(OnDatapackSyncEvent event) {
ChatAnswerCore.onDataPackReload(event.getPlayerList().getServer());
}
@SubscribeEvent
public static void onPlayerLogin(PlayerEvent.PlayerLoggedInEvent event) {
if (event.getEntity() instanceof ServerPlayer player) {