Compare commits
13 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
6abc7f9475 | ||
|
|
e2c63fde7c | ||
|
|
5722c299d3 | ||
|
|
ecd254cb78 | ||
|
|
d559c0c56a | ||
|
|
05aace294e | ||
|
|
41c7c48825 | ||
|
|
1913181d02 | ||
|
|
d11289309b | ||
|
|
de723fd0b4 | ||
|
|
e3c25fc845 | ||
|
|
2fc09deb4f | ||
|
|
6e242bb675 |
1
.gitignore
vendored
1
.gitignore
vendored
@@ -1,5 +1,6 @@
|
||||
.gradle/
|
||||
build/
|
||||
dist/
|
||||
out/
|
||||
.idea/
|
||||
.vscode/
|
||||
|
||||
@@ -5,7 +5,7 @@ org.gradle.configuration-cache=false
|
||||
|
||||
# Mod
|
||||
mod_id=video_player
|
||||
mod_version=0.4.14
|
||||
mod_version=0.4.27
|
||||
maven_group=com.ejclaw.videoplayer
|
||||
archives_base_name=video_player
|
||||
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
package com.ejclaw.videoplayer;
|
||||
|
||||
import com.ejclaw.videoplayer.block.VideoAnchorBlockEntity;
|
||||
import com.ejclaw.videoplayer.client.MusicQuizClient;
|
||||
import com.ejclaw.videoplayer.client.net.ClientNetworking;
|
||||
import com.ejclaw.videoplayer.client.playback.VideoPlayback;
|
||||
import com.ejclaw.videoplayer.client.render.VideoAnchorRenderer;
|
||||
@@ -19,6 +20,7 @@ import net.fabricmc.fabric.api.event.player.AttackBlockCallback;
|
||||
import net.minecraft.client.Minecraft;
|
||||
import net.minecraft.client.player.LocalPlayer;
|
||||
import net.minecraft.core.BlockPos;
|
||||
import net.minecraft.sounds.SoundSource;
|
||||
import net.minecraft.world.InteractionResult;
|
||||
import net.minecraft.world.phys.Vec3;
|
||||
|
||||
@@ -28,6 +30,7 @@ public class VideoPlayerClient implements ClientModInitializer {
|
||||
@Override
|
||||
public void onInitializeClient() {
|
||||
ClientNetworking.register();
|
||||
MusicQuizClient.register();
|
||||
|
||||
BlockEntityRendererRegistry.register(
|
||||
VideoPlayerBlockEntities.VIDEO_ANCHOR,
|
||||
@@ -87,17 +90,26 @@ public class VideoPlayerClient implements ClientModInitializer {
|
||||
* Distance is measured from the player's eye to the <em>panel center</em>, not the anchor
|
||||
* block corner — for a 4×4 panel the corner is ~2 blocks off from where the screen visually
|
||||
* sits, which made the audio feel like it was off to the side.
|
||||
*
|
||||
* <p>Gain is also gated by the Minecraft sound options so the in-game sliders work as
|
||||
* expected: vanilla {@code SoundEngine.calculateVolume} multiplies by master × category, so
|
||||
* we do the same with {@link SoundSource#PLAYERS} as the category. Result: dragging the
|
||||
* "Players" slider in Options → Music & Sounds attenuates video audio just like other
|
||||
* player sounds, and "Master" still gates everything.
|
||||
*/
|
||||
private static void updateDistanceGains(Minecraft client) {
|
||||
LocalPlayer p = client.player;
|
||||
if (p == null || client.level == null) return;
|
||||
Vec3 eye = p.getEyePosition();
|
||||
float masterVol = client.options.getSoundSourceVolume(SoundSource.MASTER);
|
||||
float playersVol = client.options.getSoundSourceVolume(SoundSource.PLAYERS);
|
||||
float categoryScale = masterVol * playersVol;
|
||||
for (BlockPos pos : VideoPlayback.activePositions()) {
|
||||
if (!(client.level.getBlockEntity(pos) instanceof VideoAnchorBlockEntity be)) continue;
|
||||
Vec3 center = be.panelCenter();
|
||||
double d = center.distanceTo(eye);
|
||||
float attenuation = (float) Math.max(0.0, Math.min(1.0, 1.0 - d / 16.0));
|
||||
float gain = be.isMuted() ? 0F : be.getVolume() * attenuation;
|
||||
float gain = be.isMuted() ? 0F : be.getVolume() * attenuation * categoryScale;
|
||||
VideoPlayback.setGain(pos, gain);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -50,15 +50,21 @@ public final class VideoPlayerConfig {
|
||||
private static final String FILE_NAME = "video_player.json";
|
||||
|
||||
/**
|
||||
* Default per-video download cap in MB. Sized to comfortably fit ~50 short FHD clips:
|
||||
* FHD H.264 at ~5 Mbps × 20 s ≈ 12.5 MB, so 50 × 15 MB ≈ 750 MB with headroom for
|
||||
* higher-bitrate sources.
|
||||
* Default per-video download cap in MB. Sized to allow a single 4K short clip
|
||||
* (≈25 Mbps × 60 s ≈ 190 MB, with headroom for higher-bitrate sources). Per-video
|
||||
* cap is intentionally separate from the total-cache cap below.
|
||||
*/
|
||||
private static final int DEFAULT_MAX_PRELOAD_MB = 750;
|
||||
private static final int DEFAULT_MAX_PRELOAD_MB = 2048;
|
||||
/**
|
||||
* Default total-cache cap in MB. Sized to comfortably fit ~50 short FHD clips:
|
||||
* FHD H.264 at ~5 Mbps × 20 s ≈ 12.5 MB, so 50 × 15 MB ≈ 750 MB with headroom.
|
||||
*/
|
||||
private static final int DEFAULT_MAX_CACHE_MB = 750;
|
||||
/** Default render-distance cap for video anchors, in blocks. 128 = the legacy hard-coded value. */
|
||||
private static final int DEFAULT_RENDER_DISTANCE = 128;
|
||||
|
||||
private static volatile int maxPreloadMb = DEFAULT_MAX_PRELOAD_MB;
|
||||
private static volatile int maxCacheMb = DEFAULT_MAX_CACHE_MB;
|
||||
private static volatile int renderDistanceBlocks = DEFAULT_RENDER_DISTANCE;
|
||||
private static volatile List<String> preloadUrls = Collections.emptyList();
|
||||
/** Insertion-ordered name → url. Mutated only under the class monitor. */
|
||||
@@ -73,6 +79,7 @@ public final class VideoPlayerConfig {
|
||||
VideoPlayerMod.LOG.info("[{}] created default config at {}",
|
||||
VideoPlayerMod.MOD_ID, path);
|
||||
maxPreloadMb = DEFAULT_MAX_PRELOAD_MB;
|
||||
maxCacheMb = DEFAULT_MAX_CACHE_MB;
|
||||
preloadUrls = Collections.emptyList();
|
||||
CACHE_ENTRIES.clear();
|
||||
return;
|
||||
@@ -80,21 +87,41 @@ public final class VideoPlayerConfig {
|
||||
String raw = Files.readString(path, StandardCharsets.UTF_8);
|
||||
JsonObject json = JsonParser.parseString(raw).getAsJsonObject();
|
||||
|
||||
// max_preload_mb (sanity-clamped to [16, 16384] so a typo can't brick a client)
|
||||
// Track whether any expected key was missing; if so, we rewrite the file at the
|
||||
// end so users don't have to delete their config to pick up new options.
|
||||
boolean augmented = false;
|
||||
|
||||
// max_preload_mb (per-video cap, sanity-clamped to [16, 16384])
|
||||
int cap = DEFAULT_MAX_PRELOAD_MB;
|
||||
if (json.has("max_preload_mb") && json.get("max_preload_mb").isJsonPrimitive()
|
||||
&& json.get("max_preload_mb").getAsJsonPrimitive().isNumber()) {
|
||||
cap = json.get("max_preload_mb").getAsInt();
|
||||
} else {
|
||||
augmented = true;
|
||||
}
|
||||
if (cap < 16) cap = 16;
|
||||
if (cap > 16384) cap = 16384;
|
||||
maxPreloadMb = cap;
|
||||
|
||||
// max_cache_mb (total-cache cap, sanity-clamped to [16, 65536])
|
||||
int total = DEFAULT_MAX_CACHE_MB;
|
||||
if (json.has("max_cache_mb") && json.get("max_cache_mb").isJsonPrimitive()
|
||||
&& json.get("max_cache_mb").getAsJsonPrimitive().isNumber()) {
|
||||
total = json.get("max_cache_mb").getAsInt();
|
||||
} else {
|
||||
augmented = true;
|
||||
}
|
||||
if (total < 16) total = 16;
|
||||
if (total > 65536) total = 65536;
|
||||
maxCacheMb = total;
|
||||
|
||||
// render_distance_blocks (sanity-clamped to [16, 2048])
|
||||
int rd = DEFAULT_RENDER_DISTANCE;
|
||||
if (json.has("render_distance_blocks") && json.get("render_distance_blocks").isJsonPrimitive()
|
||||
&& json.get("render_distance_blocks").getAsJsonPrimitive().isNumber()) {
|
||||
rd = json.get("render_distance_blocks").getAsInt();
|
||||
} else {
|
||||
augmented = true;
|
||||
}
|
||||
if (rd < 16) rd = 16;
|
||||
if (rd > 2048) rd = 2048;
|
||||
@@ -134,12 +161,23 @@ public final class VideoPlayerConfig {
|
||||
}
|
||||
|
||||
VideoPlayerMod.LOG.info(
|
||||
"[{}] config loaded: cap={} MB, render={} blocks, preload_urls={}, cache_entries={}",
|
||||
VideoPlayerMod.MOD_ID, maxPreloadMb, renderDistanceBlocks, urls.size(), CACHE_ENTRIES.size());
|
||||
"[{}] config loaded: per-video={} MB, total-cache={} MB, render={} blocks, "
|
||||
+ "preload_urls={}, cache_entries={}",
|
||||
VideoPlayerMod.MOD_ID, maxPreloadMb, maxCacheMb, renderDistanceBlocks,
|
||||
urls.size(), CACHE_ENTRIES.size());
|
||||
|
||||
// Auto-augment: rewrite the file once so missing keys appear after a mod update.
|
||||
if (augmented) {
|
||||
VideoPlayerMod.LOG.info(
|
||||
"[{}] config missing one or more keys — rewriting with defaults filled in",
|
||||
VideoPlayerMod.MOD_ID);
|
||||
save();
|
||||
}
|
||||
} catch (Throwable t) {
|
||||
VideoPlayerMod.LOG.warn("[{}] failed to read config {}: {} — using defaults",
|
||||
VideoPlayerMod.MOD_ID, path, t.toString());
|
||||
maxPreloadMb = DEFAULT_MAX_PRELOAD_MB;
|
||||
maxCacheMb = DEFAULT_MAX_CACHE_MB;
|
||||
renderDistanceBlocks = DEFAULT_RENDER_DISTANCE;
|
||||
preloadUrls = Collections.emptyList();
|
||||
CACHE_ENTRIES.clear();
|
||||
@@ -154,6 +192,12 @@ public final class VideoPlayerConfig {
|
||||
/** Same value in bytes. */
|
||||
public static long maxPreloadBytes() { return (long) maxPreloadMb * 1024L * 1024L; }
|
||||
|
||||
/** Hard cap on the client-side total cache directory, in MB. */
|
||||
public static int maxCacheMb() { return maxCacheMb; }
|
||||
|
||||
/** Same value in bytes. */
|
||||
public static long maxCacheBytes() { return (long) maxCacheMb * 1024L * 1024L; }
|
||||
|
||||
/** Anchor BE view-distance cap, in blocks. */
|
||||
public static int renderDistanceBlocks() { return renderDistanceBlocks; }
|
||||
|
||||
@@ -234,10 +278,12 @@ public final class VideoPlayerConfig {
|
||||
JsonObject root = new JsonObject();
|
||||
root.addProperty("_comment",
|
||||
"max_preload_mb: per-video download cap (each client). "
|
||||
+ "max_cache_mb: total cache directory cap (each client). "
|
||||
+ "render_distance_blocks: max distance at which a video anchor still renders. "
|
||||
+ "preload_urls: HTTP(S) videos auto-pushed to every player on join (no name). "
|
||||
+ "cache_entries: named entries managed by /videoCache add|list|remove.");
|
||||
root.addProperty("max_preload_mb", DEFAULT_MAX_PRELOAD_MB);
|
||||
root.addProperty("max_cache_mb", DEFAULT_MAX_CACHE_MB);
|
||||
root.addProperty("render_distance_blocks", DEFAULT_RENDER_DISTANCE);
|
||||
root.add("preload_urls", new JsonArray());
|
||||
root.add("cache_entries", new JsonArray());
|
||||
@@ -253,10 +299,12 @@ public final class VideoPlayerConfig {
|
||||
JsonObject root = new JsonObject();
|
||||
root.addProperty("_comment",
|
||||
"max_preload_mb: per-video download cap (each client). "
|
||||
+ "max_cache_mb: total cache directory cap (each client). "
|
||||
+ "render_distance_blocks: max distance at which a video anchor still renders. "
|
||||
+ "preload_urls: legacy un-named auto-preload list. "
|
||||
+ "cache_entries: managed by /videoCache add|list|remove.");
|
||||
root.addProperty("max_preload_mb", maxPreloadMb);
|
||||
root.addProperty("max_cache_mb", maxCacheMb);
|
||||
root.addProperty("render_distance_blocks", renderDistanceBlocks);
|
||||
JsonArray legacyArr = new JsonArray();
|
||||
for (String u : preloadUrls) legacyArr.add(u);
|
||||
|
||||
@@ -8,6 +8,7 @@ import com.ejclaw.videoplayer.command.VideoStickCommand;
|
||||
import com.ejclaw.videoplayer.net.CachePolicyPayload;
|
||||
import com.ejclaw.videoplayer.net.PreloadPayload;
|
||||
import com.ejclaw.videoplayer.net.VideoPlayerNetwork;
|
||||
import com.ejclaw.videoplayer.server.MusicQuizPresence;
|
||||
import com.ejclaw.videoplayer.registry.VideoPlayerBlockEntities;
|
||||
import com.ejclaw.videoplayer.registry.VideoPlayerBlocks;
|
||||
import com.ejclaw.videoplayer.registry.VideoPlayerItems;
|
||||
@@ -30,6 +31,7 @@ public class VideoPlayerMod implements ModInitializer {
|
||||
|
||||
VideoPlayerNetwork.registerPayloadTypes();
|
||||
VideoPlayerNetwork.registerServerReceivers();
|
||||
MusicQuizPresence.register();
|
||||
|
||||
VideoPlayerConfig.load();
|
||||
|
||||
@@ -50,6 +52,7 @@ public class VideoPlayerMod implements ModInitializer {
|
||||
var player = handler.getPlayer();
|
||||
ServerPlayNetworking.send(player, new CachePolicyPayload(
|
||||
VideoPlayerConfig.maxPreloadBytes(),
|
||||
VideoPlayerConfig.maxCacheBytes(),
|
||||
VideoPlayerConfig.renderDistanceBlocks()));
|
||||
|
||||
int sent = 0;
|
||||
|
||||
@@ -3,7 +3,11 @@ package com.ejclaw.videoplayer.block;
|
||||
import com.ejclaw.videoplayer.registry.VideoPlayerBlockEntities;
|
||||
import net.minecraft.core.BlockPos;
|
||||
import net.minecraft.core.Direction;
|
||||
import net.minecraft.core.HolderLookup;
|
||||
import net.minecraft.nbt.CompoundTag;
|
||||
import net.minecraft.network.protocol.Packet;
|
||||
import net.minecraft.network.protocol.game.ClientGamePacketListener;
|
||||
import net.minecraft.network.protocol.game.ClientboundBlockEntityDataPacket;
|
||||
import net.minecraft.world.level.block.entity.BlockEntity;
|
||||
import net.minecraft.world.level.block.state.BlockState;
|
||||
import net.minecraft.world.level.storage.ValueInput;
|
||||
@@ -123,6 +127,35 @@ public class VideoAnchorBlockEntity extends BlockEntity {
|
||||
out.putBoolean("autoplay", autoplay);
|
||||
}
|
||||
|
||||
/**
|
||||
* Vanilla chunk-load BE sync. The base implementation returns an empty tag, which means
|
||||
* when a client first sees this BE (chunk loads or player walks into range) it gets default
|
||||
* values — url="" in particular makes the renderer no-op and the panel appears invisible.
|
||||
*
|
||||
* <p>Returning {@link #toNbt()} here carries the custom fields in the vanilla packet, so
|
||||
* we don't depend on the {@code SyncAnchorPayload} arriving before the chunk's block-update
|
||||
* packet (there's a race: {@code level.setBlock} queues a deferred chunk broadcast while
|
||||
* {@code ServerPlayNetworking.send} writes immediately; if the payload wins, the client
|
||||
* drops it because the BE doesn't exist yet, then the chunk packet creates the BE with
|
||||
* defaults). It also fixes "player walks far away and comes back" — that path has no
|
||||
* SyncAnchorPayload at all, just vanilla chunk re-sync.
|
||||
*/
|
||||
@Override
|
||||
public CompoundTag getUpdateTag(HolderLookup.Provider provider) {
|
||||
return toNbt();
|
||||
}
|
||||
|
||||
/**
|
||||
* Triggers a {@link ClientboundBlockEntityDataPacket} whenever the chunk tracker decides
|
||||
* this BE needs to push an update. Default implementation returns {@code null} (no packet
|
||||
* sent on BE change). Combined with {@link #getUpdateTag} above, every BE-state change a
|
||||
* client sees carries the full config.
|
||||
*/
|
||||
@Override
|
||||
public Packet<ClientGamePacketListener> getUpdatePacket() {
|
||||
return ClientboundBlockEntityDataPacket.create(this);
|
||||
}
|
||||
|
||||
@Override
|
||||
protected void loadAdditional(ValueInput in) {
|
||||
super.loadAdditional(in);
|
||||
|
||||
@@ -0,0 +1,56 @@
|
||||
package com.ejclaw.videoplayer.client;
|
||||
|
||||
import com.ejclaw.videoplayer.net.MqHelloPayload;
|
||||
import net.fabricmc.api.EnvType;
|
||||
import net.fabricmc.api.Environment;
|
||||
import net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents;
|
||||
import net.fabricmc.fabric.api.client.networking.v1.ClientPlayConnectionEvents;
|
||||
import net.fabricmc.fabric.api.client.networking.v1.ClientPlayNetworking;
|
||||
|
||||
/**
|
||||
* Client side of the {@code music_quiz} datapack handshake
|
||||
* ({@code docs/mc_video_player_mod_integration.md}). Sends one {@link MqHelloPayload}
|
||||
* on JOIN, then repeats every 100 client ticks (~5 s at 20 tps).
|
||||
*
|
||||
* <p>The periodic resend is <em>mandatory</em>: the datapack's
|
||||
* {@code mq:players/login} resets the per-player score to 0 the moment the player
|
||||
* passes the spawn dialog. The single JOIN-time send can land before that reset,
|
||||
* leaving the score at 0 and breaking the {@code mq:commands/start} guard. With a
|
||||
* 5-second resend, the score is restored to 1 within at most one cycle.
|
||||
*/
|
||||
@Environment(EnvType.CLIENT)
|
||||
public final class MusicQuizClient {
|
||||
private MusicQuizClient() {}
|
||||
|
||||
/** ~5 s at 20 tps. Spec recommends ≤5 s; tighter is fine but unnecessary. */
|
||||
private static final int RESEND_INTERVAL_TICKS = 100;
|
||||
|
||||
private static int tickCounter = 0;
|
||||
|
||||
public static void register() {
|
||||
ClientPlayConnectionEvents.JOIN.register((handler, sender, client) ->
|
||||
send());
|
||||
|
||||
ClientTickEvents.END_CLIENT_TICK.register(client -> {
|
||||
// Gate on world presence — when the player isn't in-game, level is null and the
|
||||
// counter resets so the next session starts fresh instead of firing immediately.
|
||||
if (client.level == null) {
|
||||
tickCounter = 0;
|
||||
return;
|
||||
}
|
||||
tickCounter++;
|
||||
if (tickCounter >= RESEND_INTERVAL_TICKS) {
|
||||
tickCounter = 0;
|
||||
send();
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
private static void send() {
|
||||
// ClientPlayNetworking.send no-ops when the server hasn't registered the payload
|
||||
// type (e.g. vanilla server or server without this mod) — safe to call blindly.
|
||||
if (ClientPlayNetworking.canSend(MqHelloPayload.TYPE)) {
|
||||
ClientPlayNetworking.send(new MqHelloPayload(MqHelloPayload.CURRENT_VERSION));
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -6,6 +6,7 @@ import com.ejclaw.videoplayer.client.gui.VideoConfigScreen;
|
||||
import com.ejclaw.videoplayer.client.playback.VideoCache;
|
||||
import com.ejclaw.videoplayer.client.playback.VideoPlayback;
|
||||
import com.ejclaw.videoplayer.net.CachePolicyPayload;
|
||||
import com.ejclaw.videoplayer.net.ClearCachePayload;
|
||||
import com.ejclaw.videoplayer.net.DeleteCachePayload;
|
||||
import com.ejclaw.videoplayer.net.OpenScreenPayload;
|
||||
import com.ejclaw.videoplayer.net.PreloadPayload;
|
||||
@@ -44,10 +45,12 @@ public final class ClientNetworking {
|
||||
VideoCache.preload(payload.url());
|
||||
});
|
||||
|
||||
// Server tells us the per-video download cap (bytes). Must arrive before PreloadPayload
|
||||
// (the server sends policy first on JOIN), so we don't accidentally use the stale default.
|
||||
// Server tells us the per-video and total-cache download caps (bytes). Must arrive
|
||||
// before PreloadPayload (server sends policy first on JOIN) so we don't use stale
|
||||
// defaults.
|
||||
ClientPlayNetworking.registerGlobalReceiver(CachePolicyPayload.TYPE, (payload, context) -> {
|
||||
VideoCache.setMaxBytes(payload.maxBytes());
|
||||
VideoCache.setMaxBytes(payload.maxPerVideoBytes());
|
||||
VideoCache.setMaxCacheBytes(payload.maxCacheBytes());
|
||||
ClientPolicy.setRenderDistanceBlocks(payload.renderDistanceBlocks());
|
||||
});
|
||||
|
||||
@@ -55,5 +58,10 @@ public final class ClientNetworking {
|
||||
ClientPlayNetworking.registerGlobalReceiver(DeleteCachePayload.TYPE, (payload, context) -> {
|
||||
VideoCache.purge(payload.url());
|
||||
});
|
||||
|
||||
// /videoCache clear — wipe the entire client cache directory.
|
||||
ClientPlayNetworking.registerGlobalReceiver(ClearCachePayload.TYPE, (payload, context) -> {
|
||||
VideoCache.clearAll();
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
@@ -180,27 +180,24 @@ public class JavaCvBackend implements VideoBackend {
|
||||
// stale srcAddr — closing the grabber there frees the av_frame plane and the next
|
||||
// memcpy crashes inside StubRoutines::jbyte_disjoint_arraycopy (exactly the 4K-delete
|
||||
// crash dump we saw). So the safe rule is: only the decoder thread touches the
|
||||
// grabber. External stop signals `running=false`, stops the audio line, interrupts the
|
||||
// worker, and joins briefly; the worker's own `finally` calls grabber.close(). Inside
|
||||
// the loop, grab() unblocks via the rw_timeout/timeout options (3 s, set in runLoop)
|
||||
// even on a stuck HTTP read, so the join below normally returns within a frame.
|
||||
// grabber. External stop signals `running=false`, stops the audio line, interrupts
|
||||
// the worker, and returns immediately; the worker's own `finally` calls
|
||||
// grabber.close() whenever grab()/start() eventually returns.
|
||||
//
|
||||
// We deliberately do NOT join the worker. close() runs on the client tick thread (via
|
||||
// VideoPlayback.tick → Entry.close), and the worker can spend several seconds inside
|
||||
// the native FFmpeg probe at the top of runLoop — probesize=8 MB and
|
||||
// analyzeduration=2 s do not honor the `running` flag and Thread.interrupt() doesn't
|
||||
// unblock native I/O. A bounded join() there (the old 2 s) is exactly the "place then
|
||||
// immediately delete freezes the game for a moment" symptom: the worker hasn't
|
||||
// entered the grab() loop yet, so flipping running=false has no effect on it until
|
||||
// start() returns. The worker is a daemon, the audio line is already silenced above,
|
||||
// and Entry has been removed from the active map by the caller — nothing observable
|
||||
// depends on the grabber having been closed before this method returns.
|
||||
Thread t = worker;
|
||||
worker = null;
|
||||
if (t != null) {
|
||||
t.interrupt();
|
||||
try {
|
||||
t.join(2000);
|
||||
} catch (InterruptedException ie) {
|
||||
Thread.currentThread().interrupt();
|
||||
}
|
||||
if (t.isAlive()) {
|
||||
// Worker still blocked in native grab() — let it finish on its own. Its
|
||||
// finally still closes the grabber when grab() eventually returns / throws.
|
||||
// No native pointers leak in the meantime because we don't touch them here.
|
||||
VideoPlayerMod.LOG.warn(
|
||||
"[{}] decoder did not exit within 2 s of stop; orphaning until next grab() returns",
|
||||
VideoPlayerMod.MOD_ID);
|
||||
}
|
||||
}
|
||||
ready = false;
|
||||
}
|
||||
|
||||
@@ -20,6 +20,9 @@ import java.util.HashSet;
|
||||
import java.util.Map;
|
||||
import java.util.Set;
|
||||
import java.util.concurrent.ConcurrentHashMap;
|
||||
import java.util.concurrent.ExecutorService;
|
||||
import java.util.concurrent.Executors;
|
||||
import java.util.concurrent.atomic.AtomicLong;
|
||||
|
||||
/**
|
||||
* Client-side disk cache for preloaded HTTP video URLs. Driven by the {@code /videopreload}
|
||||
@@ -38,22 +41,62 @@ public final class VideoCache {
|
||||
|
||||
/** url → local absolute path of the fully-downloaded cache file. */
|
||||
private static final Map<String, Path> READY = new ConcurrentHashMap<>();
|
||||
/** urls whose download is currently in flight. */
|
||||
/** urls whose download is currently queued or in flight. */
|
||||
private static final Set<String> IN_FLIGHT = ConcurrentHashMap.newKeySet();
|
||||
/**
|
||||
* Monotonic cache-generation counter. {@link #clearAll()} bumps this; every download
|
||||
* captures the value at submit time and bails (deletes its {@code .part} without
|
||||
* publishing) if the epoch has moved since. This is the cancellation channel for the
|
||||
* in-flight download — without it, {@code clearAll} only wipes already-finalized files
|
||||
* while the running download keeps writing and re-publishes one entry post-clear.
|
||||
*/
|
||||
private static final AtomicLong CACHE_EPOCH = new AtomicLong(0);
|
||||
|
||||
/**
|
||||
* Hard ceiling on a single preload, in bytes. Default 750 MB sized to fit ~50 short FHD
|
||||
* clips; overridden per-session by {@link com.ejclaw.videoplayer.net.CachePolicyPayload}
|
||||
* Single-thread executor that serializes all downloads. Cap enforcement (the total
|
||||
* cache size check) needs an authoritative view of the cache directory at the moment a
|
||||
* download starts, so we run one download at a time — that way the directory scan in
|
||||
* {@link #cacheDirSize} reflects every finished download up to this point. Parallel
|
||||
* downloads were racing the cap by each reading the directory before any of them had
|
||||
* renamed their .part to final.
|
||||
*/
|
||||
private static final ExecutorService DOWNLOAD_POOL = Executors.newSingleThreadExecutor(r -> {
|
||||
Thread t = new Thread(r, "video_player-preload");
|
||||
t.setDaemon(true);
|
||||
return t;
|
||||
});
|
||||
|
||||
/**
|
||||
* Hard ceiling on a single preload, in bytes. Default 2 GB sized to allow a single 4K
|
||||
* short clip; overridden per-session by {@link com.ejclaw.videoplayer.net.CachePolicyPayload}
|
||||
* on join, which carries the server's {@code max_preload_mb} config value.
|
||||
*/
|
||||
private static volatile long MAX_BYTES = 750L * 1024 * 1024;
|
||||
private static volatile long MAX_BYTES = 2048L * 1024 * 1024;
|
||||
|
||||
/**
|
||||
* Hard ceiling on the total cache directory size, in bytes. Default 750 MB sized to fit
|
||||
* ~50 short FHD clips; overridden per-session by {@link com.ejclaw.videoplayer.net.CachePolicyPayload}
|
||||
* on join, which carries the server's {@code max_cache_mb} config value. Enforced
|
||||
* cooperatively at the start of each download — running cache + new download must stay
|
||||
* within this cap.
|
||||
*/
|
||||
private static volatile long MAX_CACHE_BYTES = 750L * 1024 * 1024;
|
||||
|
||||
/** Server-driven override of the per-video cap. */
|
||||
public static void setMaxBytes(long bytes) {
|
||||
if (bytes < 16L * 1024 * 1024) bytes = 16L * 1024 * 1024;
|
||||
if (bytes > 16L * 1024 * 1024 * 1024) bytes = 16L * 1024 * 1024 * 1024;
|
||||
MAX_BYTES = bytes;
|
||||
VideoPlayerMod.LOG.info("[{}] preload cap set to {} MB",
|
||||
VideoPlayerMod.LOG.info("[{}] per-video preload cap set to {} MB",
|
||||
VideoPlayerMod.MOD_ID, bytes / (1024 * 1024));
|
||||
}
|
||||
|
||||
/** Server-driven override of the total-cache cap. */
|
||||
public static void setMaxCacheBytes(long bytes) {
|
||||
if (bytes < 16L * 1024 * 1024) bytes = 16L * 1024 * 1024;
|
||||
if (bytes > 64L * 1024 * 1024 * 1024) bytes = 64L * 1024 * 1024 * 1024;
|
||||
MAX_CACHE_BYTES = bytes;
|
||||
VideoPlayerMod.LOG.info("[{}] total-cache cap set to {} MB",
|
||||
VideoPlayerMod.MOD_ID, bytes / (1024 * 1024));
|
||||
}
|
||||
|
||||
@@ -85,11 +128,73 @@ public final class VideoCache {
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Wipe the entire cache directory and drop both indexes. Sent in response to
|
||||
* {@code /videoCache clear}.
|
||||
*
|
||||
* <p>Three phases that need to stay in this order:
|
||||
* <ol>
|
||||
* <li>Bump the epoch first — that flips the cancellation flag for any in-flight
|
||||
* download. The download thread checks the epoch in the read loop and at the
|
||||
* move step, so after this point it will refuse to publish a new entry and
|
||||
* will delete its own {@code .part}.</li>
|
||||
* <li>Clear the in-memory indexes. (READY clears whatever was already finalized
|
||||
* pre-clear; IN_FLIGHT is wiped so a subsequent same-URL preload re-enters
|
||||
* the queue instead of getting deduped by stale state.)</li>
|
||||
* <li>Best-effort delete every regular file in the cache directory. We do this
|
||||
* last so that if the in-flight download was momentarily holding a {@code .part}
|
||||
* open, the listing here also catches its post-close residue (though normally
|
||||
* phase 1 → the download deletes its own part).</li>
|
||||
* </ol>
|
||||
*
|
||||
* <p>Best-effort per-file deletion; logs failures but doesn't abort on the first one.
|
||||
* On Windows the open {@code .part} may not be deletable here — phase 1's cancellation
|
||||
* + the download's own cleanup-on-bail handles that case.
|
||||
*/
|
||||
public static void clearAll() {
|
||||
// Phase 1: signal cancellation to any in-flight download BEFORE wiping disk.
|
||||
CACHE_EPOCH.incrementAndGet();
|
||||
|
||||
// Phase 2: drop indexes.
|
||||
READY.clear();
|
||||
IN_FLIGHT.clear();
|
||||
|
||||
// Phase 3: delete files on disk.
|
||||
int deleted = 0;
|
||||
int failed = 0;
|
||||
try {
|
||||
Path dir = cacheDir();
|
||||
if (dir != null && Files.isDirectory(dir)) {
|
||||
try (var stream = Files.newDirectoryStream(dir)) {
|
||||
for (Path p : stream) {
|
||||
try {
|
||||
if (Files.isRegularFile(p) && Files.deleteIfExists(p)) deleted++;
|
||||
} catch (Throwable t) {
|
||||
failed++;
|
||||
VideoPlayerMod.LOG.warn("[{}] clearAll: could not delete {}: {}",
|
||||
VideoPlayerMod.MOD_ID, p.getFileName(), t.toString());
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
} catch (Throwable t) {
|
||||
VideoPlayerMod.LOG.warn("[{}] clearAll failed: {}",
|
||||
VideoPlayerMod.MOD_ID, t.toString());
|
||||
}
|
||||
VideoPlayerMod.LOG.info("[{}] clearAll: deleted={} failed={}",
|
||||
VideoPlayerMod.MOD_ID, deleted, failed);
|
||||
notifyChat("[videocache] 전체 캐시 삭제: " + deleted + "개 파일", ChatFormatting.YELLOW);
|
||||
}
|
||||
|
||||
/** Kick off a background download. No-op if already cached or in flight. */
|
||||
public static void preload(String url) {
|
||||
if (url == null || url.isEmpty()) return;
|
||||
if (!(url.startsWith("http://") || url.startsWith("https://"))) return;
|
||||
if (READY.containsKey(url)) {
|
||||
// Use lookup() (which also verifies the file exists on disk) instead of
|
||||
// READY.containsKey — defends against READY containing a stale entry whose
|
||||
// backing file was removed by clearAll() / a user-side file delete. Without this,
|
||||
// a stale key would silently block a re-preload.
|
||||
if (lookup(url) != null) {
|
||||
VideoPlayerMod.LOG.info("[{}] preload: already cached {}", VideoPlayerMod.MOD_ID, url);
|
||||
notifyChat("[videopreload] 이미 캐시됨: " + url, ChatFormatting.GRAY);
|
||||
return;
|
||||
@@ -99,10 +204,12 @@ public final class VideoCache {
|
||||
notifyChat("[videopreload] 이미 다운로드 중: " + url, ChatFormatting.GRAY);
|
||||
return;
|
||||
}
|
||||
notifyChat("[videopreload] 다운로드 시작: " + url, ChatFormatting.YELLOW);
|
||||
Thread t = new Thread(() -> download(url), "video_player-preload");
|
||||
t.setDaemon(true);
|
||||
t.start();
|
||||
notifyChat("[videopreload] 다운로드 대기열 추가: " + url, ChatFormatting.YELLOW);
|
||||
// Capture the current epoch at submit time. The download thread checks against
|
||||
// CACHE_EPOCH later — any mismatch means clearAll() ran in between and this
|
||||
// download must abort without publishing.
|
||||
long epoch = CACHE_EPOCH.get();
|
||||
DOWNLOAD_POOL.submit(() -> download(url, epoch));
|
||||
}
|
||||
|
||||
/** Return the local cached file path for this URL, or {@code null} if not yet ready. */
|
||||
@@ -126,31 +233,86 @@ public final class VideoCache {
|
||||
|
||||
// -- internals -----------------------------------------------------------------------
|
||||
|
||||
private static void download(String url) {
|
||||
/**
|
||||
* Publish {@code path} into {@link #READY} for {@code url}, but only if the cache
|
||||
* epoch hasn't moved since {@code startEpoch} was captured. Wraps the
|
||||
* pre-check / put / post-check / rollback dance so every publish site uses the
|
||||
* same race-free pattern instead of re-implementing it.
|
||||
*
|
||||
* <p>Race coverage: if {@link #clearAll()} runs at any point between the
|
||||
* pre-check and the post-check, the post-check sees the epoch bump and we
|
||||
* roll back — {@link Map#remove(Object, Object)} is a compareAndRemove so we
|
||||
* don't clobber a legitimate concurrent put under the same key, and we delete
|
||||
* the on-disk file because clearAll's directory scan may have missed it (the
|
||||
* file may not have existed yet when clearAll ran).
|
||||
*
|
||||
* @return {@code true} if the entry is now published; {@code false} if the
|
||||
* caller's work was cancelled and {@code path} has been cleaned up.
|
||||
*/
|
||||
private static boolean publishIfNotCancelled(String url, Path path, long startEpoch) {
|
||||
if (CACHE_EPOCH.get() != startEpoch) return false;
|
||||
READY.put(url, path);
|
||||
if (CACHE_EPOCH.get() != startEpoch) {
|
||||
READY.remove(url, path);
|
||||
try { Files.deleteIfExists(path); } catch (Throwable ignored) {}
|
||||
return false;
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
private static void download(String url, long startEpoch) {
|
||||
Path cacheDir = cacheDir();
|
||||
Path partPath = null;
|
||||
try {
|
||||
if (cacheDir == null) {
|
||||
VideoPlayerMod.LOG.warn("[{}] preload: no game dir, skipping {}",
|
||||
VideoPlayerMod.MOD_ID, url);
|
||||
return;
|
||||
}
|
||||
// Pre-flight cancellation check — if clearAll already ran between submit and now,
|
||||
// skip the whole thing. Avoids creating directories / .part files post-clear.
|
||||
if (CACHE_EPOCH.get() != startEpoch) {
|
||||
VideoPlayerMod.LOG.info("[{}] preload: cancelled before start (clearAll ran) — {}",
|
||||
VideoPlayerMod.MOD_ID, url);
|
||||
return;
|
||||
}
|
||||
Files.createDirectories(cacheDir);
|
||||
|
||||
String hash = sha256(url);
|
||||
String ext = extensionFromUrl(url);
|
||||
Path finalPath = cacheDir.resolve(hash + ext);
|
||||
Path partPath = cacheDir.resolve(hash + ext + ".part");
|
||||
partPath = cacheDir.resolve(hash + ext + ".part");
|
||||
|
||||
// Resume-friendly: if the file's already on disk from an earlier session, just
|
||||
// index it without re-downloading.
|
||||
if (Files.exists(finalPath) && Files.size(finalPath) > 0) {
|
||||
READY.put(url, finalPath);
|
||||
if (!publishIfNotCancelled(url, finalPath, startEpoch)) {
|
||||
VideoPlayerMod.LOG.info("[{}] preload: reindex cancelled (clearAll ran) — {}",
|
||||
VideoPlayerMod.MOD_ID, url);
|
||||
return;
|
||||
}
|
||||
VideoPlayerMod.LOG.info("[{}] preload: indexed existing cache {} -> {}",
|
||||
VideoPlayerMod.MOD_ID, url, finalPath.getFileName());
|
||||
notifyChat("[videopreload] 기존 캐시 사용: " + url, ChatFormatting.GREEN);
|
||||
return;
|
||||
}
|
||||
|
||||
// Total-cache check: refuse to start if the cache directory is already at the cap.
|
||||
// We re-check during the read loop too, since other downloads may be in flight in
|
||||
// parallel. {@code existingCacheBytes} excludes our own .part (which we just wrote 0
|
||||
// bytes to / haven't created yet).
|
||||
long existingCacheBytes = cacheDirSize(cacheDir, partPath);
|
||||
if (existingCacheBytes >= MAX_CACHE_BYTES) {
|
||||
long capMb = MAX_CACHE_BYTES / (1024 * 1024);
|
||||
long usedMb = existingCacheBytes / (1024 * 1024);
|
||||
VideoPlayerMod.LOG.warn(
|
||||
"[{}] preload: total-cache cap reached ({}/{} MB); aborting {}",
|
||||
VideoPlayerMod.MOD_ID, usedMb, capMb, url);
|
||||
notifyChat("[videopreload] 실패 (전체 캐시 " + capMb + "MB 초과 / 현재 "
|
||||
+ usedMb + "MB): " + url, ChatFormatting.RED);
|
||||
return;
|
||||
}
|
||||
|
||||
URLConnection raw = URI.create(url).toURL().openConnection();
|
||||
raw.setConnectTimeout(10_000);
|
||||
raw.setReadTimeout(30_000);
|
||||
@@ -167,28 +329,73 @@ public final class VideoCache {
|
||||
}
|
||||
|
||||
long total = 0;
|
||||
boolean cancelled = false;
|
||||
try (InputStream in = raw.getInputStream();
|
||||
OutputStream out = Files.newOutputStream(partPath)) {
|
||||
byte[] buf = new byte[64 * 1024];
|
||||
int n;
|
||||
while ((n = in.read(buf)) >= 0) {
|
||||
// Cancellation check inside the loop. Break (not return) so the try-with
|
||||
// closes the output stream first — on Windows, deleting an open .part can
|
||||
// fail with AccessDeniedException, so we always close before deleting.
|
||||
if (CACHE_EPOCH.get() != startEpoch) {
|
||||
cancelled = true;
|
||||
break;
|
||||
}
|
||||
total += n;
|
||||
if (total > MAX_BYTES) {
|
||||
long capMb = MAX_BYTES / (1024 * 1024);
|
||||
VideoPlayerMod.LOG.warn(
|
||||
"[{}] preload: {} exceeded {} MB cap; aborting",
|
||||
"[{}] preload: {} exceeded per-video {} MB cap; aborting",
|
||||
VideoPlayerMod.MOD_ID, url, capMb);
|
||||
try { Files.deleteIfExists(partPath); } catch (Throwable ignored) {}
|
||||
notifyChat("[videopreload] 실패 (" + capMb + "MB 초과): " + url, ChatFormatting.RED);
|
||||
return;
|
||||
// Same close-before-delete dance for Windows.
|
||||
cancelled = true;
|
||||
notifyChat("[videopreload] 실패 (단일 영상 " + capMb + "MB 초과): " + url,
|
||||
ChatFormatting.RED);
|
||||
break;
|
||||
}
|
||||
if (existingCacheBytes + total > MAX_CACHE_BYTES) {
|
||||
long capMb = MAX_CACHE_BYTES / (1024 * 1024);
|
||||
long usedMb = (existingCacheBytes + total) / (1024 * 1024);
|
||||
VideoPlayerMod.LOG.warn(
|
||||
"[{}] preload: total-cache cap exceeded ({}>{} MB); aborting {}",
|
||||
VideoPlayerMod.MOD_ID, usedMb, capMb, url);
|
||||
cancelled = true;
|
||||
notifyChat("[videopreload] 실패 (전체 캐시 " + capMb + "MB 초과): " + url,
|
||||
ChatFormatting.RED);
|
||||
break;
|
||||
}
|
||||
out.write(buf, 0, n);
|
||||
}
|
||||
}
|
||||
// Now the .part file is closed — safe to delete on Windows.
|
||||
if (cancelled) {
|
||||
try { Files.deleteIfExists(partPath); } catch (Throwable ignored) {}
|
||||
return;
|
||||
}
|
||||
|
||||
// Pre-move cancellation check. If clearAll ran during the read loop, abort
|
||||
// before promoting .part to final — saves a wasted move + delete.
|
||||
if (CACHE_EPOCH.get() != startEpoch) {
|
||||
VideoPlayerMod.LOG.info("[{}] preload: cancelled before move (clearAll ran) — {}",
|
||||
VideoPlayerMod.MOD_ID, url);
|
||||
try { Files.deleteIfExists(partPath); } catch (Throwable ignored) {}
|
||||
return;
|
||||
}
|
||||
|
||||
Files.move(partPath, finalPath, StandardCopyOption.REPLACE_EXISTING,
|
||||
StandardCopyOption.ATOMIC_MOVE);
|
||||
READY.put(url, finalPath);
|
||||
|
||||
// Race-safe publish: this covers the window between Files.move and READY.put
|
||||
// (clearAll deletes the freshly-moved file then we resurrect it in READY) AND
|
||||
// the window between READY.put and the "완료" notification (clearAll wipes
|
||||
// READY then we re-publish + emit stale completion chat). publishIfNotCancelled
|
||||
// rolls back both READY and the on-disk file if the epoch moved at any time.
|
||||
if (!publishIfNotCancelled(url, finalPath, startEpoch)) {
|
||||
VideoPlayerMod.LOG.info("[{}] preload: cancelled at publish (clearAll ran) — {}",
|
||||
VideoPlayerMod.MOD_ID, url);
|
||||
return;
|
||||
}
|
||||
VideoPlayerMod.LOG.info("[{}] preload: cached {} ({} bytes) -> {}",
|
||||
VideoPlayerMod.MOD_ID, url, total, finalPath.getFileName());
|
||||
long mb = Math.max(1, total / (1024 * 1024));
|
||||
@@ -198,6 +405,10 @@ public final class VideoCache {
|
||||
VideoPlayerMod.MOD_ID, url, t.toString());
|
||||
notifyChat("[videopreload] 실패 (" + t.getClass().getSimpleName() + "): " + url,
|
||||
ChatFormatting.RED);
|
||||
// Best-effort cleanup of any leftover .part on the error path.
|
||||
if (partPath != null) {
|
||||
try { Files.deleteIfExists(partPath); } catch (Throwable ignored) {}
|
||||
}
|
||||
} finally {
|
||||
IN_FLIGHT.remove(url);
|
||||
}
|
||||
@@ -213,6 +424,32 @@ public final class VideoCache {
|
||||
});
|
||||
}
|
||||
|
||||
/**
|
||||
* Sum of regular-file sizes under {@code dir}, skipping {@code excludePart} (the .part file
|
||||
* for the in-flight download — we account for that via the running {@code total} counter).
|
||||
* Best-effort: errors collapse to 0 so a transient FS hiccup doesn't strand a download.
|
||||
*/
|
||||
private static long cacheDirSize(Path dir, Path excludePart) {
|
||||
if (dir == null) return 0L;
|
||||
try {
|
||||
if (!Files.isDirectory(dir)) return 0L;
|
||||
final long[] sum = { 0L };
|
||||
try (var stream = Files.newDirectoryStream(dir)) {
|
||||
for (Path p : stream) {
|
||||
if (excludePart != null && p.equals(excludePart)) continue;
|
||||
try {
|
||||
if (Files.isRegularFile(p)) sum[0] += Files.size(p);
|
||||
} catch (Throwable ignored) {}
|
||||
}
|
||||
}
|
||||
return sum[0];
|
||||
} catch (Throwable t) {
|
||||
VideoPlayerMod.LOG.warn("[{}] cacheDirSize failed: {}",
|
||||
VideoPlayerMod.MOD_ID, t.toString());
|
||||
return 0L;
|
||||
}
|
||||
}
|
||||
|
||||
private static Path cacheDir() {
|
||||
Minecraft mc = Minecraft.getInstance();
|
||||
if (mc == null || mc.gameDirectory == null) return null;
|
||||
|
||||
@@ -31,8 +31,19 @@ import org.joml.Matrix4f;
|
||||
@Environment(EnvType.CLIENT)
|
||||
public class VideoAnchorRenderer implements BlockEntityRenderer<VideoAnchorBlockEntity, VideoAnchorRenderer.State> {
|
||||
|
||||
/** Tiny outward offset so the quad doesn't z-fight with the wall. */
|
||||
private static final float SURFACE_EPSILON = 0.001F;
|
||||
/**
|
||||
* Outward offset so the quad doesn't z-fight with the wall it sits on.
|
||||
*
|
||||
* <p>Depth-buffer precision drops with the square of view distance: with near=0.05 and
|
||||
* 24-bit depth, the smallest resolvable step at 30 blocks is ~1mm, and ~12mm at 100
|
||||
* blocks. The old 0.001 (1mm) offset was right at the precision boundary at ~30 blocks
|
||||
* — which is exactly the distance users started seeing the wall texture flicker through
|
||||
* the video panel once {@code render_distance_blocks} was raised past the default.
|
||||
*
|
||||
* <p>2cm gives ~20× margin at 30 blocks and is still visually unnoticeable up close
|
||||
* (~3% of a block thickness).
|
||||
*/
|
||||
private static final float SURFACE_EPSILON = 0.02F;
|
||||
|
||||
public VideoAnchorRenderer(BlockEntityRendererProvider.Context ctx) {
|
||||
// no-op
|
||||
@@ -75,7 +86,12 @@ public class VideoAnchorRenderer implements BlockEntityRenderer<VideoAnchorBlock
|
||||
pose.translate(-0.5F, -0.5F, -0.5F + SURFACE_EPSILON);
|
||||
|
||||
final Matrix4f mat = new Matrix4f(pose.last().pose());
|
||||
RenderType rt = RenderTypes.entityCutout(tex);
|
||||
// entitySolid (not entityCutout): video frames come from swscale → AV_PIX_FMT_RGBA with
|
||||
// alpha hard-set to 255, so there is no alpha-tested cutout. Cutout's alpha-discard step
|
||||
// adds nothing here and makes distant sampling unstable — without mipmaps on a dynamic
|
||||
// texture, neighbouring texels can shimmer above/below the discard threshold at sub-pixel
|
||||
// sampling rates, contributing to the flicker users see once render distance is raised.
|
||||
RenderType rt = RenderTypes.entitySolid(tex);
|
||||
collector.submitCustomGeometry(pose, rt, (poseUnused, vc) -> {
|
||||
// Single-sided: the back of the anchor is by design pressed against the wall the
|
||||
// player clicked, so a back face is pure GPU waste. Halves the fragment shader work
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
package com.ejclaw.videoplayer.command;
|
||||
|
||||
import com.ejclaw.videoplayer.VideoPlayerConfig;
|
||||
import com.ejclaw.videoplayer.net.ClearCachePayload;
|
||||
import com.ejclaw.videoplayer.net.DeleteCachePayload;
|
||||
import com.ejclaw.videoplayer.net.PreloadPayload;
|
||||
import com.mojang.brigadier.CommandDispatcher;
|
||||
@@ -127,26 +128,26 @@ public final class VideoCacheCommand {
|
||||
|
||||
private static int runClear(CommandContext<CommandSourceStack> ctx) {
|
||||
CommandSourceStack src = ctx.getSource();
|
||||
// Drop server-side named entries (preload_urls is left alone — it's an admin-edited
|
||||
// list, not something /videoCache manages).
|
||||
java.util.List<String> urls = VideoPlayerConfig.clearCacheEntries();
|
||||
if (urls.isEmpty()) {
|
||||
src.sendSuccess(() -> Component.literal("[videocache] 저장된 항목이 없습니다")
|
||||
.withStyle(ChatFormatting.GRAY), false);
|
||||
return 0;
|
||||
}
|
||||
|
||||
// Always broadcast a full-cache wipe to every client, even if the named index was
|
||||
// empty — leftover files from prior sessions, legacy preload_urls downloads, and
|
||||
// any in-flight stragglers all get scrubbed in one shot.
|
||||
MinecraftServer server = src.getServer();
|
||||
ClearCachePayload payload = new ClearCachePayload();
|
||||
int clients = 0;
|
||||
for (ServerPlayer p : PlayerLookup.all(server)) {
|
||||
for (String url : urls) {
|
||||
ServerPlayNetworking.send(p, new DeleteCachePayload(url));
|
||||
}
|
||||
ServerPlayNetworking.send(p, payload);
|
||||
clients++;
|
||||
}
|
||||
final int sentFinal = clients;
|
||||
final int countFinal = urls.size();
|
||||
src.sendSuccess(() -> Component.literal(
|
||||
"[videocache] 전체 삭제: " + countFinal + "개 항목"
|
||||
+ " (" + sentFinal + " 클라이언트에 cache_delete 전송)"), false);
|
||||
return countFinal;
|
||||
"[videocache] 전체 삭제: 등록 항목 " + countFinal + "개 제거"
|
||||
+ " + " + sentFinal + " 클라이언트 디스크 캐시 전체 wipe"), false);
|
||||
return Math.max(countFinal, 1);
|
||||
}
|
||||
|
||||
private static int runRemove(CommandContext<CommandSourceStack> ctx) throws CommandSyntaxException {
|
||||
|
||||
@@ -22,10 +22,30 @@ import net.minecraft.server.level.ServerPlayer;
|
||||
import net.minecraft.server.permissions.Permissions;
|
||||
import net.minecraft.world.level.block.Block;
|
||||
|
||||
/** SPEC §4.5.1 — {@code /videoPlace <pos> <facing> <width> <height> <url>} */
|
||||
/**
|
||||
* SPEC §4.5.1 — {@code /videoPlace} has two accepted forms:
|
||||
*
|
||||
* <ul>
|
||||
* <li><b>Legacy 5-arg</b>: {@code /videoPlace <pos> <facing> <width> <height> <url>}
|
||||
* — preserved for existing command blocks. Volume defaults to 50% and muted=false.
|
||||
* The {@code url} here is a single-token string so it doesn't swallow the {@code volume}
|
||||
* slot of the new form.</li>
|
||||
* <li><b>New 6-arg</b>: {@code /videoPlace <pos> <facing> <width> <height> <volume> <url>}
|
||||
* — {@code volume} is 0..100 (percent) or {@code -1} to start muted. The percent form
|
||||
* mirrors the GUI slider; {@code -1} is a CLI shortcut so admins don't need a follow-up
|
||||
* {@code /videoMute} step. {@code url} is greedy here, so URLs containing spaces (rare
|
||||
* but possible after URL-decoding) still work.</li>
|
||||
* </ul>
|
||||
*
|
||||
* <p>Brigadier disambiguates the two by the type of the 5th argument: integer → new form,
|
||||
* non-integer token → legacy form.
|
||||
*/
|
||||
public final class VideoPlaceCommand {
|
||||
private VideoPlaceCommand() {}
|
||||
|
||||
/** Default volume (percent) applied to the legacy 5-arg form. */
|
||||
private static final int DEFAULT_VOLUME_PCT = 50;
|
||||
|
||||
public static void register(CommandDispatcher<CommandSourceStack> dispatcher) {
|
||||
dispatcher.register(build("videoPlace"));
|
||||
}
|
||||
@@ -38,12 +58,33 @@ public final class VideoPlaceCommand {
|
||||
.then(Commands.argument("facing", StringArgumentType.word())
|
||||
.then(Commands.argument("width", IntegerArgumentType.integer(1, 32))
|
||||
.then(Commands.argument("height", IntegerArgumentType.integer(1, 32))
|
||||
// New form: volume (int) + greedy url
|
||||
.then(Commands.argument("volume", IntegerArgumentType.integer(-1, 100))
|
||||
.then(Commands.argument("url", StringArgumentType.greedyString())
|
||||
.executes(VideoPlaceCommand::run))))));
|
||||
.executes(ctx -> runNew(ctx))))
|
||||
// Legacy form: single-token url, no volume slot. Single-token string
|
||||
// is intentional so "<int> https://..." cannot be parsed as a legacy
|
||||
// url that happens to start with a number — Brigadier first tries the
|
||||
// new branch and only falls through here if "volume" isn't an int.
|
||||
.then(Commands.argument("url", StringArgumentType.string())
|
||||
.executes(ctx -> runLegacy(ctx)))))));
|
||||
}
|
||||
|
||||
private static int run(com.mojang.brigadier.context.CommandContext<CommandSourceStack> ctx)
|
||||
private static int runNew(com.mojang.brigadier.context.CommandContext<CommandSourceStack> ctx)
|
||||
throws CommandSyntaxException {
|
||||
int volumeArg = IntegerArgumentType.getInteger(ctx, "volume");
|
||||
String url = StringArgumentType.getString(ctx, "url");
|
||||
return runWithValues(ctx, volumeArg, url);
|
||||
}
|
||||
|
||||
private static int runLegacy(com.mojang.brigadier.context.CommandContext<CommandSourceStack> ctx)
|
||||
throws CommandSyntaxException {
|
||||
String url = StringArgumentType.getString(ctx, "url");
|
||||
return runWithValues(ctx, DEFAULT_VOLUME_PCT, url);
|
||||
}
|
||||
|
||||
private static int runWithValues(com.mojang.brigadier.context.CommandContext<CommandSourceStack> ctx,
|
||||
int volumeArg, String rawUrl) throws CommandSyntaxException {
|
||||
CommandSourceStack src = ctx.getSource();
|
||||
ServerLevel level = src.getLevel();
|
||||
BlockPos pos = BlockPosArgument.getLoadedBlockPos(ctx, "pos");
|
||||
@@ -54,7 +95,12 @@ public final class VideoPlaceCommand {
|
||||
}
|
||||
int width = IntegerArgumentType.getInteger(ctx, "width");
|
||||
int height = IntegerArgumentType.getInteger(ctx, "height");
|
||||
String raw = StringArgumentType.getString(ctx, "url").trim();
|
||||
// -1 is the CLI mute shortcut; the BE keeps the underlying volume so an admin can
|
||||
// /videoMute false later without re-typing a level. Anything 0..100 sets %-volume and
|
||||
// clears mute.
|
||||
boolean placeMuted = volumeArg < 0;
|
||||
float placeVolume = placeMuted ? 0.5F : (volumeArg / 100.0F);
|
||||
String raw = rawUrl == null ? "" : rawUrl.trim();
|
||||
// Accept either an http(s) URL or a /videoCache add <name> entry: resolveUrlOrName()
|
||||
// returns the canonical URL in both cases, or null when a non-URL string didn't match
|
||||
// any named entry.
|
||||
@@ -75,6 +121,8 @@ public final class VideoPlaceCommand {
|
||||
be.setWidth(width);
|
||||
be.setHeight(height);
|
||||
be.setUrl(url);
|
||||
be.setVolume(placeVolume);
|
||||
be.setMuted(placeMuted);
|
||||
|
||||
CompoundTag nbt = be.toNbt();
|
||||
for (ServerPlayer p : PlayerLookup.tracking(level, pos)) {
|
||||
|
||||
@@ -9,15 +9,18 @@ import net.minecraft.resources.Identifier;
|
||||
|
||||
/**
|
||||
* S2C — broadcasts the server-configured client-side policy bundle on join, before any
|
||||
* {@link PreloadPayload}. Currently carries: {@code maxBytes} (per-video download cap) and
|
||||
* {@code renderDistanceBlocks} (anchor BE view-distance cap).
|
||||
* {@link PreloadPayload}. Carries: {@code maxPerVideoBytes} (per-video download cap),
|
||||
* {@code maxCacheBytes} (total-cache directory cap), and {@code renderDistanceBlocks}
|
||||
* (anchor BE view-distance cap).
|
||||
*/
|
||||
public record CachePolicyPayload(long maxBytes, int renderDistanceBlocks) implements CustomPacketPayload {
|
||||
public record CachePolicyPayload(long maxPerVideoBytes, long maxCacheBytes, int renderDistanceBlocks)
|
||||
implements CustomPacketPayload {
|
||||
public static final CustomPacketPayload.Type<CachePolicyPayload> TYPE =
|
||||
new CustomPacketPayload.Type<>(Identifier.fromNamespaceAndPath(VideoPlayerMod.MOD_ID, "cache_policy"));
|
||||
|
||||
public static final StreamCodec<RegistryFriendlyByteBuf, CachePolicyPayload> CODEC = StreamCodec.composite(
|
||||
ByteBufCodecs.VAR_LONG, CachePolicyPayload::maxBytes,
|
||||
ByteBufCodecs.VAR_LONG, CachePolicyPayload::maxPerVideoBytes,
|
||||
ByteBufCodecs.VAR_LONG, CachePolicyPayload::maxCacheBytes,
|
||||
ByteBufCodecs.VAR_INT, CachePolicyPayload::renderDistanceBlocks,
|
||||
CachePolicyPayload::new
|
||||
);
|
||||
|
||||
@@ -0,0 +1,26 @@
|
||||
package com.ejclaw.videoplayer.net;
|
||||
|
||||
import com.ejclaw.videoplayer.VideoPlayerMod;
|
||||
import net.minecraft.network.RegistryFriendlyByteBuf;
|
||||
import net.minecraft.network.codec.StreamCodec;
|
||||
import net.minecraft.network.protocol.common.custom.CustomPacketPayload;
|
||||
import net.minecraft.resources.Identifier;
|
||||
|
||||
/**
|
||||
* S2C — tell every client to wipe its entire {@code video_player_cache} directory and reset
|
||||
* the in-memory READY/IN_FLIGHT index. Sent by {@code /videoCache clear}. Carries no payload —
|
||||
* the receiving client just nukes everything under the cache dir regardless of how the file
|
||||
* got there (named entry, legacy preload_url, or leftover from a prior session).
|
||||
*/
|
||||
public record ClearCachePayload() implements CustomPacketPayload {
|
||||
public static final CustomPacketPayload.Type<ClearCachePayload> TYPE =
|
||||
new CustomPacketPayload.Type<>(Identifier.fromNamespaceAndPath(VideoPlayerMod.MOD_ID, "cache_clear"));
|
||||
|
||||
public static final StreamCodec<RegistryFriendlyByteBuf, ClearCachePayload> CODEC =
|
||||
StreamCodec.unit(new ClearCachePayload());
|
||||
|
||||
@Override
|
||||
public Type<? extends CustomPacketPayload> type() {
|
||||
return TYPE;
|
||||
}
|
||||
}
|
||||
35
src/main/java/com/ejclaw/videoplayer/net/MqHelloPayload.java
Normal file
35
src/main/java/com/ejclaw/videoplayer/net/MqHelloPayload.java
Normal file
@@ -0,0 +1,35 @@
|
||||
package com.ejclaw.videoplayer.net;
|
||||
|
||||
import com.ejclaw.videoplayer.VideoPlayerMod;
|
||||
import net.minecraft.network.RegistryFriendlyByteBuf;
|
||||
import net.minecraft.network.codec.ByteBufCodecs;
|
||||
import net.minecraft.network.codec.StreamCodec;
|
||||
import net.minecraft.network.protocol.common.custom.CustomPacketPayload;
|
||||
import net.minecraft.resources.Identifier;
|
||||
|
||||
/**
|
||||
* C2S — client-presence handshake for the {@code music_quiz} datapack
|
||||
* ({@code docs/mc_video_player_mod_integration.md}). Each modded client sends one on JOIN
|
||||
* and one every ~5 s thereafter. The server side flips the player's {@code mq_video_mod}
|
||||
* scoreboard score to {@code 1}, which the datapack reads in its {@code mq:commands/start}
|
||||
* guard.
|
||||
*
|
||||
* <p>Payload body is a single int (protocol version) so future schema bumps don't require
|
||||
* a new packet id. v1 is the only version that exists today.
|
||||
*/
|
||||
public record MqHelloPayload(int version) implements CustomPacketPayload {
|
||||
public static final int CURRENT_VERSION = 1;
|
||||
|
||||
public static final CustomPacketPayload.Type<MqHelloPayload> TYPE =
|
||||
new CustomPacketPayload.Type<>(Identifier.fromNamespaceAndPath(VideoPlayerMod.MOD_ID, "mq_hello"));
|
||||
|
||||
public static final StreamCodec<RegistryFriendlyByteBuf, MqHelloPayload> CODEC = StreamCodec.composite(
|
||||
ByteBufCodecs.VAR_INT, MqHelloPayload::version,
|
||||
MqHelloPayload::new
|
||||
);
|
||||
|
||||
@Override
|
||||
public Type<? extends CustomPacketPayload> type() {
|
||||
return TYPE;
|
||||
}
|
||||
}
|
||||
@@ -28,9 +28,11 @@ public final class VideoPlayerNetwork {
|
||||
PayloadTypeRegistry.clientboundPlay().register(PreloadPayload.TYPE, PreloadPayload.CODEC);
|
||||
PayloadTypeRegistry.clientboundPlay().register(CachePolicyPayload.TYPE, CachePolicyPayload.CODEC);
|
||||
PayloadTypeRegistry.clientboundPlay().register(DeleteCachePayload.TYPE, DeleteCachePayload.CODEC);
|
||||
PayloadTypeRegistry.clientboundPlay().register(ClearCachePayload.TYPE, ClearCachePayload.CODEC);
|
||||
// C2S
|
||||
PayloadTypeRegistry.serverboundPlay().register(SaveConfigPayload.TYPE, SaveConfigPayload.CODEC);
|
||||
PayloadTypeRegistry.serverboundPlay().register(DeleteAnchorPayload.TYPE, DeleteAnchorPayload.CODEC);
|
||||
PayloadTypeRegistry.serverboundPlay().register(MqHelloPayload.TYPE, MqHelloPayload.CODEC);
|
||||
}
|
||||
|
||||
public static void registerServerReceivers() {
|
||||
|
||||
@@ -0,0 +1,74 @@
|
||||
package com.ejclaw.videoplayer.server;
|
||||
|
||||
import com.ejclaw.videoplayer.VideoPlayerMod;
|
||||
import com.ejclaw.videoplayer.net.MqHelloPayload;
|
||||
import net.fabricmc.fabric.api.event.lifecycle.v1.ServerTickEvents;
|
||||
import net.fabricmc.fabric.api.networking.v1.ServerPlayNetworking;
|
||||
import net.minecraft.server.MinecraftServer;
|
||||
import net.minecraft.server.level.ServerPlayer;
|
||||
import net.minecraft.world.scores.Objective;
|
||||
import net.minecraft.world.scores.ScoreHolder;
|
||||
import net.minecraft.world.scores.Scoreboard;
|
||||
|
||||
/**
|
||||
* Implements the server side of the {@code music_quiz} datapack handshake described in
|
||||
* {@code docs/mc_video_player_mod_integration.md}.
|
||||
*
|
||||
* <p>Two scoreboard writes against objective {@code mq_video_mod} (dummy):
|
||||
* <ul>
|
||||
* <li>Every server tick — {@code #server mq_video_mod = 1}. Proves the mod jar is on the
|
||||
* server side. The datapack's {@code mq:commands/start} guard checks this first.</li>
|
||||
* <li>Every received {@link MqHelloPayload} — {@code <player> mq_video_mod = 1}. Proves
|
||||
* the sending player's client has the mod installed. Per-player flag is needed
|
||||
* because rendering is client-side; the server can't tell from join state alone.</li>
|
||||
* </ul>
|
||||
*
|
||||
* <p>The objective itself ({@code scoreboard objectives add mq_video_mod dummy}) is
|
||||
* created by the datapack's {@code mq:load} function. If it isn't present yet (datapack
|
||||
* not applied, or load hasn't run), the writes are silently skipped — when the datapack
|
||||
* appears later, the next tick / next payload arrival populates it.
|
||||
*/
|
||||
public final class MusicQuizPresence {
|
||||
private MusicQuizPresence() {}
|
||||
|
||||
/** Scoreboard objective name expected by the {@code music_quiz} datapack. */
|
||||
private static final String OBJECTIVE = "mq_video_mod";
|
||||
/** Fake holder used to mark "the server has the mod" (datapack reads {@code #server}). */
|
||||
private static final String SERVER_HOLDER = "#server";
|
||||
|
||||
/** Call from {@code VideoPlayerMod.onInitialize} after payload types are registered. */
|
||||
public static void register() {
|
||||
// (a) per-tick server presence
|
||||
ServerTickEvents.END_SERVER_TICK.register(MusicQuizPresence::onServerTick);
|
||||
|
||||
// (b) per-player client presence — flipped on every received Hello
|
||||
ServerPlayNetworking.registerGlobalReceiver(MqHelloPayload.TYPE, (payload, context) -> {
|
||||
ServerPlayer player = context.player();
|
||||
MinecraftServer server = context.server();
|
||||
// hop back onto the server thread before touching the scoreboard
|
||||
server.execute(() -> markPlayerPresent(server, player));
|
||||
});
|
||||
}
|
||||
|
||||
private static void onServerTick(MinecraftServer server) {
|
||||
Scoreboard sb = server.getScoreboard();
|
||||
Objective obj = sb.getObjective(OBJECTIVE);
|
||||
// Datapack not loaded yet — silently skip. The score holder doesn't exist until
|
||||
// the objective does, and trying to write blind would just blow up.
|
||||
if (obj == null) return;
|
||||
sb.getOrCreatePlayerScore(ScoreHolder.forNameOnly(SERVER_HOLDER), obj).set(1);
|
||||
}
|
||||
|
||||
private static void markPlayerPresent(MinecraftServer server, ServerPlayer player) {
|
||||
Scoreboard sb = server.getScoreboard();
|
||||
Objective obj = sb.getObjective(OBJECTIVE);
|
||||
if (obj == null) {
|
||||
VideoPlayerMod.LOG.debug("[{}] mq hello from {} but objective '{}' not present",
|
||||
VideoPlayerMod.MOD_ID, player.getName().getString(), OBJECTIVE);
|
||||
return;
|
||||
}
|
||||
// ServerPlayer itself implements ScoreHolder, so this matches selector @s on the
|
||||
// datapack side without name-formatting quirks (uuid vs profile name).
|
||||
sb.getOrCreatePlayerScore(player, obj).set(1);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user