Commit Graph

5 Commits

Author SHA1 Message Date
EJClaw
c24cd1f9c0 voice-changer: allow installing under user-owned folders (Desktop); move admin-run parts to Program Files
The installer refused folders whose parent is user-owned (Desktop, Documents) because a user could swap
the whole install folder and get the elevated/audiodg-run parts replaced. Instead of refusing, the parts
that run with admin rights or inside audiodg now live in {commonpf}\VoiceChanger, which only admins can
change; the chosen folder keeps the app, Python, engine, models and data.

- VoiceChanger.iss: SysDir = {commonpf}\VoiceChanger holds apo\ (VoiceChangerAPO.dll), scripts\mic-apo.ps1
  and the uninstaller (UninstallFilesDir). CheckParent removed. Upgrade detection also matches the previous
  install dir from the uninstall registry (PrevAppDir) since uninstall\ is no longer inside the app folder.
  Stop the audio service when either the new or the v1.0.1-layout APO exists. Ask before installing into
  a OneDrive-synced folder.
- secure-dir.ps1: drop CheckParent; Prepare takes -Upgrade.
- mic-apo.ps1: -From <previous app folder> migrates a v1.0.1 apo\ or 21b4278 config\ backup (validated as
  before) into the Program Files apo\, removing the emptied old apo\.
- app: admin_root() finds Program Files\VoiceChanger (falls back to the app folder for the zip layout);
  hooked-mic list, mic-apo log and the reconnect button use it.

Windows 11 VM (Inno 6.7.4 build, AppVersion 1.0.2): v1.0.1 at C:\VoiceChanger -> upgrade: backup moved
byte-equal, APO re-pointed to Program Files, old apo\ scripts\mic-apo.ps1 uninstall\ gone; fresh install to
C:\Users\ci\Desktop\VoiceChanger (owner WIN-CI\ci) with full engine download: exit 0, audiodg loads
C:\Program Files\VoiceChanger\apo\VoiceChangerAPO.dll, 440 Hz APO test + Communications stream PASS;
basic-user token can rename the Desktop folder but every Program Files write/rename is ERROR_ACCESS_DENIED;
reinstall over the same folder keeps user files; uninstall restores FxProperties (only the endpoint
timestamp properties differ, same as v1.0.1) and removes both folders.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-11 22:09:39 +09:00
EJClaw
c62bd9cf39 voice-changer: lock install folder ownership, migrate old mic backup, refresh comm modes on upgrade
- installer/secure-dir.ps1 (run elevated from tmp):
  CheckParent: refuse folders whose nearest existing parent is not a drive root or owned by
  Administrators/SYSTEM/TrustedInstaller.
  Prepare (before files are copied): owner Administrators + protected DACL (SY/BA full, Users RX),
  verify, abort setup on failure; refuse links pointing outside the folder; on upgrade delete the
  old executable parts (scripts/app/launcher/uninstall/root files) that 21b4278 left user-writable.
  Finish: Users modify only on data dirs; verify every admin-run file is admin-owned and not
  user-writable, otherwise skip APO registration and engine download.
- mic-apo.ps1: migrate config\mic-apo-backup.json to apo\ with value validation (CLSID/mode GUID/
  DWORD only, own CLSID stripped), never record our own APO as the original value, upgrade the
  DEFAULT-only mode list written by 21b4278 to DEFAULT/COMMUNICATIONS/SPEECH/MEDIA, remove the
  old config\mic-apo.json.

Windows 11 VM: user-precreated folder -> owner BA, basic-user WRITE_DAC/WRITE_OWNER/grant/icacls/
write/rename all ERROR_ACCESS_DENIED; user-owned parent refused (CheckParent exit 20);
21b4278 install -> upgrade: backup migrated, modes refreshed, Communications capture 440 Hz,
uninstall restores FxProperties to the pre-install state.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-11 19:01:36 +09:00
EJClaw
ffc553851a voice-changer: fix review findings (install-folder ACL, scoped uninstall delete, comm-mode APO, reconnect)
- installer: lock the install folder (admins/SYSTEM full, Users read) and grant Users modify only on
  data dirs (models/training/datasets/config/cache/env/engine/tools); download the engine as the
  original (non-elevated) user; refuse non-empty folders; uninstall deletes only app-managed dirs
- mic-apo.ps1: backup/list/log moved to admin-only apo\; register SFX for DEFAULT, COMMUNICATIONS,
  SPEECH and MEDIA when the endpoint has no mode list; admin TEMP for Add-Type; run log + trap
- app: '마이크 다시 연결' launches one elevated PowerShell via ShellExecuteExW(runas) with
  double-quoted -File args and waits for its exit code; shows apo\mic-apo.log on failure
- tests: reconnect argument splitting (Korean/space/quote/drive root)

Verified on the Windows 11 VM: basic-user token gets ERROR_ACCESS_DENIED on scripts/apo/exe/
uninstall/app and write access only on data dirs; Communications-category capture receives the
converted signal (440 Hz); reconnect exits 0 from a Korean+space install path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-11 18:00:20 +09:00
EJClaw
21b4278b77 voice-changer: one-click installer, mic APO instead of virtual cable, keep all files in install folder
- apo/: VoiceChangerAPO.dll (SFX APO on the real mic, built with mingw). When the app converts,
  the mic's own stream carries the converted voice; otherwise it passes the real voice through.
  Shared-memory protocol in vccore.h, Python side app/mic_bridge.py
- scripts/mic-apo.ps1: register/unregister on every capture endpoint with admin value rights only
  (no ACL changes unless FxProperties is missing), originals backed up and restored
- app: mic is the conversion target (WASAPI names), no output device, '마이크 다시 연결' button,
  44.1k<->48k streaming resample, caches/temp redirected into <install>/cache
- installer/VoiceChanger.iss (Inno Setup): choose install folder, register APO, download engine
  into that folder, uninstall restores mic settings and asks before deleting models
- install.ps1: uv python --no-bin --no-registry, temp/caches inside the folder, uv cache clean
- tests: C core compiled with gcc against the Python bridge; converter pump 44.1k round trip

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-11 16:33:15 +09:00
EJClaw
b0460fdff7 Add Windows realtime voice changer (RVC via Applio) + set operator to 사금향
- voice-changer/: install.bat (uv + Python 3.12 + pinned Applio + torch cu128),
  VoiceChanger.exe launcher (mingw), tkinter GUI (model list, auto ±12 pitch
  across genders, mic/output/monitor devices, latency, noise gate),
  train.bat (preprocess/extract/train/index → models/<id>), examples.bat
  (Korean example models from KSS + Zeroth-Korean), build-release.sh
- consent-recorder: default OPERATOR_NAME=사금향

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-11 14:34:03 +09:00