claude-bot/EJClaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: strip <internal> tags before verdict detection, add Approved/LGTM as done markers

Browse Source
This commit is contained in:
Eyejoker
2026-03-29 21:34:08 +09:00
parent b33cf6c058
commit 33baf2970d
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/paired-execution-context.ts
View File

@@ -43,14 +43,18 @@ function classifyReviewerVerdict(
summary: string | null | undefined,
): ReviewerVerdict {
if (!summary) return 'continue';
const firstLine = summary.trimStart().split('\n')[0].trim();
// Match only at the START of the first line to avoid false positives
// from quoted/referenced status markers in the body text.
if (/^\*{0,2}BLOCKED\*{0,2}\b/.test(firstLine)) return 'blocked';
if (/^\*{0,2}NEEDS_CONTEXT\*{0,2}\b/.test(firstLine)) return 'needs_context';
if (/^\*{0,2}DONE_WITH_CONCERNS\*{0,2}\b/.test(firstLine))
// Strip <internal>...</internal> tags — these are internal reasoning, not the verdict
const cleaned = summary.replace(/<internal>[\s\S]*?<\/internal>/g, '').trim();
if (!cleaned) return 'continue';
const firstLine = cleaned.split('\n')[0].trim();
// Match verdict markers at the start of the first visible line
if (/^\*{0,2}BLOCKED\*{0,2}\b/i.test(firstLine)) return 'blocked';
if (/^\*{0,2}NEEDS_CONTEXT\*{0,2}\b/i.test(firstLine)) return 'needs_context';
if (/^\*{0,2}DONE_WITH_CONCERNS\*{0,2}\b/i.test(firstLine))
return 'done_with_concerns';
if (/^\*{0,2}DONE\*{0,2}\b/.test(firstLine)) return 'done';
if (/^\*{0,2}DONE\*{0,2}\b/i.test(firstLine)) return 'done';
if (/^\*{0,2}Approved\.?\*{0,2}/i.test(firstLine)) return 'done';
if (/^\*{0,2}LGTM\*{0,2}/i.test(firstLine)) return 'done';
return 'continue';
}