claude-bot/EJClaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: route BLOCKED/NEEDS_CONTEXT through arbiter before escalating

Browse Source 
BLOCKED and NEEDS_CONTEXT verdicts went straight to completed,
bypassing the arbiter entirely. Now when arbiter is enabled, these
verdicts trigger arbiter intervention first — the arbiter may
resolve the block or decide to escalate to the user (ESCALATE).
This commit is contained in:
Eyejoker
2026-03-30 22:26:51 +09:00
parent a043f2b79a
commit 45fe80f5f5
1 changed files with 29 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
src/paired-execution-context.ts
View File

@@ -67,9 +67,16 @@ function classifyReviewerVerdict(
// Arbiter verdict detection
// ---------------------------------------------------------------------------
type ArbiterVerdictResult = 'proceed' | 'revise' | 'reset' | 'escalate' | 'unknown';
type ArbiterVerdictResult =
| 'proceed'
| 'revise'
| 'reset'
| 'escalate'
| 'unknown';
function classifyArbiterVerdict(summary: string | null | undefined): ArbiterVerdictResult {
function classifyArbiterVerdict(
summary: string | null | undefined,
): ArbiterVerdictResult {
if (!summary) return 'unknown';
const cleaned = summary.replace(/<internal>[\s\S]*?<\/internal>/g, '').trim();
if (!cleaned) return 'unknown';
@@ -522,12 +529,25 @@ export function completePairedExecutionContext(args: {
case 'blocked':
case 'needs_context':
// Needs user decision — stop ping-pong, leave task active
updatePairedTask(taskId, { status: 'completed', updated_at: now });
logger.info(
{ taskId, verdict, summary: args.summary?.slice(0, 100) },
'Reviewer escalated to user — ping-pong stopped',
);
// If arbiter is enabled, let arbiter judge before escalating to user.
// Arbiter may resolve the block (e.g. owner can fix it, info exists in context).
if (isArbiterEnabled()) {
updatePairedTask(taskId, {
status: 'arbiter_requested',
arbiter_requested_at: now,
updated_at: now,
});
logger.info(
{ taskId, verdict, summary: args.summary?.slice(0, 100) },
'Reviewer blocked/needs_context — requesting arbiter before escalating',
);
} else {
updatePairedTask(taskId, { status: 'completed', updated_at: now });
logger.info(
{ taskId, verdict, summary: args.summary?.slice(0, 100) },
'Reviewer escalated to user — ping-pong stopped',
);
}
break;
case 'done_with_concerns':
@@ -597,10 +617,7 @@ export function completePairedExecutionContext(args: {
arbiter_verdict: 'escalate',
updated_at: now,
});
logger.info(
{ taskId },
'Arbiter escalated to user — task completed',
);
logger.info({ taskId }, 'Arbiter escalated to user — task completed');
break;
default:
// Unknown verdict — treat as escalate