Fix paired turn follow-up scheduling
This commit is contained in:
@@ -130,7 +130,7 @@ describe('message-agent-executor-rules', () => {
|
|||||||
).toBe('pending');
|
).toBe('pending');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('does not request a generic follow-up after successful owner output moved the task to review_ready', () => {
|
it('requests a generic follow-up after successful owner output moved the task to review_ready', () => {
|
||||||
expect(
|
expect(
|
||||||
resolvePairedFollowUpQueueAction({
|
resolvePairedFollowUpQueueAction({
|
||||||
completedRole: 'owner',
|
completedRole: 'owner',
|
||||||
@@ -138,7 +138,7 @@ describe('message-agent-executor-rules', () => {
|
|||||||
sawOutput: true,
|
sawOutput: true,
|
||||||
taskStatus: 'review_ready',
|
taskStatus: 'review_ready',
|
||||||
}),
|
}),
|
||||||
).toBe('none');
|
).toBe('generic');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('does not request a generic follow-up after successful reviewer output moved the task back to active', () => {
|
it('does not request a generic follow-up after successful reviewer output moved the task back to active', () => {
|
||||||
|
|||||||
@@ -124,6 +124,13 @@ export function resolvePairedFollowUpQueueAction(args: {
|
|||||||
taskStatus: PairedTaskStatus | null;
|
taskStatus: PairedTaskStatus | null;
|
||||||
}): PairedFollowUpQueueAction {
|
}): PairedFollowUpQueueAction {
|
||||||
if (args.executionStatus === 'succeeded' && args.sawOutput) {
|
if (args.executionStatus === 'succeeded' && args.sawOutput) {
|
||||||
|
if (
|
||||||
|
args.completedRole === 'owner' &&
|
||||||
|
args.taskStatus === 'review_ready'
|
||||||
|
) {
|
||||||
|
return 'generic';
|
||||||
|
}
|
||||||
|
|
||||||
return args.completedRole === 'reviewer' &&
|
return args.completedRole === 'reviewer' &&
|
||||||
args.taskStatus === 'merge_ready'
|
args.taskStatus === 'merge_ready'
|
||||||
? 'skip-inline-finalize'
|
? 'skip-inline-finalize'
|
||||||
|
|||||||
@@ -1238,7 +1238,7 @@ describe('runAgentForGroup room memory', () => {
|
|||||||
expect(deps.queue.enqueueMessageCheck).not.toHaveBeenCalled();
|
expect(deps.queue.enqueueMessageCheck).not.toHaveBeenCalled();
|
||||||
});
|
});
|
||||||
|
|
||||||
it('does not enqueue a generic follow-up when owner output already moved the task to review_ready', async () => {
|
it('enqueues a generic follow-up when owner output moved the task to review_ready', async () => {
|
||||||
const group = { ...makeGroup(), folder: 'test-group' };
|
const group = { ...makeGroup(), folder: 'test-group' };
|
||||||
const deps = makeDeps();
|
const deps = makeDeps();
|
||||||
|
|
||||||
@@ -1311,7 +1311,8 @@ describe('runAgentForGroup room memory', () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
expect(result).toBe('success');
|
expect(result).toBe('success');
|
||||||
expect(deps.queue.enqueueMessageCheck).not.toHaveBeenCalled();
|
expect(deps.queue.enqueueMessageCheck).toHaveBeenCalledTimes(1);
|
||||||
|
expect(deps.queue.enqueueMessageCheck).toHaveBeenCalledWith('group@test');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('does not enqueue a generic follow-up when reviewer output already returned the task to active', async () => {
|
it('does not enqueue a generic follow-up when reviewer output already returned the task to active', async () => {
|
||||||
|
|||||||
Reference in New Issue
Block a user