feat(conversation): what is said in pieces is answered once, and a dropped answer stops the brain

Live 2026-11-19 every piece of one thought (pauses of 0.1-4.7 s) was answered on its own and the
brain wrote each cancelled answer to its end, so the replies queued up to 35 s.

- conversation: a speaker who goes on before their answer is heard (within call.continueMs,
  default 5 s) has the earlier request taken back (policy withdraw, not missed) and the joined
  text answered as one request; a stop still stops; no second earcon; partials prepare the joined
  text
- voice worker: a reply cancelled while waiting is never started, a running one stops at the
  engine's next model or tool call (turn_state.cancel), and it uses up no turn, so a confirmation
  carried by the joined request does not lapse
- specs: conversation.spec.md (Going on), voice_worker.spec.md, llm_contexts.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
javis-bot
2026-11-19 18:41:50 +09:00
parent 97b827f424
commit caad09c613
14 changed files with 449 additions and 50 deletions

View File

@@ -31,6 +31,10 @@ pub struct CallSettings {
/// After a wake word said alone, how long the speaker's next utterance may take to start and
/// still be joined to it (the pause after "Jarvis," often ends an utterance).
pub follow_up: Duration,
/// A speaker who goes on talking before Jarvis's answer to them is heard, starting within this of
/// their last utterance's end, is still asking: what they say is joined to the request
/// (`call.continueMs`; zero turns it off).
pub continue_window: Duration,
/// Play the earcon when Jarvis takes a voice call (`call.earcon`).
pub earcon: bool,
}
@@ -46,6 +50,7 @@ impl Default for CallSettings {
designated_no_wake_word: false,
stop_words: ["멈춰", "그만", "정지", "stop"].map(String::from).to_vec(),
follow_up: Duration::from_millis(1500),
continue_window: Duration::from_millis(5000),
earcon: true,
}
}

View File

@@ -167,6 +167,18 @@ pub struct Conversation<V: Voice> {
wakes: HashMap<u64, (Request, Option<Instant>)>,
/// Requests whose earcon already played (a wake word said alone was answered with it).
chimed: HashSet<u64>,
/// Each speaker's latest voice request whose answer has not been heard yet: what they say next
/// may still be part of it ("Going on").
turns: HashMap<u64, Turn>,
}
/// A voice request whose answer is not heard yet.
struct Turn {
id: u64,
text: String,
ended_at: Instant,
/// Still a "was it said to Jarvis?" question (its ask id), not yet a request of the policy.
ask: Option<String>,
}
impl<V: Voice> Conversation<V> {
@@ -185,7 +197,7 @@ impl<V: Voice> Conversation<V> {
Self { voice, calls, policy: Policy::new(policy), next_id: 0, answers: HashMap::new(),
by_speech: HashMap::new(), asks: HashMap::new(), missed: MissedLog::default(), chat: ChatCalls::default(),
chat_answers: HashMap::new(), started: HashMap::new(), wakes: HashMap::new(),
chimed: HashSet::new() }
chimed: HashSet::new(), turns: HashMap::new() }
}
/// Answer the registered chat channels too.
@@ -225,6 +237,13 @@ impl<V: Voice> Conversation<V> {
/// would be) lets the brain get ready while the speaker is still talking. Not while Jarvis is
/// answering: the call may not be taken, and the brain is busy with the answer.
fn on_partial(&mut self, speaker: u64, partial: &str) {
// Going on with a request whose answer is not heard yet: it will be joined and taken.
if let Some(t) = self.turns.get(&speaker) {
if !self.calls.continue_window.is_zero() && !matches!(self.calls.judge(speaker, partial), Call::Stop) {
self.voice.prepare(speaker, &format!("{} {}", t.text, partial));
}
return;
}
if !self.answers.is_empty() {
return;
}
@@ -277,10 +296,15 @@ impl<V: Voice> Conversation<V> {
self.started.remove(&speaker);
}
// What follows a wake word said alone is joined to it.
let (text, chimed) = match self.wakes.remove(&speaker) {
let (mut text, mut chimed) = match self.wakes.remove(&speaker) {
Some((wake, _)) => (format!("{} {}", wake.text, f.text), self.chimed.remove(&wake.id)),
None => (f.text.clone(), false),
};
// The speaker goes on before their answer was heard: still the same request.
if let Some((earlier, earcon_played)) = self.going_on(speaker, f, now) {
text = format!("{earlier} {text}");
chimed |= earcon_played;
}
self.next_id += 1;
if chimed {
self.chimed.insert(self.next_id);
@@ -316,21 +340,19 @@ impl<V: Voice> Conversation<V> {
let a = self.policy.utterance_closed(speaker, now);
self.apply(a, now);
}
Call::Request { direct } => {
let a = self.policy.request(Request { direct, ..req }, now);
self.apply(a, now);
}
Call::Request { direct } => self.voice_request(Request { direct, ..req }, now),
Call::Ask => {
let room = self.room(speaker);
if room.people <= 1 {
// Alone with Jarvis: whatever the speaker says is said to it.
debug_log!("conversation", "addressed req={} alone with jarvis", req.id);
let a = self.policy.request(req, now);
self.apply(a, now);
self.voice_request(req, now);
return;
}
let id = format!("q{}", req.id);
if self.voice.ask_addressed(&id, speaker, &text, room) {
self.turns.insert(speaker, Turn { id: req.id, text: req.text.clone(),
ended_at: req.ended_at, ask: Some(id.clone()) });
self.asks.insert(id, (req, now));
} else {
let a = self.policy.utterance_closed(speaker, now);
@@ -344,12 +366,13 @@ impl<V: Voice> Conversation<V> {
// An answer after the timeout counts as no, even before the timer ran.
let yes = *addressed && now < asked + ADDRESSED_TIMEOUT;
debug_log!("conversation", "addressed req={} yes={yes}", req.id);
let a = if yes {
self.policy.request(req, now)
self.turns.retain(|_, t| t.id != req.id);
if yes {
self.voice_request(req, now);
} else {
self.policy.utterance_closed(req.speaker, now)
};
self.apply(a, now);
let a = self.policy.utterance_closed(req.speaker, now);
self.apply(a, now);
}
}
}
CoreEvent::Ranked { id, order } => {
@@ -358,9 +381,16 @@ impl<V: Voice> Conversation<V> {
let a = self.policy.ranked(rank_id, &order, now);
self.apply(a, now);
}
// The answer is heard: what its asker says next is a new request.
CoreEvent::SpeakStart(id) => {
if let Some(pid) = self.by_speech.get(id).copied() {
self.turns.retain(|_, t| t.id != pid);
}
}
CoreEvent::SpeakEnd(e) => {
if let Some(pid) = self.by_speech.remove(&e.id) {
self.answers.remove(&pid);
self.turns.retain(|_, t| t.id != pid);
debug_log!("conversation", "answer req={pid} done played={} cancelled={} failed={}",
e.played, e.cancelled, e.failed);
let a = self.policy.answer_done(pid, now);
@@ -378,6 +408,7 @@ impl<V: Voice> Conversation<V> {
}
CoreEvent::WorkerLost => {
self.started.clear();
self.turns.clear();
for (_, (req, _)) in self.wakes.drain() {
self.chimed.remove(&req.id);
}
@@ -386,9 +417,42 @@ impl<V: Voice> Conversation<V> {
}
}
/// A voice request goes to the policy; until its answer is heard, its speaker may go on.
fn voice_request(&mut self, req: Request, now: Instant) {
self.turns.insert(req.speaker, Turn { id: req.id, text: req.text.clone(), ended_at: req.ended_at, ask: None });
let a = self.policy.request(req, now);
self.apply(a, now);
}
/// The final `f` continues the speaker's request whose answer is not heard yet (it started within
/// `call.continueMs` of that request's end, and is not a stop): the request is taken back, its
/// running answer stopped. Returns its text and whether its earcon already played.
fn going_on(&mut self, speaker: u64, f: &crate::discord::HeardFinal, now: Instant) -> Option<(String, bool)> {
let t = self.turns.get(&speaker)?;
let started = now.checked_sub(Duration::from_millis(f.wait_ms + f.audio_ms)).unwrap_or(now);
if self.calls.continue_window.is_zero() || started > t.ended_at + self.calls.continue_window
|| matches!(self.calls.judge(speaker, &f.text), Call::Stop) {
return None;
}
let t = self.turns.remove(&speaker).expect("checked");
let earcon_played = self.chimed.remove(&t.id) || (self.calls.earcon && self.answers.contains_key(&t.id));
debug_log!("conversation", "going on req={} speaker={speaker}", t.id);
match t.ask {
Some(q) => {
self.asks.remove(&q);
}
None => {
let a = self.policy.withdraw(t.id);
self.apply(a, now);
}
}
Some((t.text, earcon_played))
}
/// The policy's stop, and every pending "was it said to Jarvis?" question is void.
fn stop_everything(&mut self, now: Instant) {
self.wakes.clear();
self.turns.clear();
let a = self.policy.stop();
self.apply(a, now);
self.chimed.clear(); // nothing is waiting any more
@@ -405,6 +469,7 @@ impl<V: Voice> Conversation<V> {
for id in late {
if let Some((req, _)) = self.asks.remove(&id) {
debug_log!("conversation", "addressed req={} timed out", req.id);
self.turns.retain(|_, t| t.id != req.id);
let a = self.policy.utterance_closed(req.speaker, now);
self.apply(a, now);
}
@@ -415,8 +480,7 @@ impl<V: Voice> Conversation<V> {
for speaker in due {
if let Some((req, _)) = self.wakes.remove(&speaker) {
debug_log!("conversation", "wake word alone req={} answered alone", req.id);
let a = self.policy.request(req, now);
self.apply(a, now);
self.voice_request(req, now);
}
}
let a = self.policy.tick(now);
@@ -457,6 +521,7 @@ impl<V: Voice> Conversation<V> {
}
Action::Missed(r, reason) => {
self.chimed.remove(&r.id);
self.turns.retain(|_, t| t.id != r.id);
debug_log!("conversation", "missed req={} speaker={} reason={reason:?}", r.id, r.speaker);
let mut missed = self.missed.lock().unwrap();
if missed.len() == MISSED_KEPT {
@@ -590,6 +655,7 @@ mod tests {
const A: u64 = 11;
const B: u64 = 22;
const C: u64 = 33;
fn conv(kind: PolicyKind, mode: CallMode) -> (Conversation<Fake>, Fake, Instant) {
let f = Fake::default();
@@ -613,7 +679,7 @@ mod tests {
assert!(f.take().is_empty(), "a waiting request gets its earcon when its answer starts");
c.on_event(&end("s1", false), ms(t, 3000));
assert_eq!(f.take(), vec![Did::Earcon, Did::Answer(B, "자비스 불 꺼 줘".into())]);
c.on_event(&fin(B, "오늘 뭐 먹지", 100), ms(t, 3100));
c.on_event(&fin(C, "오늘 뭐 먹지", 100), ms(t, 3100));
assert!(f.take().is_empty(), "no call, no earcon");
}
@@ -659,10 +725,10 @@ mod tests {
c.on_event(&fin_utt(B, 1, "자비스"), ms(t, 100));
c.on_event(&partial(B, "지금 몇 시"), ms(t, 300));
assert_eq!(f.take(), vec![Did::Prepare(B, "자비스 지금 몇 시".into())]);
// Not while an answer runs.
// Not while an answer runs (to someone else: its asker going on is joined to it).
c.on_event(&fin(A, "자비스 날씨", 100), ms(t, 400));
f.take();
c.on_event(&partial(A, "자비스 내일은"), ms(t, 500));
c.on_event(&partial(C, "자비스 내일은"), ms(t, 500));
assert!(f.take().is_empty());
}
@@ -904,7 +970,7 @@ mod tests {
let (mut c, f, t) = conv(PolicyKind::InOrder, CallMode::Addressed);
c.on_event(&fin(A, "자비스 날씨", 100), ms(t, 0));
c.on_event(&fin(B, "자비스 뉴스", 100), ms(t, 100));
c.on_event(&fin(B, "불 좀 꺼 줄래", 100), ms(t, 200)); // waiting for "addressed"
c.on_event(&fin(C, "불 좀 꺼 줄래", 100), ms(t, 200)); // waiting for "addressed"
let did = f.take();
let q = did.iter().find_map(|d| if let Did::Addressed(q, _) = d { Some(q.clone()) } else { None }).unwrap();
// The slash command stops all speech: Stopped comes before the speech's end.
@@ -1016,9 +1082,95 @@ mod tests {
let (mut c, f, t) = conv(PolicyKind::InOrder, CallMode::WakeWord);
c.on_event(&fin(A, "자비스 하나", 0), ms(t, 0));
c.on_event(&fin(B, "자비스 둘", 0), ms(t, 1000));
c.on_event(&fin(A, "자비스 셋", 900), ms(t, 1500)); // ended at 600, before 둘
c.on_event(&fin(C, "자비스 셋", 900), ms(t, 1500)); // ended at 600, before 둘
f.take();
c.on_event(&end("s1", false), ms(t, 2000));
assert_eq!(f.take(), vec![Did::Answer(A, "자비스 셋".into())]);
assert_eq!(f.take(), vec![Did::Answer(C, "자비스 셋".into())]);
}
fn alone(kind: PolicyKind) -> (Conversation<Fake>, Fake, Instant) {
let (c, f, t) = conv(kind, CallMode::Addressed);
*f.people.borrow_mut() = vec![A];
(c, f, t)
}
fn speak_start(id: &str) -> CoreEvent {
CoreEvent::SpeakStart(id.into())
}
#[test]
fn a_speaker_who_goes_on_before_the_answer_is_heard_gets_one_answer_for_all_of_it() {
// Live 2026-11-19: each piece of one thought was answered on its own, one after another.
for kind in [PolicyKind::Latest, PolicyKind::InOrder, PolicyKind::First, PolicyKind::Important] {
let (mut c, f, t) = alone(kind);
c.on_event(&fin(A, "지금 화면 봐봐", 100), ms(t, 0));
assert_eq!(f.take(), vec![Did::Answer(A, "지금 화면 봐봐".into())], "{kind:?}");
// The next piece starts 0.8 s after the first ended, while Jarvis is still thinking.
c.on_event(&fin(A, "디코 화면 공유 창에 가려져 있잖아", 100), ms(t, 1800));
assert_eq!(f.take(), vec![Did::Cancel("s1".into()),
Did::Answer(A, "지금 화면 봐봐 디코 화면 공유 창에 가려져 있잖아".into())], "{kind:?}");
c.on_event(&fin(A, "앞으로 오게 해 줘", 100), ms(t, 4000));
assert_eq!(f.take(), vec![Did::Cancel("s2".into()),
Did::Answer(A, "지금 화면 봐봐 디코 화면 공유 창에 가려져 있잖아 앞으로 오게 해 줘".into())],
"{kind:?}");
assert_eq!(c.missed().count(), 0, "a joined piece is not a missed request ({kind:?})");
// The cancelled speech's end does not end the joined answer.
c.on_event(&end("s1", true), ms(t, 4100));
assert!(f.take().is_empty(), "{kind:?}");
}
}
#[test]
fn what_follows_a_wake_word_call_is_joined_even_without_the_wake_word() {
let (mut c, f, t) = conv(PolicyKind::Latest, CallMode::WakeWord);
c.on_event(&fin(A, "자비스 디코 화면 공유 보여", 100), ms(t, 0));
c.on_event(&fin(A, "내 화면 말이야", 100), ms(t, 2000));
assert_eq!(f.take(), vec![Did::Answer(A, "자비스 디코 화면 공유 보여".into()), Did::Cancel("s1".into()),
Did::Answer(A, "자비스 디코 화면 공유 보여 내 화면 말이야".into())]);
// Someone else's words never join it.
c.on_event(&fin(B, "나도 안 보여", 100), ms(t, 2500));
assert!(f.take().is_empty());
}
#[test]
fn once_the_answer_is_heard_or_the_pause_is_long_the_next_words_are_a_new_request() {
let (mut c, f, t) = alone(PolicyKind::Latest);
c.on_event(&fin(A, "계산기 켜 줘", 100), ms(t, 0));
c.on_event(&speak_start("s1"), ms(t, 1500));
c.on_event(&fin(A, "고마워", 100), ms(t, 2500));
assert_eq!(f.take(), vec![Did::Answer(A, "계산기 켜 줘".into()), Did::Cancel("s1".into()),
Did::Answer(A, "고마워".into())]);
// Still thinking, but the speaker paused longer than call.continueMs.
let (mut c, f, t) = alone(PolicyKind::InOrder);
let pause = test_calls().continue_window.as_millis() as u64;
c.on_event(&fin(A, "계산기 켜 줘", 100), ms(t, 0));
// The next utterance (1 s long) starts `pause` + 100 ms after the first ended.
c.on_event(&fin(A, "메모장도", 100), ms(t, pause + 1100));
assert_eq!(f.take(), vec![Did::Answer(A, "계산기 켜 줘".into())], "queued as its own request");
}
#[test]
fn a_stop_said_while_the_answer_is_prepared_still_stops_it() {
let (mut c, f, t) = conv(PolicyKind::Latest, CallMode::WakeWord);
c.on_event(&fin(A, "자비스 날씨 알려 줘", 100), ms(t, 0));
c.on_event(&fin(A, "자비스 멈춰", 100), ms(t, 1500));
assert_eq!(f.take(), vec![Did::Answer(A, "자비스 날씨 알려 줘".into()), Did::StopAll, Did::Cancel("s1".into())]);
}
#[test]
fn going_on_lets_the_brain_get_ready_for_the_joined_request() {
let (mut c, f, t) = alone(PolicyKind::Latest);
c.on_event(&fin(A, "계산기 켜 줘", 100), ms(t, 0));
f.take();
c.on_event(&partial(A, "제일 위로"), ms(t, 1200));
assert_eq!(f.take(), vec![Did::Prepare(A, "계산기 켜 줘 제일 위로".into())]);
}
#[test]
fn the_joined_request_gets_no_second_earcon() {
let (mut c, f, t) = conv_earcon(PolicyKind::Latest);
c.on_event(&fin(A, "자비스 날씨", 100), ms(t, 0));
c.on_event(&fin(A, "부산", 100), ms(t, 1500));
assert_eq!(f.take(), vec![Did::Earcon, Did::Answer(A, "자비스 날씨".into()), Did::Cancel("s1".into()),
Did::Answer(A, "자비스 날씨 부산".into())]);
}
}

View File

@@ -34,6 +34,7 @@ Settings (`settings.json`, section `call`; wake words stay in `voice.wakeWords`)
| `call.stopWords` | `["멈춰", "그만", "정지", "stop"]` | Said together with a wake word, they stop Jarvis in any policy. |
| `call.earcon` | `true` | Play the earcon (below) when Jarvis takes a voice call. |
| `call.followUpMs` | `1500` | After a wake word said alone, how long the speaker's next utterance may take to start and still be joined to it. 0-5000. |
| `call.continueMs` | `5000` | Going on (below): how long after a request's utterance ended the speaker's next utterance may start and still be part of it, while its answer is not heard yet. 0 turns joining off. 0-15000. |
Normalisation: Unicode NFKD, lower case, and only letters and digits kept (spaces, punctuation and
combining marks dropped). NFKD splits Hangul syllables into their letters, so "자비즈" is one letter
@@ -78,6 +79,27 @@ connection (`WorkerLost`): the final it waited for will not come, and the restar
utterances are not continuations of it. Chat messages are not joined:
a message is complete as sent.
**Going on.** People say one thing in pieces, with pauses of a fraction of a second to several
seconds between them (live 2026-11-19: 0.1-4.7 s inside one thought), and every pause longer than
the worker's `end_silence_ms` ends an utterance. Each piece used to be answered on its own, one after
another, and the answers piled up (user request, 2026-11-19: what is said in pieces is one request).
So a speaker's voice request stays open until its answer is heard (the first audio of its speech
plays, `SpeakStart`), and while it is open their next final is joined to it when that utterance
started within `call.continueMs` of the request's end (start = the final's arrival minus its
`wait_ms` and `audio_ms`):
- The earlier request is taken back (the policy's `withdraw`): a running answer is stopped (its
speech `cancel`led, which also stops the brain, `voice_worker.spec.md`), a waiting one leaves the
queue, a pending "addressed" question is void. It is not a missed request.
- The joined text (the earlier text, a space, the new final) is judged and answered as one request,
as if it had been said in one go; it ends when the new final ended. It may be joined again.
- The new final is joined whatever it is on its own (a piece needs no wake word of its own), except
a stop: a stop stops, as always.
- Other speakers' utterances never join it. An answer already heard, an answer that ended, a missed
request, a stop, leaving and a lost worker end it; then what the speaker says is a new request.
- The joined request gets no second earcon when the first one's already played.
- While a request is open, its speaker's partials are sent to get ready as the joined text, also while
its answer is being written (it is the request that will be answered).
**Earcon.** A short two-tone "띠링" (about 0.3 s, made by the app, `app/src/earcon.rs`) tells the
speaker Jarvis heard the call, long before the answer is written: it is the first sound after a call.
It plays right before each voice answer starts (the policy's `Answer`), and at once when a wake word
@@ -116,6 +138,9 @@ Rules shared by every policy:
than the request's `ended_at` (in `important`: any ending utterance, since it competes on score), the
policy waits for that final, at most `settleMs` from the first waiting request's arrival. A final that
is not a call ends the wait for it. `latest` does not settle: an earlier utterance would lose anyway.
- **Taking back.** A request whose speaker went on (Going on) is withdrawn: stopped when it is the
running answer, removed when it waits, dropped from a pending ranking. Not missed; the joined
request that follows goes through the policy as any new request.
- **Stop.** A stop decision stops the current answer and drops every waiting request, in every policy.
The stopped answer and the dropped requests are missed (`stopped`).
- An answer that is already done is never started again.
@@ -181,7 +206,8 @@ event is passed on unchanged). It talks to the core through a small `Voice` inte
one request, stop all, earcon, prepare, ask "addressed", ask "rank"), so the glue is tested with a fake.
- `Chat` and `ReplyText`: chat calls, above.
- `Partial` (getting ready): a partial transcript that call detection already reads as a request
- `Partial` (getting ready): a partial of a speaker whose request is open (Going on) is sent as the
joined text. Otherwise a partial transcript that call detection already reads as a request
(joined to the speaker's waiting wake word alone, as its final would be; not the wake word alone,
not a stop) is sent to the brain as `prepare(user, text)`, so the brain judges what the call needs
while the speaker is still talking (`voice_worker.spec.md`, `prepare`). Not while an answer runs:
@@ -198,6 +224,7 @@ one request, stop all, earcon, prepare, ask "addressed", ask "rank"), so the glu
cannot be queued the answer is done at once); `StopAnswer` → `cancel` of that answer's speech;
`Rank { id }` → `rank` with id `k<id>` and the candidates' request ids; `Missed` → a debug log and
the missed list (the last 100: speaker, reason, time and length, never the text).
- `SpeakStart` of an answer's speech: the answer is heard, its request is no longer open (Going on).
- `SpeakEnd` of an answer's speech is that answer's done. The end of a speech the loop already
cancelled starts nothing.
- `Stopped` (all speech stopped from elsewhere: the slash command, `stop()`, the session ending) and
@@ -218,7 +245,10 @@ fake voice side (answering and queueing, a busy drop recorded without text, voic
with Jarvis answered without asking, the room counts sent with the question, addressed yes,
no and timeout, the earcon before each answer, once for a wake word alone, none while busy or when
off, partials that read as a call sent to get ready (joined to a waiting wake word, none while
answering), interruption cancelling the right speech, a ranking deciding, end times from
answering someone else, the joined text while going on), going on (pieces joined into one answer in
every policy without a missed record, a piece without a wake word joined, other speakers never, a
new request once the answer is heard or the pause is longer than `call.continueMs`, a stop still
stopping, no second earcon), interruption cancelling the right speech, a ranking deciding, end times from
`wait_ms`, and chat: an answer posted as a reply once, per-channel switches, no answers to bots or to
a stop, chat wake words and designated people, a failed answer posting nothing). `tests/worker_protocol.rs` checks an answer spoken under its id and both judgements against
the real Python worker with a fake brain.

View File

@@ -254,6 +254,21 @@ impl Policy {
}
}
/// The request is taken back before its answer was heard: its speaker went on talking and it is
/// joined to what they said next (conversation.spec.md, "Going on"). Not a missed request. When
/// it is the running answer it is stopped; nothing else starts until the joined request comes.
pub fn withdraw(&mut self, id: u64) -> Vec<Action> {
if self.current.as_ref().is_some_and(|r| r.id == id) {
self.current = None;
return vec![Action::StopAnswer(id)];
}
self.waiting.retain(|r| r.id != id);
if self.ranking.as_ref().is_some_and(|r| r.ids.contains(&id)) {
self.ranking = None;
}
vec![]
}
/// A stop command: stop the answer and drop everything waiting.
pub fn stop(&mut self) -> Vec<Action> {
let mut out = vec![];

View File

@@ -453,6 +453,7 @@ fn parse_call(raw: &Map<String, Value>, wake_words: &[String], d: &CallSettings)
designated_no_wake_word: get_bool(call, "designatedNoWakeWord", "call", d.designated_no_wake_word)?,
stop_words,
follow_up: get_ms(call, "followUpMs", "call", d.follow_up, 5000)?,
continue_window: get_ms(call, "continueMs", "call", d.continue_window, 15000)?,
earcon: get_bool(call, "earcon", "call", d.earcon)?,
},
chat_wake_words,

View File

@@ -95,6 +95,7 @@ pub fn fields() -> Vec<Field> {
f("call.stopWords", Call, TextList { max_items: 20, nullable: false },
json!(["멈춰", "그만", "정지", "stop"]), "정지 명령"),
f("call.followUpMs", Call, Int { min: 0, max: 5000 }, json!(1500), "호출어 뒤 이어 말하기 대기(ms)"),
f("call.continueMs", Call, Int { min: 0, max: 15000 }, json!(5000), "끊어 말한 문장 합치기(ms)"),
f("call.earcon", Call, Bool, json!(true), "부르면 효과음"),
f("response.policy", Response, Choice { values: &["first", "inOrder", "latest", "important"] },
json!("latest"), "동시 대화 응답 정책"),

View File

@@ -20,6 +20,7 @@ Every distinct LLM call in Jarvis, what feeds it, what consumes it, and how it i
- **Operator instructions** (two sources, both framed "Additional instructions from the operator:" and appended near the end of the guidance list): the settings-UI `llm_instructions` config field, and every `*.md` file in `AGENTS_DIR` (default `/app/agents`, bind-mounted from `./agents`). The file-based set is read once per turn by `load_agent_instructions()` in [src/jarvis/system_prompt.py](src/jarvis/system_prompt.py) and concatenated in filename order, so dropping/editing a `.md` applies on the next reply with no rebuild/restart; fail-open to `""` when the folder is absent/empty/unreadable.
- **Warm profile block** (query-agnostic User + Directives excerpt from the knowledge graph, composed by `build_warm_profile()` / `format_warm_profile_block()` in [src/jarvis/memory/graph_ops.py](src/jarvis/memory/graph_ops.py) at Step 3.5 of `reply()`; no LLM call, pure SQLite read; injected unconditionally so personalisation is the default; result cached in `DialogueMemory._hot_cache` under `DialogueMemory.WARM_PROFILE_CACHE_KEY` for the lifetime of the active conversation. Invalidated on `stop`, on new-conversation entry, AND on User/Directives graph mutations via the listener registered in [src/jarvis/daemon.py](src/jarvis/daemon.py) against `register_graph_mutation_listener` in [src/jarvis/memory/graph.py](src/jarvis/memory/graph.py); World-branch writes are ignored)
- Digested memory enrichment (optional, see #4)
- **v2 cancel** (`turn_state.set_cancel`, set by the voice worker's brain): once the app takes a voice request back (its asker went on talking, a newer request or a stop), the loop stops before its next chat-model call or tool call and the reply returns no answer, so a dropped request never holds up the one that replaces it (`voice_worker.spec.md`, "History and brain").
- **v2 history context** (optional, caller-supplied `history=` on `run_reply_engine`): the recent window and search matches from the history store ([src/jarvis/memory/history.py](src/jarvis/memory/history.py), [spec](src/jarvis/memory/history.spec.md)), scoped to the asker and capped by the store's size budget (default about 4,000 tokens, matches at most half). No LLM call; not gated by the planner. Injected in a `<conversation_records>` fence labelled "Information shared in previous conversations"; the lines are data, not instructions. Eval: `evals/test_history_context_recall.py`. With `legacy_memory=False` (the v2 brain in the voice worker) the warm profile and the whole memory enrichment chain (#3 extractor, #3b recall gate, #4 digest and the diary/graph reads) are skipped for the turn, because v1's long-term memory belongs to a single user.
- Time + location context (re-injected each turn)
- **v2 chat channel tool**: when the voice worker's brain sets a chat backend (`turn_state.set_chat`), `chatChannels` is added to the turn's tools after routing (like `setBroadcast`) and its read/search results enter the loop inside an UNTRUSTED CHAT MESSAGES fence; without a backend it is not in the catalogue at all. Eval: `evals/test_chat_channels_tool.py`.

View File

@@ -2376,6 +2376,9 @@ def run_reply_engine(db: "Database", cfg, tts: Optional[Any],
_one_step_nudged = False
while turn < max_turns:
if _turn_state.cancelled():
debug_log("reply cancelled: no longer wanted", "planning")
return None
turn += 1
debug_log(f"🔁 messages loop turn {turn}", "planning")
print(f" 🔁 Turn {turn}/{max_turns}", flush=True)
@@ -2840,7 +2843,10 @@ def run_reply_engine(db: "Database", cfg, tts: Optional[Any],
messages.append({"role": "tool", "tool_call_id": tool_call_id, "content": f"You have already called {tool_name} {duplicate_tool_count} times. Please use the results from those calls to answer the user's question."})
continue
# Execute tool
# Execute tool (not for an answer that is no longer wanted: no actions on its behalf)
if _turn_state.cancelled():
debug_log("reply cancelled before a tool call", "planning")
return None
tools_started += 1
result = run_tool_with_retries(
db=db,

View File

@@ -37,6 +37,9 @@ pc : Optional[object]
trace : Optional[list]
v2: where the engine writes down how it made this answer (history.spec.md, "Traces"): the
tools it was given, the plan, the model's thinking and each tool call. None records nothing.
cancel : Optional[callable]
v2: true once the answer is no longer wanted (the asker went on talking, or a newer request or a
stop took its place). The engine checks it before each model call and each tool call.
"""
from __future__ import annotations
@@ -58,6 +61,17 @@ def reset() -> None:
_state.screen = None
_state.pc = None
_state.trace = None
_state.cancel = None
def set_cancel(check) -> None:
_state.cancel = check
def cancelled() -> bool:
"""Whether this turn's answer is no longer wanted."""
check = getattr(_state, "cancel", None)
return bool(check and check())
def set_trace(steps: Optional[list]) -> None:

View File

@@ -10,7 +10,7 @@ import unicodedata
import threading
import time
from dataclasses import dataclass
from typing import Optional, Protocol
from typing import Callable, Optional, Protocol
from .log import debug_log, notice
from jarvis.memory.history import HistoryContext, Scope
@@ -19,7 +19,8 @@ from jarvis.memory.history import HistoryContext, Scope
class Brain(Protocol):
def reply(self, user: str, text: str, history: HistoryContext, chat=None, schedule=None,
task: bool = False, notes: Optional[list] = None, notes_backend=None,
screen=None, pc=None, trace: Optional[list] = None) -> Optional[str]:
screen=None, pc=None, trace: Optional[list] = None,
cancelled: Optional[Callable[[], bool]] = None) -> Optional[str]:
"""Blocking; called on a worker thread, one call per person at a time (a voice and a chat
reply for different people may overlap). ``chat``: the chat backend for
the chatChannels tool (voice_worker/chat_bridge.py), or None without registered channels.
@@ -28,7 +29,8 @@ class Brain(Protocol):
``notes``: the asker's standing instructions, put in the prompt; ``notes_backend``: the
backend for the personalNotes tool (personal_notes.spec.md); ``screen``: the backend for the
screenView tool (screen_view.spec.md); ``trace``: a list the engine adds the steps of
this answer to (history.spec.md, "Traces")."""
this answer to (history.spec.md, "Traces"); ``cancelled``: true once the answer is no longer
wanted, so the engine stops at its next model or tool call and None is returned."""
def addressed(self, user: str, text: str, names: list[str], people: Optional[int] = None,
callers: Optional[int] = None) -> Optional[bool]:
@@ -310,7 +312,8 @@ class JarvisBrain:
def reply(self, user: str, text: str, history: HistoryContext, chat=None, schedule=None,
task: bool = False, notes: Optional[list] = None, notes_backend=None,
screen=None, pc=None, trace: Optional[list] = None) -> Optional[str]:
screen=None, pc=None, trace: Optional[list] = None,
cancelled: Optional[Callable[[], bool]] = None) -> Optional[str]:
from jarvis.memory.conversation import DialogueMemory
from jarvis.reply import turn_state
from jarvis.reply.engine import run_reply_engine
@@ -334,6 +337,7 @@ class JarvisBrain:
turn_state.set_screen(None if task else screen)
turn_state.set_pc(None if task else pc)
turn_state.set_trace(trace)
turn_state.set_cancel(cancelled)
try:
return run_reply_engine(self.db, cfg, None, text, memory,
language=self.language, history=history, legacy_memory=False,

View File

@@ -281,7 +281,7 @@ class Session:
self.tts_recorded: dict[str, dict] = {}
# Spoken replies whose speech was cancelled while the brain was still answering.
self.cancelled_replies: set[str] = set()
self.thinking_replies: set[str] = set()
self.thinking_replies: dict[str, str] = {} # reply id -> asker
# user -> the newest call text waiting for that user's running prepare to finish (or None).
self.preparing: dict[str, str | None] = {}
self.last_prepared: dict[str, str] = {} # user -> the text of their last prepare
@@ -681,12 +681,15 @@ class Session:
asyncio.get_running_loop().create_task(self._task(rid, user, text, notes))
return
if speak:
self.thinking_replies.add(rid)
self.thinking_replies[rid] = user
if user in self.preparing:
self.preparing[user] = None # the call was answered: no newer text to prepare
self.last_prepared.pop(user, None)
waiting = self.worker.replies_unanswered
early = waiting.get(user, 0) > 0 # sent before their previous answer: not a reply to it
# Sent before their previous answer: not a reply to it. An answer taken back (cancelled while
# the brain thinks) does not count: what comes now replaces it.
taken_back = sum(1 for r in self.cancelled_replies if self.thinking_replies.get(r) == user)
early = waiting.get(user, 0) - taken_back > 0
waiting[user] = waiting.get(user, 0) + 1
asyncio.get_running_loop().create_task(self._reply(rid, user, text, via, speak, early, channel, notes))
@@ -918,7 +921,7 @@ class Session:
await self._reply_inner(rid, user, text, via, speak, early, channel, notes or [], trace=trace)
finally:
trace.finish("") # only when it did not get to its answer
self.thinking_replies.discard(rid)
self.thinking_replies.pop(rid, None)
self.cancelled_replies.discard(rid)
if not self._handed_over.pop(rid, False): # else _delivered counts it
self._reached(user)
@@ -986,23 +989,39 @@ class Session:
pc = AppBridge(self, asyncio.get_running_loop(), "pc", *origin, turn=turn,
state=w.pc_state.setdefault(user, {}))
trace.append(self._records_step(history, notes))
try:
async with self._llm(rid if speak else None), self._card_watch(f"answer {rid}"):
w.answering += 1
try:
answer = await asyncio.to_thread(w.brain.reply, user, text, history, chat=chat,
schedule=schedule, notes=notes or [],
notes_backend=notes_backend, screen=screen, pc=pc,
trace=trace)
finally:
w.answering -= 1
if not w.answering and w.scheduler:
w.scheduler.wake() # held partials go on
except Exception as e: # the brain must never take the session down
debug_log(f"brain reply {rid} failed: {type(e).__name__}", "llm")
answer = None
answer = None
if speak and rid in self.cancelled_replies:
# Taken back while it waited for the asker's previous answer: never started.
debug_log(f"brain reply {rid} not started: cancelled while waiting", "llm")
else:
try:
async with self._llm(rid if speak else None), self._card_watch(f"answer {rid}"):
w.answering += 1
try:
answer = await asyncio.to_thread(
w.brain.reply, user, text, history, chat=chat, schedule=schedule,
notes=notes or [], notes_backend=notes_backend, screen=screen, pc=pc,
trace=trace, cancelled=lambda: rid in self.cancelled_replies)
finally:
w.answering -= 1
if not w.answering and w.scheduler:
w.scheduler.wake() # held partials go on
except Exception as e: # the brain must never take the session down
debug_log(f"brain reply {rid} failed: {type(e).__name__}", "llm")
answer = None
answer = (answer or "").strip()
trace.finish(answer)
if not answer and speak and rid in self.cancelled_replies:
# Taken back before it was written: as if never asked, so the request that replaces
# it is still the very next turn (a confirmation it carries does not lapse).
w.reply_turns[user] = turn - (2 if early else 1)
debug_log(f"brain reply {rid} taken back", "llm")
self.send({"type": "reply_text", "id": rid, "text": "", "failed": True})
if rid in self.tts_requests:
self._on_tts({"type": "tts", "id": rid, "text": "", "more": False})
else:
self.send({"type": "tts_done", "id": rid, "chunks": 0, "cancelled": True, "failed": False})
return
if not answer and rid in self.tts_requests:
self._on_tts({"type": "tts", "id": rid, "text": "", "more": False}) # ends the notice's speech
self.send({"type": "reply_text", "id": rid, "text": answer, "failed": not answer})

View File

@@ -257,8 +257,15 @@ which carry Discord's own time.
answer is stored when the app reports the sent message as `chat_message` with `to`. With
`speak: true` the answer is also spoken through the TTS path under the same id (audio frames and
`tts_done`), and `tts_cancel` with that id stops it. A `tts_cancel` that arrives while the brain is
still answering means the answer is not spoken: `reply_text` still comes, then `tts_done` with
`cancelled: true` and no audio. Every reply, a task's too and one that failed, leaves a trace of
still answering means the answer is no longer wanted (the app took the request back: its asker
went on talking, a newer request or a stop took its place). A reply still waiting for the asker's
previous answer is never started; a running one stops at the engine's next model call or tool
call (`turn_state.cancel`: no tool runs on its behalf) and returns no answer. Such a reply is as if
never asked: `reply_text` comes with empty text and `failed: true`, then `tts_done` with
`cancelled: true` and no audio, and it uses up no turn of the asker's (the request that replaces it
is still the very next turn, so a confirmation it carries does not lapse; nor is that request
"sent before the previous answer"). A reply whose answer was already written when the cancel
came still sends its text, then `tts_done` with `cancelled: true` and no audio. Every reply, a task's too and one that failed, leaves a trace of
how it was made (`history.spec.md`, "Traces"): the history lines and number of notes it was given,
then what the engine wrote down. It is stored as soon as the request arrives (before it waits for
the asker's previous answer) and again as each step is added, then ends with the answer, or with

View File

@@ -0,0 +1,66 @@
"""An answer that is no longer wanted stops at the engine's next model or tool call (turn_state.cancel).
The voice worker sets it when the app takes the request back (the asker went on talking and the
request is joined to what they said next, a newer request took its place, or a stop). The engine
then returns no answer and runs no tool on the request's behalf.
"""
from __future__ import annotations
from unittest.mock import patch
import pytest
def _native_call(name: str, args: dict) -> dict:
return {"message": {"role": "assistant", "content": "", "tool_calls": [
{"id": "call_1", "type": "function", "function": {"name": name, "arguments": args}}]}}
def _run(mock_config, db, dialogue_memory, cancel_after_calls: int):
from jarvis.memory.history import HistoryContext
from jarvis.reply import engine as engine_mod
from jarvis.reply import turn_state
from jarvis.tools.types import ToolExecutionResult
mock_config.ollama_chat_model = "gpt-oss:20b"
mock_config.evaluator_enabled = False
mock_config.stream_browser = False
calls = []
invoked = []
def fake_chat(*args, **kwargs):
calls.append(1)
return _native_call("getWeather", {"location": "Seoul"})
def fake_tool(db, cfg, tool_name, tool_args, **kwargs):
invoked.append(tool_name)
return ToolExecutionResult(success=True, reply_text="Seoul: 13C", error_message=None)
turn_state.reset()
turn_state.set_cancel(lambda: len(calls) >= cancel_after_calls)
try:
with patch.object(engine_mod, "run_tool_with_retries", side_effect=fake_tool), \
patch.object(engine_mod, "chat_with_messages", side_effect=fake_chat), \
patch.object(engine_mod, "select_tools", return_value=["getWeather", "stop"]), \
patch.object(engine_mod, "plan_query", return_value=["Reply to the user."]):
reply = engine_mod.run_reply_engine(
db=db, cfg=mock_config, tts=None, text="서울 날씨 어때?",
dialogue_memory=dialogue_memory, history=HistoryContext(), legacy_memory=False,
intent_judge=True)
finally:
turn_state.reset()
return reply, len(calls), invoked
@pytest.mark.unit
def test_an_answer_cancelled_before_it_starts_makes_no_model_call(mock_config, db, dialogue_memory):
reply, calls, invoked = _run(mock_config, db, dialogue_memory, cancel_after_calls=0)
assert reply is None and calls == 0 and invoked == []
@pytest.mark.unit
def test_an_answer_cancelled_during_a_model_call_runs_no_tool_for_it(mock_config, db, dialogue_memory):
# The model asks for a tool, but the answer was taken back meanwhile: the tool is not run.
reply, calls, invoked = _run(mock_config, db, dialogue_memory, cancel_after_calls=1)
assert reply is None and calls == 1 and invoked == []

View File

@@ -29,8 +29,9 @@ class FakeBrain:
self.calls = []
def reply(self, user, text, history, chat=None, schedule=None, task=False, notes=None, notes_backend=None,
screen=None, pc=None, trace=None):
screen=None, pc=None, trace=None, cancelled=None):
self.calls.append((user, text, history))
self.cancelled = cancelled
if trace is not None:
trace.append({"kind": "tools", "names": ["getWeather"]})
self.chat, self.schedule, self.task = chat, schedule, task
@@ -730,6 +731,83 @@ def test_a_reply_cancelled_while_the_brain_thinks_is_not_spoken(store):
assert replies == ["r1", "r2"], "the text still comes back; only the speech is skipped"
@pytest.mark.unit
def test_a_cancelled_reply_stops_the_brain_and_one_still_waiting_never_reaches_it(store):
"""A request taken back (the asker went on talking) must not hold up the next one: the brain is
told to stop the running answer, and a reply still waiting for it is never started."""
import time
started = []
def answer(user, text):
started.append(text)
if text == "first":
t0 = time.monotonic()
while not brain.cancelled() and time.monotonic() - t0 < 10:
time.sleep(0.01)
return None if brain.cancelled() else "late answer"
return f"answer for {text}"
brain = FakeBrain(answer)
async def body(url):
async with connect(url) as ws:
await hello(ws)
await send(ws, type="voice_join", channel="vc1")
await send(ws, type="reply", id="r1", user="100", text="first", via="voice", speak=True)
await asyncio.sleep(0.1)
await send(ws, type="reply", id="r2", user="100", text="second", via="voice", speak=True)
await send(ws, type="tts_cancel", id="r1")
await send(ws, type="tts_cancel", id="r2")
await send(ws, type="reply", id="r3", user="100", text="first second", via="voice", speak=True)
t0 = time.monotonic()
seen = await recv_until(ws, lambda m: isinstance(m, dict) and m.get("type") == "tts_done"
and m["id"] == "r3")
return seen, time.monotonic() - t0
seen, waited = asyncio.run(with_worker(body, store=store, brain=brain, tts=FakeTts()))
assert waited < 3, "the joined request did not wait for the cancelled answer to run out"
assert started == ["first", "first second"]
done = {m["id"]: m for m in seen if isinstance(m, dict) and m.get("type") == "tts_done"}
assert done["r1"]["cancelled"] and done["r2"]["cancelled"] and not done["r3"]["cancelled"]
frames = {decode_tts_frame(m)[0] for m in seen if isinstance(m, bytes)}
assert frames == {"r3"}
@pytest.mark.unit
def test_a_request_taken_back_does_not_use_up_the_turn_a_confirmation_needs(store):
"""Jarvis asked something; the asker says "yes" and goes on ("yes, quickly"). The app takes the
"yes" back and sends the joined text: it must still be the very next turn, or a confirmation
(pcControl, chat delete) would lapse."""
import time
turns = {}
def answer(user, text):
turns[text] = brain.pc.turn
if text == "yes":
t0 = time.monotonic()
while not brain.cancelled() and time.monotonic() - t0 < 10:
time.sleep(0.01)
return None
return f"answer for {text}"
brain = FakeBrain(answer)
async def body(url):
async with connect(url) as ws:
await hello(ws)
await send(ws, type="voice_join", channel="vc1")
await send(ws, type="reply", id="r1", user="100", text="open the calculator", via="voice", speak=False)
await recv_until(ws, lambda m: isinstance(m, dict) and m.get("type") == "reply_text")
await send(ws, type="reply", id="r2", user="100", text="yes", via="voice", speak=True)
await asyncio.sleep(0.1)
await send(ws, type="tts_cancel", id="r2")
await send(ws, type="reply", id="r3", user="100", text="yes quickly", via="voice", speak=True)
await recv_until(ws, lambda m: isinstance(m, dict) and m.get("type") == "tts_done" and m["id"] == "r3")
asyncio.run(with_worker(body, store=store, brain=brain, tts=FakeTts()))
assert turns["yes quickly"] == turns["open the calculator"] + 1
@pytest.mark.unit
def test_the_brains_judgements_use_its_model_and_map_back_to_ids(monkeypatch):
import voice_worker.judges as judges