Compare commits
14 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
3f2d37587d | ||
|
|
c55a9e4e05 | ||
|
|
b0c7532715 | ||
|
|
229f499465 | ||
|
|
6abc7f9475 | ||
|
|
e2c63fde7c | ||
|
|
5722c299d3 | ||
|
|
ecd254cb78 | ||
|
|
d559c0c56a | ||
|
|
05aace294e | ||
|
|
41c7c48825 | ||
|
|
1913181d02 | ||
|
|
d11289309b | ||
|
|
de723fd0b4 |
@@ -5,7 +5,7 @@ org.gradle.configuration-cache=false
|
||||
|
||||
# Mod
|
||||
mod_id=video_player
|
||||
mod_version=0.4.17
|
||||
mod_version=0.4.31
|
||||
maven_group=com.ejclaw.videoplayer
|
||||
archives_base_name=video_player
|
||||
|
||||
|
||||
@@ -3,6 +3,7 @@ package com.ejclaw.videoplayer;
|
||||
import com.ejclaw.videoplayer.block.VideoAnchorBlockEntity;
|
||||
import com.ejclaw.videoplayer.client.MusicQuizClient;
|
||||
import com.ejclaw.videoplayer.client.net.ClientNetworking;
|
||||
import com.ejclaw.videoplayer.client.playback.VideoCache;
|
||||
import com.ejclaw.videoplayer.client.playback.VideoPlayback;
|
||||
import com.ejclaw.videoplayer.client.render.VideoAnchorRenderer;
|
||||
import com.ejclaw.videoplayer.item.VideoStickItem;
|
||||
@@ -12,6 +13,7 @@ import net.fabricmc.api.ClientModInitializer;
|
||||
import net.fabricmc.api.EnvType;
|
||||
import net.fabricmc.api.Environment;
|
||||
import net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientBlockEntityEvents;
|
||||
import net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientLifecycleEvents;
|
||||
import net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents;
|
||||
import net.fabricmc.fabric.api.client.networking.v1.ClientPlayNetworking;
|
||||
import net.fabricmc.fabric.api.client.rendering.v1.BlockEntityRendererRegistry;
|
||||
@@ -20,6 +22,7 @@ import net.fabricmc.fabric.api.event.player.AttackBlockCallback;
|
||||
import net.minecraft.client.Minecraft;
|
||||
import net.minecraft.client.player.LocalPlayer;
|
||||
import net.minecraft.core.BlockPos;
|
||||
import net.minecraft.sounds.SoundSource;
|
||||
import net.minecraft.world.InteractionResult;
|
||||
import net.minecraft.world.phys.Vec3;
|
||||
|
||||
@@ -81,6 +84,11 @@ public class VideoPlayerClient implements ClientModInitializer {
|
||||
}
|
||||
});
|
||||
|
||||
// Wipe video_player_cache/ on game exit so preloaded clips don't pile up across
|
||||
// sessions. Cache entries are re-broadcast by the server on every JOIN, so a freshly
|
||||
// started game will repopulate the cache automatically.
|
||||
ClientLifecycleEvents.CLIENT_STOPPING.register(client -> VideoCache.wipeOnShutdown());
|
||||
|
||||
VideoPlayerMod.LOG.info("[{}] client initialized", VideoPlayerMod.MOD_ID);
|
||||
}
|
||||
|
||||
@@ -89,17 +97,26 @@ public class VideoPlayerClient implements ClientModInitializer {
|
||||
* Distance is measured from the player's eye to the <em>panel center</em>, not the anchor
|
||||
* block corner — for a 4×4 panel the corner is ~2 blocks off from where the screen visually
|
||||
* sits, which made the audio feel like it was off to the side.
|
||||
*
|
||||
* <p>Gain is also gated by the Minecraft sound options so the in-game sliders work as
|
||||
* expected: vanilla {@code SoundEngine.calculateVolume} multiplies by master × category, so
|
||||
* we do the same with {@link SoundSource#PLAYERS} as the category. Result: dragging the
|
||||
* "Players" slider in Options → Music & Sounds attenuates video audio just like other
|
||||
* player sounds, and "Master" still gates everything.
|
||||
*/
|
||||
private static void updateDistanceGains(Minecraft client) {
|
||||
LocalPlayer p = client.player;
|
||||
if (p == null || client.level == null) return;
|
||||
Vec3 eye = p.getEyePosition();
|
||||
float masterVol = client.options.getSoundSourceVolume(SoundSource.MASTER);
|
||||
float playersVol = client.options.getSoundSourceVolume(SoundSource.PLAYERS);
|
||||
float categoryScale = masterVol * playersVol;
|
||||
for (BlockPos pos : VideoPlayback.activePositions()) {
|
||||
if (!(client.level.getBlockEntity(pos) instanceof VideoAnchorBlockEntity be)) continue;
|
||||
Vec3 center = be.panelCenter();
|
||||
double d = center.distanceTo(eye);
|
||||
float attenuation = (float) Math.max(0.0, Math.min(1.0, 1.0 - d / 16.0));
|
||||
float gain = be.isMuted() ? 0F : be.getVolume() * attenuation;
|
||||
float gain = be.isMuted() ? 0F : be.getVolume() * attenuation * categoryScale;
|
||||
VideoPlayback.setGain(pos, gain);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -3,7 +3,11 @@ package com.ejclaw.videoplayer.block;
|
||||
import com.ejclaw.videoplayer.registry.VideoPlayerBlockEntities;
|
||||
import net.minecraft.core.BlockPos;
|
||||
import net.minecraft.core.Direction;
|
||||
import net.minecraft.core.HolderLookup;
|
||||
import net.minecraft.nbt.CompoundTag;
|
||||
import net.minecraft.network.protocol.Packet;
|
||||
import net.minecraft.network.protocol.game.ClientGamePacketListener;
|
||||
import net.minecraft.network.protocol.game.ClientboundBlockEntityDataPacket;
|
||||
import net.minecraft.world.level.block.entity.BlockEntity;
|
||||
import net.minecraft.world.level.block.state.BlockState;
|
||||
import net.minecraft.world.level.storage.ValueInput;
|
||||
@@ -123,6 +127,35 @@ public class VideoAnchorBlockEntity extends BlockEntity {
|
||||
out.putBoolean("autoplay", autoplay);
|
||||
}
|
||||
|
||||
/**
|
||||
* Vanilla chunk-load BE sync. The base implementation returns an empty tag, which means
|
||||
* when a client first sees this BE (chunk loads or player walks into range) it gets default
|
||||
* values — url="" in particular makes the renderer no-op and the panel appears invisible.
|
||||
*
|
||||
* <p>Returning {@link #toNbt()} here carries the custom fields in the vanilla packet, so
|
||||
* we don't depend on the {@code SyncAnchorPayload} arriving before the chunk's block-update
|
||||
* packet (there's a race: {@code level.setBlock} queues a deferred chunk broadcast while
|
||||
* {@code ServerPlayNetworking.send} writes immediately; if the payload wins, the client
|
||||
* drops it because the BE doesn't exist yet, then the chunk packet creates the BE with
|
||||
* defaults). It also fixes "player walks far away and comes back" — that path has no
|
||||
* SyncAnchorPayload at all, just vanilla chunk re-sync.
|
||||
*/
|
||||
@Override
|
||||
public CompoundTag getUpdateTag(HolderLookup.Provider provider) {
|
||||
return toNbt();
|
||||
}
|
||||
|
||||
/**
|
||||
* Triggers a {@link ClientboundBlockEntityDataPacket} whenever the chunk tracker decides
|
||||
* this BE needs to push an update. Default implementation returns {@code null} (no packet
|
||||
* sent on BE change). Combined with {@link #getUpdateTag} above, every BE-state change a
|
||||
* client sees carries the full config.
|
||||
*/
|
||||
@Override
|
||||
public Packet<ClientGamePacketListener> getUpdatePacket() {
|
||||
return ClientboundBlockEntityDataPacket.create(this);
|
||||
}
|
||||
|
||||
@Override
|
||||
protected void loadAdditional(ValueInput in) {
|
||||
super.loadAdditional(in);
|
||||
|
||||
@@ -180,27 +180,24 @@ public class JavaCvBackend implements VideoBackend {
|
||||
// stale srcAddr — closing the grabber there frees the av_frame plane and the next
|
||||
// memcpy crashes inside StubRoutines::jbyte_disjoint_arraycopy (exactly the 4K-delete
|
||||
// crash dump we saw). So the safe rule is: only the decoder thread touches the
|
||||
// grabber. External stop signals `running=false`, stops the audio line, interrupts the
|
||||
// worker, and joins briefly; the worker's own `finally` calls grabber.close(). Inside
|
||||
// the loop, grab() unblocks via the rw_timeout/timeout options (3 s, set in runLoop)
|
||||
// even on a stuck HTTP read, so the join below normally returns within a frame.
|
||||
// grabber. External stop signals `running=false`, stops the audio line, interrupts
|
||||
// the worker, and returns immediately; the worker's own `finally` calls
|
||||
// grabber.close() whenever grab()/start() eventually returns.
|
||||
//
|
||||
// We deliberately do NOT join the worker. close() runs on the client tick thread (via
|
||||
// VideoPlayback.tick → Entry.close), and the worker can spend several seconds inside
|
||||
// the native FFmpeg probe at the top of runLoop — probesize=8 MB and
|
||||
// analyzeduration=2 s do not honor the `running` flag and Thread.interrupt() doesn't
|
||||
// unblock native I/O. A bounded join() there (the old 2 s) is exactly the "place then
|
||||
// immediately delete freezes the game for a moment" symptom: the worker hasn't
|
||||
// entered the grab() loop yet, so flipping running=false has no effect on it until
|
||||
// start() returns. The worker is a daemon, the audio line is already silenced above,
|
||||
// and Entry has been removed from the active map by the caller — nothing observable
|
||||
// depends on the grabber having been closed before this method returns.
|
||||
Thread t = worker;
|
||||
worker = null;
|
||||
if (t != null) {
|
||||
t.interrupt();
|
||||
try {
|
||||
t.join(2000);
|
||||
} catch (InterruptedException ie) {
|
||||
Thread.currentThread().interrupt();
|
||||
}
|
||||
if (t.isAlive()) {
|
||||
// Worker still blocked in native grab() — let it finish on its own. Its
|
||||
// finally still closes the grabber when grab() eventually returns / throws.
|
||||
// No native pointers leak in the meantime because we don't touch them here.
|
||||
VideoPlayerMod.LOG.warn(
|
||||
"[{}] decoder did not exit within 2 s of stop; orphaning until next grab() returns",
|
||||
VideoPlayerMod.MOD_ID);
|
||||
}
|
||||
}
|
||||
ready = false;
|
||||
}
|
||||
|
||||
@@ -22,6 +22,7 @@ import java.util.Set;
|
||||
import java.util.concurrent.ConcurrentHashMap;
|
||||
import java.util.concurrent.ExecutorService;
|
||||
import java.util.concurrent.Executors;
|
||||
import java.util.concurrent.atomic.AtomicLong;
|
||||
|
||||
/**
|
||||
* Client-side disk cache for preloaded HTTP video URLs. Driven by the {@code /videopreload}
|
||||
@@ -42,6 +43,14 @@ public final class VideoCache {
|
||||
private static final Map<String, Path> READY = new ConcurrentHashMap<>();
|
||||
/** urls whose download is currently queued or in flight. */
|
||||
private static final Set<String> IN_FLIGHT = ConcurrentHashMap.newKeySet();
|
||||
/**
|
||||
* Monotonic cache-generation counter. {@link #clearAll()} bumps this; every download
|
||||
* captures the value at submit time and bails (deletes its {@code .part} without
|
||||
* publishing) if the epoch has moved since. This is the cancellation channel for the
|
||||
* in-flight download — without it, {@code clearAll} only wipes already-finalized files
|
||||
* while the running download keeps writing and re-publishes one entry post-clear.
|
||||
*/
|
||||
private static final AtomicLong CACHE_EPOCH = new AtomicLong(0);
|
||||
|
||||
/**
|
||||
* Single-thread executor that serializes all downloads. Cap enforcement (the total
|
||||
@@ -121,11 +130,36 @@ public final class VideoCache {
|
||||
|
||||
/**
|
||||
* Wipe the entire cache directory and drop both indexes. Sent in response to
|
||||
* {@code /videoCache clear}. Best-effort per-file deletion; logs failures but doesn't
|
||||
* abort on the first one. In-flight downloads aren't cancelled — they'll fail at the
|
||||
* atomic-move step (target dir gone) and log a warning, which is fine.
|
||||
* {@code /videoCache clear}.
|
||||
*
|
||||
* <p>Three phases that need to stay in this order:
|
||||
* <ol>
|
||||
* <li>Bump the epoch first — that flips the cancellation flag for any in-flight
|
||||
* download. The download thread checks the epoch in the read loop and at the
|
||||
* move step, so after this point it will refuse to publish a new entry and
|
||||
* will delete its own {@code .part}.</li>
|
||||
* <li>Clear the in-memory indexes. (READY clears whatever was already finalized
|
||||
* pre-clear; IN_FLIGHT is wiped so a subsequent same-URL preload re-enters
|
||||
* the queue instead of getting deduped by stale state.)</li>
|
||||
* <li>Best-effort delete every regular file in the cache directory. We do this
|
||||
* last so that if the in-flight download was momentarily holding a {@code .part}
|
||||
* open, the listing here also catches its post-close residue (though normally
|
||||
* phase 1 → the download deletes its own part).</li>
|
||||
* </ol>
|
||||
*
|
||||
* <p>Best-effort per-file deletion; logs failures but doesn't abort on the first one.
|
||||
* On Windows the open {@code .part} may not be deletable here — phase 1's cancellation
|
||||
* + the download's own cleanup-on-bail handles that case.
|
||||
*/
|
||||
public static void clearAll() {
|
||||
// Phase 1: signal cancellation to any in-flight download BEFORE wiping disk.
|
||||
CACHE_EPOCH.incrementAndGet();
|
||||
|
||||
// Phase 2: drop indexes.
|
||||
READY.clear();
|
||||
IN_FLIGHT.clear();
|
||||
|
||||
// Phase 3: delete files on disk.
|
||||
int deleted = 0;
|
||||
int failed = 0;
|
||||
try {
|
||||
@@ -147,8 +181,6 @@ public final class VideoCache {
|
||||
VideoPlayerMod.LOG.warn("[{}] clearAll failed: {}",
|
||||
VideoPlayerMod.MOD_ID, t.toString());
|
||||
}
|
||||
READY.clear();
|
||||
IN_FLIGHT.clear();
|
||||
VideoPlayerMod.LOG.info("[{}] clearAll: deleted={} failed={}",
|
||||
VideoPlayerMod.MOD_ID, deleted, failed);
|
||||
notifyChat("[videocache] 전체 캐시 삭제: " + deleted + "개 파일", ChatFormatting.YELLOW);
|
||||
@@ -158,7 +190,11 @@ public final class VideoCache {
|
||||
public static void preload(String url) {
|
||||
if (url == null || url.isEmpty()) return;
|
||||
if (!(url.startsWith("http://") || url.startsWith("https://"))) return;
|
||||
if (READY.containsKey(url)) {
|
||||
// Use lookup() (which also verifies the file exists on disk) instead of
|
||||
// READY.containsKey — defends against READY containing a stale entry whose
|
||||
// backing file was removed by clearAll() / a user-side file delete. Without this,
|
||||
// a stale key would silently block a re-preload.
|
||||
if (lookup(url) != null) {
|
||||
VideoPlayerMod.LOG.info("[{}] preload: already cached {}", VideoPlayerMod.MOD_ID, url);
|
||||
notifyChat("[videopreload] 이미 캐시됨: " + url, ChatFormatting.GRAY);
|
||||
return;
|
||||
@@ -169,7 +205,11 @@ public final class VideoCache {
|
||||
return;
|
||||
}
|
||||
notifyChat("[videopreload] 다운로드 대기열 추가: " + url, ChatFormatting.YELLOW);
|
||||
DOWNLOAD_POOL.submit(() -> download(url));
|
||||
// Capture the current epoch at submit time. The download thread checks against
|
||||
// CACHE_EPOCH later — any mismatch means clearAll() ran in between and this
|
||||
// download must abort without publishing.
|
||||
long epoch = CACHE_EPOCH.get();
|
||||
DOWNLOAD_POOL.submit(() -> download(url, epoch));
|
||||
}
|
||||
|
||||
/** Return the local cached file path for this URL, or {@code null} if not yet ready. */
|
||||
@@ -186,6 +226,40 @@ public final class VideoCache {
|
||||
IN_FLIGHT.clear();
|
||||
}
|
||||
|
||||
/**
|
||||
* Wipe the cache directory at game shutdown so the user doesn't accumulate disk usage
|
||||
* across sessions. Distinct from {@link #clearAll()}: at shutdown there are no concurrent
|
||||
* downloads to race and no player to chat-notify, so we skip the chat ping but still bump
|
||||
* the epoch (defensive — any straggler write inside the in-flight {@code .part} stream
|
||||
* will detect the bump and self-clean) and drop indexes.
|
||||
*/
|
||||
public static void wipeOnShutdown() {
|
||||
CACHE_EPOCH.incrementAndGet();
|
||||
READY.clear();
|
||||
IN_FLIGHT.clear();
|
||||
int deleted = 0;
|
||||
int failed = 0;
|
||||
try {
|
||||
Path dir = cacheDir();
|
||||
if (dir != null && Files.isDirectory(dir)) {
|
||||
try (var stream = Files.newDirectoryStream(dir)) {
|
||||
for (Path p : stream) {
|
||||
try {
|
||||
if (Files.isRegularFile(p) && Files.deleteIfExists(p)) deleted++;
|
||||
} catch (Throwable t) {
|
||||
failed++;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
} catch (Throwable t) {
|
||||
VideoPlayerMod.LOG.warn("[{}] wipeOnShutdown failed: {}",
|
||||
VideoPlayerMod.MOD_ID, t.toString());
|
||||
}
|
||||
VideoPlayerMod.LOG.info("[{}] wipeOnShutdown: deleted={} failed={}",
|
||||
VideoPlayerMod.MOD_ID, deleted, failed);
|
||||
}
|
||||
|
||||
/** Caller-supplied: current set of URLs that are fully cached, for diagnostics. */
|
||||
public static Set<String> readyUrls() {
|
||||
return new HashSet<>(READY.keySet());
|
||||
@@ -193,25 +267,70 @@ public final class VideoCache {
|
||||
|
||||
// -- internals -----------------------------------------------------------------------
|
||||
|
||||
private static void download(String url) {
|
||||
/**
|
||||
* Publish {@code path} into {@link #READY} for {@code url}, but only if the cache
|
||||
* epoch hasn't moved since {@code startEpoch} was captured. Wraps the
|
||||
* pre-check / put / post-check / rollback dance so every publish site uses the
|
||||
* same race-free pattern instead of re-implementing it.
|
||||
*
|
||||
* <p>Race coverage: if {@link #clearAll()} runs at any point between the
|
||||
* pre-check and the post-check, the post-check sees the epoch bump and we
|
||||
* roll back — {@link Map#remove(Object, Object)} is a compareAndRemove so we
|
||||
* don't clobber a legitimate concurrent put under the same key, and we delete
|
||||
* the on-disk file because clearAll's directory scan may have missed it (the
|
||||
* file may not have existed yet when clearAll ran).
|
||||
*
|
||||
* @return {@code true} if the entry is now published; {@code false} if the
|
||||
* caller's work was cancelled and {@code path} has been cleaned up.
|
||||
*/
|
||||
private static boolean publishIfNotCancelled(String url, Path path, long startEpoch) {
|
||||
// If the wipe ran between download's pre-move epoch check and Files.move, its
|
||||
// directory scan won't have seen this just-promoted file. We must delete it here,
|
||||
// not just bail — otherwise the freshly-moved final file leaks across shutdown.
|
||||
if (CACHE_EPOCH.get() != startEpoch) {
|
||||
try { Files.deleteIfExists(path); } catch (Throwable ignored) {}
|
||||
return false;
|
||||
}
|
||||
READY.put(url, path);
|
||||
if (CACHE_EPOCH.get() != startEpoch) {
|
||||
READY.remove(url, path);
|
||||
try { Files.deleteIfExists(path); } catch (Throwable ignored) {}
|
||||
return false;
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
private static void download(String url, long startEpoch) {
|
||||
Path cacheDir = cacheDir();
|
||||
Path partPath = null;
|
||||
try {
|
||||
if (cacheDir == null) {
|
||||
VideoPlayerMod.LOG.warn("[{}] preload: no game dir, skipping {}",
|
||||
VideoPlayerMod.MOD_ID, url);
|
||||
return;
|
||||
}
|
||||
// Pre-flight cancellation check — if clearAll already ran between submit and now,
|
||||
// skip the whole thing. Avoids creating directories / .part files post-clear.
|
||||
if (CACHE_EPOCH.get() != startEpoch) {
|
||||
VideoPlayerMod.LOG.info("[{}] preload: cancelled before start (clearAll ran) — {}",
|
||||
VideoPlayerMod.MOD_ID, url);
|
||||
return;
|
||||
}
|
||||
Files.createDirectories(cacheDir);
|
||||
|
||||
String hash = sha256(url);
|
||||
String ext = extensionFromUrl(url);
|
||||
Path finalPath = cacheDir.resolve(hash + ext);
|
||||
Path partPath = cacheDir.resolve(hash + ext + ".part");
|
||||
partPath = cacheDir.resolve(hash + ext + ".part");
|
||||
|
||||
// Resume-friendly: if the file's already on disk from an earlier session, just
|
||||
// index it without re-downloading.
|
||||
if (Files.exists(finalPath) && Files.size(finalPath) > 0) {
|
||||
READY.put(url, finalPath);
|
||||
if (!publishIfNotCancelled(url, finalPath, startEpoch)) {
|
||||
VideoPlayerMod.LOG.info("[{}] preload: reindex cancelled (clearAll ran) — {}",
|
||||
VideoPlayerMod.MOD_ID, url);
|
||||
return;
|
||||
}
|
||||
VideoPlayerMod.LOG.info("[{}] preload: indexed existing cache {} -> {}",
|
||||
VideoPlayerMod.MOD_ID, url, finalPath.getFileName());
|
||||
notifyChat("[videopreload] 기존 캐시 사용: " + url, ChatFormatting.GREEN);
|
||||
@@ -250,21 +369,30 @@ public final class VideoCache {
|
||||
}
|
||||
|
||||
long total = 0;
|
||||
boolean cancelled = false;
|
||||
try (InputStream in = raw.getInputStream();
|
||||
OutputStream out = Files.newOutputStream(partPath)) {
|
||||
byte[] buf = new byte[64 * 1024];
|
||||
int n;
|
||||
while ((n = in.read(buf)) >= 0) {
|
||||
// Cancellation check inside the loop. Break (not return) so the try-with
|
||||
// closes the output stream first — on Windows, deleting an open .part can
|
||||
// fail with AccessDeniedException, so we always close before deleting.
|
||||
if (CACHE_EPOCH.get() != startEpoch) {
|
||||
cancelled = true;
|
||||
break;
|
||||
}
|
||||
total += n;
|
||||
if (total > MAX_BYTES) {
|
||||
long capMb = MAX_BYTES / (1024 * 1024);
|
||||
VideoPlayerMod.LOG.warn(
|
||||
"[{}] preload: {} exceeded per-video {} MB cap; aborting",
|
||||
VideoPlayerMod.MOD_ID, url, capMb);
|
||||
try { Files.deleteIfExists(partPath); } catch (Throwable ignored) {}
|
||||
// Same close-before-delete dance for Windows.
|
||||
cancelled = true;
|
||||
notifyChat("[videopreload] 실패 (단일 영상 " + capMb + "MB 초과): " + url,
|
||||
ChatFormatting.RED);
|
||||
return;
|
||||
break;
|
||||
}
|
||||
if (existingCacheBytes + total > MAX_CACHE_BYTES) {
|
||||
long capMb = MAX_CACHE_BYTES / (1024 * 1024);
|
||||
@@ -272,18 +400,42 @@ public final class VideoCache {
|
||||
VideoPlayerMod.LOG.warn(
|
||||
"[{}] preload: total-cache cap exceeded ({}>{} MB); aborting {}",
|
||||
VideoPlayerMod.MOD_ID, usedMb, capMb, url);
|
||||
try { Files.deleteIfExists(partPath); } catch (Throwable ignored) {}
|
||||
cancelled = true;
|
||||
notifyChat("[videopreload] 실패 (전체 캐시 " + capMb + "MB 초과): " + url,
|
||||
ChatFormatting.RED);
|
||||
return;
|
||||
break;
|
||||
}
|
||||
out.write(buf, 0, n);
|
||||
}
|
||||
}
|
||||
// Now the .part file is closed — safe to delete on Windows.
|
||||
if (cancelled) {
|
||||
try { Files.deleteIfExists(partPath); } catch (Throwable ignored) {}
|
||||
return;
|
||||
}
|
||||
|
||||
// Pre-move cancellation check. If clearAll ran during the read loop, abort
|
||||
// before promoting .part to final — saves a wasted move + delete.
|
||||
if (CACHE_EPOCH.get() != startEpoch) {
|
||||
VideoPlayerMod.LOG.info("[{}] preload: cancelled before move (clearAll ran) — {}",
|
||||
VideoPlayerMod.MOD_ID, url);
|
||||
try { Files.deleteIfExists(partPath); } catch (Throwable ignored) {}
|
||||
return;
|
||||
}
|
||||
|
||||
Files.move(partPath, finalPath, StandardCopyOption.REPLACE_EXISTING,
|
||||
StandardCopyOption.ATOMIC_MOVE);
|
||||
READY.put(url, finalPath);
|
||||
|
||||
// Race-safe publish: this covers the window between Files.move and READY.put
|
||||
// (clearAll deletes the freshly-moved file then we resurrect it in READY) AND
|
||||
// the window between READY.put and the "완료" notification (clearAll wipes
|
||||
// READY then we re-publish + emit stale completion chat). publishIfNotCancelled
|
||||
// rolls back both READY and the on-disk file if the epoch moved at any time.
|
||||
if (!publishIfNotCancelled(url, finalPath, startEpoch)) {
|
||||
VideoPlayerMod.LOG.info("[{}] preload: cancelled at publish (clearAll ran) — {}",
|
||||
VideoPlayerMod.MOD_ID, url);
|
||||
return;
|
||||
}
|
||||
VideoPlayerMod.LOG.info("[{}] preload: cached {} ({} bytes) -> {}",
|
||||
VideoPlayerMod.MOD_ID, url, total, finalPath.getFileName());
|
||||
long mb = Math.max(1, total / (1024 * 1024));
|
||||
@@ -293,6 +445,10 @@ public final class VideoCache {
|
||||
VideoPlayerMod.MOD_ID, url, t.toString());
|
||||
notifyChat("[videopreload] 실패 (" + t.getClass().getSimpleName() + "): " + url,
|
||||
ChatFormatting.RED);
|
||||
// Best-effort cleanup of any leftover .part on the error path.
|
||||
if (partPath != null) {
|
||||
try { Files.deleteIfExists(partPath); } catch (Throwable ignored) {}
|
||||
}
|
||||
} finally {
|
||||
IN_FLIGHT.remove(url);
|
||||
}
|
||||
|
||||
@@ -31,8 +31,19 @@ import org.joml.Matrix4f;
|
||||
@Environment(EnvType.CLIENT)
|
||||
public class VideoAnchorRenderer implements BlockEntityRenderer<VideoAnchorBlockEntity, VideoAnchorRenderer.State> {
|
||||
|
||||
/** Tiny outward offset so the quad doesn't z-fight with the wall. */
|
||||
private static final float SURFACE_EPSILON = 0.001F;
|
||||
/**
|
||||
* Outward offset so the quad doesn't z-fight with the wall it sits on.
|
||||
*
|
||||
* <p>Depth-buffer precision drops with the square of view distance: with near=0.05 and
|
||||
* 24-bit depth, the smallest resolvable step at 30 blocks is ~1mm, and ~12mm at 100
|
||||
* blocks. The old 0.001 (1mm) offset was right at the precision boundary at ~30 blocks
|
||||
* — which is exactly the distance users started seeing the wall texture flicker through
|
||||
* the video panel once {@code render_distance_blocks} was raised past the default.
|
||||
*
|
||||
* <p>2cm gives ~20× margin at 30 blocks and is still visually unnoticeable up close
|
||||
* (~3% of a block thickness).
|
||||
*/
|
||||
private static final float SURFACE_EPSILON = 0.02F;
|
||||
|
||||
public VideoAnchorRenderer(BlockEntityRendererProvider.Context ctx) {
|
||||
// no-op
|
||||
@@ -75,7 +86,12 @@ public class VideoAnchorRenderer implements BlockEntityRenderer<VideoAnchorBlock
|
||||
pose.translate(-0.5F, -0.5F, -0.5F + SURFACE_EPSILON);
|
||||
|
||||
final Matrix4f mat = new Matrix4f(pose.last().pose());
|
||||
RenderType rt = RenderTypes.entityCutout(tex);
|
||||
// entitySolid (not entityCutout): video frames come from swscale → AV_PIX_FMT_RGBA with
|
||||
// alpha hard-set to 255, so there is no alpha-tested cutout. Cutout's alpha-discard step
|
||||
// adds nothing here and makes distant sampling unstable — without mipmaps on a dynamic
|
||||
// texture, neighbouring texels can shimmer above/below the discard threshold at sub-pixel
|
||||
// sampling rates, contributing to the flicker users see once render distance is raised.
|
||||
RenderType rt = RenderTypes.entitySolid(tex);
|
||||
collector.submitCustomGeometry(pose, rt, (poseUnused, vc) -> {
|
||||
// Single-sided: the back of the anchor is by design pressed against the wall the
|
||||
// player clicked, so a back face is pure GPU waste. Halves the fragment shader work
|
||||
|
||||
@@ -0,0 +1,45 @@
|
||||
package com.ejclaw.videoplayer.command;
|
||||
|
||||
import net.minecraft.commands.CommandSourceStack;
|
||||
import net.minecraft.server.permissions.Permissions;
|
||||
import net.minecraft.world.entity.player.Player;
|
||||
|
||||
/**
|
||||
* Shared {@code .requires(...)} predicate for all {@code /video*} commands.
|
||||
*
|
||||
* <p>Semantics:
|
||||
* <ul>
|
||||
* <li><b>Player source</b> — must be OP (permission level ≥ 2, via
|
||||
* {@link Permissions#COMMANDS_GAMEMASTER}). Non-OP players don't even see the command
|
||||
* in tab-completion.</li>
|
||||
* <li><b>Non-player source</b> — server console, command block, and datapack
|
||||
* {@code /function} are always allowed regardless of any permission level
|
||||
* or gamerule. This means admins don't need to bump {@code functionPermissionLevel}
|
||||
* just to drive {@code /videoPlace} etc. from a datapack function.</li>
|
||||
* </ul>
|
||||
*
|
||||
* <p>The bypass for non-player sources is safe because reaching one of those execution
|
||||
* contexts already requires server-operator trust:
|
||||
* <ul>
|
||||
* <li>Console — physical/admin access to the server.</li>
|
||||
* <li>Command block — placing one requires OP + {@code /gamerule sendCommandFeedback}
|
||||
* privileges, and {@code /execute as} preserves the underlying source's permissions
|
||||
* (so a non-OP player can't smuggle commands through one).</li>
|
||||
* <li>Datapack function — installed by the server admin.</li>
|
||||
* </ul>
|
||||
*/
|
||||
public final class CommandPermissions {
|
||||
private CommandPermissions() {}
|
||||
|
||||
/**
|
||||
* Returns {@code true} when the source is allowed to run a {@code /video*} command.
|
||||
*
|
||||
* <p>Player → OP only. Anything else → always allowed.
|
||||
*/
|
||||
public static boolean opOrServer(CommandSourceStack s) {
|
||||
if (s.getEntity() instanceof Player) {
|
||||
return s.permissions().hasPermission(Permissions.COMMANDS_GAMEMASTER);
|
||||
}
|
||||
return true;
|
||||
}
|
||||
}
|
||||
@@ -20,7 +20,6 @@ import net.minecraft.network.chat.MutableComponent;
|
||||
import net.minecraft.network.chat.Style;
|
||||
import net.minecraft.server.MinecraftServer;
|
||||
import net.minecraft.server.level.ServerPlayer;
|
||||
import net.minecraft.server.permissions.Permissions;
|
||||
|
||||
import java.net.URI;
|
||||
import java.util.Map;
|
||||
@@ -32,8 +31,9 @@ import java.util.Map;
|
||||
* <br>{@code /videocache remove <name>} — drop the entry from server config and tell every client
|
||||
* to delete the matching cache file.
|
||||
*
|
||||
* <p>Replaces the old {@code /videopreload}. Same permission gate
|
||||
* ({@link Permissions#COMMANDS_GAMEMASTER}) so command blocks can drive it.
|
||||
* <p>Replaces the old {@code /videopreload}. Permission gate via
|
||||
* {@link CommandPermissions#opOrServer(CommandSourceStack)} so command blocks and datapack
|
||||
* functions can drive it without touching {@code functionPermissionLevel}.
|
||||
*/
|
||||
public final class VideoCacheCommand {
|
||||
private VideoCacheCommand() {}
|
||||
@@ -44,7 +44,7 @@ public final class VideoCacheCommand {
|
||||
|
||||
private static LiteralArgumentBuilder<CommandSourceStack> build(String root) {
|
||||
return Commands.literal(root)
|
||||
.requires(s -> s.permissions().hasPermission(Permissions.COMMANDS_GAMEMASTER))
|
||||
.requires(CommandPermissions::opOrServer)
|
||||
.then(Commands.literal("add")
|
||||
.then(Commands.argument("name", StringArgumentType.word())
|
||||
.then(Commands.argument("url", StringArgumentType.greedyString())
|
||||
|
||||
@@ -9,7 +9,6 @@ import net.minecraft.commands.arguments.coordinates.BlockPosArgument;
|
||||
import net.minecraft.core.BlockPos;
|
||||
import net.minecraft.network.chat.Component;
|
||||
import net.minecraft.server.level.ServerLevel;
|
||||
import net.minecraft.server.permissions.Permissions;
|
||||
import net.minecraft.world.level.block.Block;
|
||||
import net.minecraft.world.level.block.Blocks;
|
||||
|
||||
@@ -24,7 +23,7 @@ public final class VideoDeleteCommand {
|
||||
private static com.mojang.brigadier.builder.LiteralArgumentBuilder<CommandSourceStack>
|
||||
build(String name) {
|
||||
return Commands.literal(name)
|
||||
.requires(s -> s.permissions().hasPermission(Permissions.COMMANDS_GAMEMASTER))
|
||||
.requires(CommandPermissions::opOrServer)
|
||||
.then(Commands.argument("pos", BlockPosArgument.blockPos())
|
||||
.executes(VideoDeleteCommand::run));
|
||||
}
|
||||
|
||||
@@ -14,7 +14,6 @@ import net.minecraft.core.BlockPos;
|
||||
import net.minecraft.network.chat.Component;
|
||||
import net.minecraft.server.level.ServerLevel;
|
||||
import net.minecraft.server.level.ServerPlayer;
|
||||
import net.minecraft.server.permissions.Permissions;
|
||||
|
||||
/** SPEC §4.5.1 — {@code /videoMute <pos> <on|off>} */
|
||||
public final class VideoMuteCommand {
|
||||
@@ -27,7 +26,7 @@ public final class VideoMuteCommand {
|
||||
private static com.mojang.brigadier.builder.LiteralArgumentBuilder<CommandSourceStack>
|
||||
build(String name) {
|
||||
return Commands.literal(name)
|
||||
.requires(s -> s.permissions().hasPermission(Permissions.COMMANDS_GAMEMASTER))
|
||||
.requires(CommandPermissions::opOrServer)
|
||||
.then(Commands.argument("pos", BlockPosArgument.blockPos())
|
||||
.then(Commands.argument("state", StringArgumentType.word())
|
||||
.executes(VideoMuteCommand::run)));
|
||||
|
||||
@@ -19,13 +19,32 @@ import net.minecraft.nbt.CompoundTag;
|
||||
import net.minecraft.network.chat.Component;
|
||||
import net.minecraft.server.level.ServerLevel;
|
||||
import net.minecraft.server.level.ServerPlayer;
|
||||
import net.minecraft.server.permissions.Permissions;
|
||||
import net.minecraft.world.level.block.Block;
|
||||
|
||||
/** SPEC §4.5.1 — {@code /videoPlace <pos> <facing> <width> <height> <url>} */
|
||||
/**
|
||||
* SPEC §4.5.1 — {@code /videoPlace} has two accepted forms:
|
||||
*
|
||||
* <ul>
|
||||
* <li><b>Legacy 5-arg</b>: {@code /videoPlace <pos> <facing> <width> <height> <url>}
|
||||
* — preserved for existing command blocks. Volume defaults to 50% and muted=false.
|
||||
* The {@code url} here is a single-token string so it doesn't swallow the {@code volume}
|
||||
* slot of the new form.</li>
|
||||
* <li><b>New 6-arg</b>: {@code /videoPlace <pos> <facing> <width> <height> <volume> <url>}
|
||||
* — {@code volume} is 0..100 (percent) or {@code -1} to start muted. The percent form
|
||||
* mirrors the GUI slider; {@code -1} is a CLI shortcut so admins don't need a follow-up
|
||||
* {@code /videoMute} step. {@code url} is greedy here, so URLs containing spaces (rare
|
||||
* but possible after URL-decoding) still work.</li>
|
||||
* </ul>
|
||||
*
|
||||
* <p>Brigadier disambiguates the two by the type of the 5th argument: integer → new form,
|
||||
* non-integer token → legacy form.
|
||||
*/
|
||||
public final class VideoPlaceCommand {
|
||||
private VideoPlaceCommand() {}
|
||||
|
||||
/** Default volume (percent) applied to the legacy 5-arg form. */
|
||||
private static final int DEFAULT_VOLUME_PCT = 50;
|
||||
|
||||
public static void register(CommandDispatcher<CommandSourceStack> dispatcher) {
|
||||
dispatcher.register(build("videoPlace"));
|
||||
}
|
||||
@@ -33,17 +52,38 @@ public final class VideoPlaceCommand {
|
||||
private static com.mojang.brigadier.builder.LiteralArgumentBuilder<CommandSourceStack>
|
||||
build(String name) {
|
||||
return Commands.literal(name)
|
||||
.requires(s -> s.permissions().hasPermission(Permissions.COMMANDS_GAMEMASTER))
|
||||
.requires(CommandPermissions::opOrServer)
|
||||
.then(Commands.argument("pos", BlockPosArgument.blockPos())
|
||||
.then(Commands.argument("facing", StringArgumentType.word())
|
||||
.then(Commands.argument("width", IntegerArgumentType.integer(1, 32))
|
||||
.then(Commands.argument("height", IntegerArgumentType.integer(1, 32))
|
||||
.then(Commands.argument("url", StringArgumentType.greedyString())
|
||||
.executes(VideoPlaceCommand::run))))));
|
||||
// New form: volume (int) + greedy url
|
||||
.then(Commands.argument("volume", IntegerArgumentType.integer(-1, 100))
|
||||
.then(Commands.argument("url", StringArgumentType.greedyString())
|
||||
.executes(ctx -> runNew(ctx))))
|
||||
// Legacy form: single-token url, no volume slot. Single-token string
|
||||
// is intentional so "<int> https://..." cannot be parsed as a legacy
|
||||
// url that happens to start with a number — Brigadier first tries the
|
||||
// new branch and only falls through here if "volume" isn't an int.
|
||||
.then(Commands.argument("url", StringArgumentType.string())
|
||||
.executes(ctx -> runLegacy(ctx)))))));
|
||||
}
|
||||
|
||||
private static int run(com.mojang.brigadier.context.CommandContext<CommandSourceStack> ctx)
|
||||
private static int runNew(com.mojang.brigadier.context.CommandContext<CommandSourceStack> ctx)
|
||||
throws CommandSyntaxException {
|
||||
int volumeArg = IntegerArgumentType.getInteger(ctx, "volume");
|
||||
String url = StringArgumentType.getString(ctx, "url");
|
||||
return runWithValues(ctx, volumeArg, url);
|
||||
}
|
||||
|
||||
private static int runLegacy(com.mojang.brigadier.context.CommandContext<CommandSourceStack> ctx)
|
||||
throws CommandSyntaxException {
|
||||
String url = StringArgumentType.getString(ctx, "url");
|
||||
return runWithValues(ctx, DEFAULT_VOLUME_PCT, url);
|
||||
}
|
||||
|
||||
private static int runWithValues(com.mojang.brigadier.context.CommandContext<CommandSourceStack> ctx,
|
||||
int volumeArg, String rawUrl) throws CommandSyntaxException {
|
||||
CommandSourceStack src = ctx.getSource();
|
||||
ServerLevel level = src.getLevel();
|
||||
BlockPos pos = BlockPosArgument.getLoadedBlockPos(ctx, "pos");
|
||||
@@ -54,7 +94,12 @@ public final class VideoPlaceCommand {
|
||||
}
|
||||
int width = IntegerArgumentType.getInteger(ctx, "width");
|
||||
int height = IntegerArgumentType.getInteger(ctx, "height");
|
||||
String raw = StringArgumentType.getString(ctx, "url").trim();
|
||||
// -1 is the CLI mute shortcut; the BE keeps the underlying volume so an admin can
|
||||
// /videoMute false later without re-typing a level. Anything 0..100 sets %-volume and
|
||||
// clears mute.
|
||||
boolean placeMuted = volumeArg < 0;
|
||||
float placeVolume = placeMuted ? 0.5F : (volumeArg / 100.0F);
|
||||
String raw = rawUrl == null ? "" : rawUrl.trim();
|
||||
// Accept either an http(s) URL or a /videoCache add <name> entry: resolveUrlOrName()
|
||||
// returns the canonical URL in both cases, or null when a non-URL string didn't match
|
||||
// any named entry.
|
||||
@@ -75,6 +120,8 @@ public final class VideoPlaceCommand {
|
||||
be.setWidth(width);
|
||||
be.setHeight(height);
|
||||
be.setUrl(url);
|
||||
be.setVolume(placeVolume);
|
||||
be.setMuted(placeMuted);
|
||||
|
||||
CompoundTag nbt = be.toNbt();
|
||||
for (ServerPlayer p : PlayerLookup.tracking(level, pos)) {
|
||||
|
||||
@@ -12,7 +12,11 @@ public final class VideoStickCommand {
|
||||
private VideoStickCommand() {}
|
||||
|
||||
public static void register(CommandDispatcher<CommandSourceStack> dispatcher) {
|
||||
// 플레이어는 OP(level 2+) 만, 콘솔/커맨드블럭/함수(/function) 는 무조건 통과.
|
||||
// 따라서 functionPermissionLevel 같은 gamerule 을 만질 필요가 없다.
|
||||
// 일반 플레이어(level 0) 는 탭 자동완성에도 안 떠야 정상.
|
||||
dispatcher.register(Commands.literal("videoStick")
|
||||
.requires(CommandPermissions::opOrServer)
|
||||
.executes(ctx -> run(ctx.getSource())));
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user